You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/08 00:02:12 UTC
[jira] [Commented] (THRIFT-4355) Javascript indentation incorrect
when defaulting field attribute to a struct
[ https://issues.apache.org/jira/browse/THRIFT-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195947#comment-16195947 ]
ASF GitHub Bot commented on THRIFT-4355:
----------------------------------------
GitHub user bforbis opened a pull request:
https://github.com/apache/thrift/pull/1388
THRIFT-4355 Fix javascript indentation of default values
Using the following test thrift file to test indentation in generated ttypes output.
```struct Object {
1: map<string, string> hashWithDefault = {"foo": "bar", "baz": "bat"}
2: list<string> arrayWithDefault = ["foo", "bar", "baz"]
3: OtherObject otherObject
4: string foostring
}
struct OtherObject {
1: Object objectWithDefault = {"hashWithDefault": {"baz": "bat", "bam": "bot"}, "arrayWithDefault": ["a", "b", "c"], "foostring": "foostringvalue"
2: string primitiveStringType
}
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bforbis/thrift THRIFT-4355-javascript-indentation-incorrect
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1388.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1388
----
commit a2dbbfd0fe8e4b74ea78a4a7c46903c6f28fa737
Author: Brian Forbis <bf...@athenahealth.com>
Date: 2017-10-07T23:57:40Z
THRIFT-4355 Fix javascript indentation of default values
----
> Javascript indentation incorrect when defaulting field attribute to a struct
> ----------------------------------------------------------------------------
>
> Key: THRIFT-4355
> URL: https://issues.apache.org/jira/browse/THRIFT-4355
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler, Node.js - Compiler
> Affects Versions: 0.10.0
> Reporter: Brian Forbis
> Priority: Trivial
>
> This is the same bug described in THRIFT-4334 for the perl compiler, which has also manifested in the javascript compilers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)