You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/08/22 17:16:48 UTC
[GitHub] incubator-beam pull request #861: Don't fire extra timers at the Max Timesta...
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/861
Don't fire extra timers at the Max Timestamp
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Any expired/GCable windows should be done via the GC event time timer.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam test_stream_flaky
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/861.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #861
----
commit b562072b868bff14d7c33a64d05056c604710884
Author: Thomas Groh <tg...@google.com>
Date: 2016-08-22T16:23:57Z
Remove unused constant in ExecutorServiceParallelExecutor
commit a65be9f92c26ffbd00a72a644d619e636ba04b6e
Author: Thomas Groh <tg...@google.com>
Date: 2016-08-22T17:05:35Z
Remove extra timer firings in WatermarkManager
These timers should not be fired - the windows should be expired via the
GC timer, and any elements should be emitted if neccessary.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #861: Don't fire extra timers at the Max Timesta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/861
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---