You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/08/20 16:57:00 UTC
[jira] [Commented] (AIRFLOW-4763) DockerOperator command parameter
does not allow lists
[ https://issues.apache.org/jira/browse/AIRFLOW-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911557#comment-16911557 ]
ASF subversion and git services commented on AIRFLOW-4763:
----------------------------------------------------------
Commit 1731d2dc9631344ee60e7f1bf2d674cd5d3b1ad1 in airflow's branch refs/heads/v1-10-test from Akshesh Doshi
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=1731d2d ]
[AIRFLOW-4763] Allow list in DockerOperator.command (#5408)
(cherry picked from commit 2b94600d629814b91415bc0f5472a336f61a873a)
> DockerOperator command parameter does not allow lists
> -----------------------------------------------------
>
> Key: AIRFLOW-4763
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4763
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.4
> Reporter: Akshesh Doshi
> Assignee: Akshesh Doshi
> Priority: Minor
> Labels: docker
> Fix For: 1.10.5
>
>
> According to the docstring `command` parameter allows `list` as input ([https://github.com/apache/airflow/blob/master/airflow/operators/docker_operator.py#L56])
> But the `strip` function being called here indicates that `command` is assumed to be a string ([https://github.com/apache/airflow/blob/master/airflow/operators/docker_operator.py#L250])
>
>
> It would be very nice to allow `list` inputs as well. I think the fix would be to add this before the line calling `.strip()`:
> {code:python}
> if type(command) == list:
> commands = command
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)