[jira] [Commented] (SPARK-22269) Java style checks should be run in Jenkins

["Marcelo Vanzin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-22269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202710#comment-16202710 ] 

Marcelo Vanzin commented on SPARK-22269:
----------------------------------------

I've heard in the past that this wasn't desired because `lint-java` uses maven. Perhaps it's time to try something like https://github.com/etsy/sbt-checkstyle-plugin

> Java style checks should be run in Jenkins
> ------------------------------------------
>
>                 Key: SPARK-22269
>                 URL: https://issues.apache.org/jira/browse/SPARK-22269
>             Project: Spark
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.3.0
>            Reporter: Andrew Ash
>
> A few times now I've gone to build the master branch and it's failed due to Java style errors, which I've sent in PRs to fix:
> - https://issues.apache.org/jira/browse/SPARK-22268
> - https://issues.apache.org/jira/browse/SPARK-21875
> Digging through the history a bit, it looks like this check used to run on Jenkins and was previously enabled at https://github.com/apache/spark/pull/10763 but then reverted at https://github.com/apache/spark/commit/4bcea1b8595424678aa6c92d66ba08c92e0fefe5
> We should work out what it takes to enable the Java check in Jenkins so these kinds of errors are caught in CI rather than afterwards post-merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org