You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2016/05/18 13:40:14 UTC
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2003
[FLINK-3909] update Maven Failsafe version
Failures during execution of the integration tests with the Maven
Failsafe plugin were silently ignored on Travis with Maven version
3.2.5. The problem is that failures are not passed on correctly from the
'integration-test' phase (where failures are recorded and tolerated) to
the 'verify' phase.
The cause of the error is most likely SUREFIRE-1127. An exception in the
'integration-test' is sometimes not flushed back to disk where it is
evaluated in the 'verify' phase. Bumping the version of the Failsafe
plugin from 2.18.1 to 2.19.1 fixes the issue.
Tests will fail for this PR ;)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3909
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2003.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2003
----
commit dc2530d72609032a2ca72e82b83709c46bd5db96
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-05-18T12:34:06Z
[FLINK-3909] update Maven Failsafe version
Failures during execution of the integration tests with the Maven
Failsafe plugin were silently ignored on Travis with Maven version
3.2.5. The problem is that failures are not passed on correctly from the
'integration-test' phase (where failures are recorded and tolerated) to
the 'verify' phase.
The cause of the error is most likely SUREFIRE-1127. An exception in the
'integration-test' is sometimes not flushed back to disk where it is
evaluated in the 'verify' phase. Bumping the version of the Failsafe
plugin from 2.18.1 to 2.19.1 fixes the issue.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220267821
Reverting back to version `2.17` it works again (at least the plugin does not complain about the `NoSuchMethodError`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220269992
@aljoscha Yes, I think so too :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220087832
Couldn't find the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220270745
The question is whether this bug was introduced with version `2.18.1` or whether it was already there in version `2.17`. We originally bumped the version to `2.18` in order to allow retries for the `ElasticSearchSinkITCase`. But if it works with the Surefire plugin, then we can also do this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220388275
I get segfaults from RocksDB in my Travis tests: https://travis-ci.org/mxm/flink/builds/131412162
Let's see how the builds here go. All in all, looks ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220642391
Merging...we need to fix the RocksDB issue afterwards. In the worst case, we'll comment out the relevant test cases for now. The test which seems to cause the segfaults is `EventTimeWindowCheckpointingITCase`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220269755
But maybe it only works since the exceptions are silently ignored and not forwarded?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220044747
Good fix! The failures went unnoticed before, I guess?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2003
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220269898
If we can't resolve issues with the Failsafe plugin, we could switch to using the Surefire plugin also for Integration tests. Actually, the only benefit of the Failsafe plugin is that it enables to use different phases to reuse test infrastructure that is costly, e.g. `pre-integration-test`, `post-integration-test`, `integration-test`, `verify`. However, we only use the `integration-test` phase. We don't have any special code in the `verify` phase, other than Failsafe's own mechanism to check for test failures which seems to be broken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220081808
Running the tests from within IntelliJ works fine without a problem. I guess it has something todo how failsafe `2.19` handles dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220272107
\U0001f44d and make sure that the tests were not silently failing with 2.17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220276542
I just replaced Failsafe with Surefire. Also updated the version of Surefire in a separate commit to see if the classpath issues occur there as well (after all it's the same Apache project).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220098334
Could you reproduce the problem on your laptop?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220035850
Tests fail in flink-runtime now. Seem to be class path related problems.
```
CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase.org.apache.flink.runtime.checkpoint.CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase » NoClassDefFound
CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase.<clinit>:53 » NoSuchMethod
CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase.testSerialIncrementAndGet » NoClassDefFound
CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase.testSetCount » NoClassDefFound
ZooKeeperCompletedCheckpointStoreITCase.org.apache.flink.runtime.checkpoint.ZooKeeperCompletedCheckpointStoreITCase » NoClassDefFound
ZooKeeperCompletedCheckpointStoreITCase.testAddAndGetLatestCheckpoint » NoClassDefFound
ZooKeeperCompletedCheckpointStoreITCase.testAddCheckpointMoreThanMaxRetained » NoClassDefFound
ZooKeeperCompletedCheckpointStoreITCase.testDiscardAllCheckpoints » NoClassDefFound
ZooKeeperCompletedCheckpointStoreITCase.testEmptyState » NoClassDefFound Could...
ZooKeeperCompletedCheckpointStoreITCase.testExceptionOnNoRetainedCheckpoints » NoClassDefFound
ZooKeeperCompletedCheckpointStoreITCase.testGetAllCheckpoints » NoClassDefFound
ZooKeeperCompletedCheckpointStoreITCase.<clinit>:40 » NoSuchMethod org.apache....
ZooKeeperSubmittedJobGraphsStoreITCase.org.apache.flink.runtime.jobmanager.ZooKeeperSubmittedJobGraphsStoreITCase » NoClassDefFound
ZooKeeperSubmittedJobGraphsStoreITCase.testConcurrentAddJobGraph » NoClassDefFound
ZooKeeperSubmittedJobGraphsStoreITCase.<clinit>:58 » NoSuchMethod org.apache.f...
ZooKeeperSubmittedJobGraphsStoreITCase.testRecoverJobGraphs » NoClassDefFound ...
ZooKeeperSubmittedJobGraphsStoreITCase.testUpdateJobGraphYouDidNotGetOrAdd » NoClassDefFound
ZooKeeperStateHandleStoreITCase.org.apache.flink.runtime.zookeeper.ZooKeeperStateHandleStoreITCase » NoClassDefFound
ZooKeeperStateHandleStoreITCase.testAdd » NoClassDefFound Could not initialize...
ZooKeeperStateHandleStoreITCase.testAddAlreadyExistingPath » NoClassDefFound C...
ZooKeeperStateHandleStoreITCase.testAddDiscardStateHandleAfterFailure » NoClassDefFound
ZooKeeperStateHandleStoreITCase.testAddWithCreateMode » NoClassDefFound Could ...
ZooKeeperStateHandleStoreITCase.testGetAll » NoClassDefFound Could not initial...
ZooKeeperStateHandleStoreITCase.testGetAllSortedByName » NoClassDefFound Could...
ZooKeeperStateHandleStoreITCase.testGetAndExists » NoClassDefFound Could not i...
ZooKeeperStateHandleStoreITCase.testGetNonExistingPath » NoClassDefFound Could...
ZooKeeperStateHandleStoreITCase.testRemove » NoClassDefFound Could not initial...
ZooKeeperStateHandleStoreITCase.testRemoveAndDiscardAllState » NoClassDefFound
ZooKeeperStateHandleStoreITCase.testRemoveAndDiscardState » NoClassDefFound Co...
ZooKeeperStateHandleStoreITCase.testRemoveWithCallback » NoClassDefFound Could...
ZooKeeperStateHandleStoreITCase.testReplace » NoClassDefFound Could not initia...
ZooKeeperStateHandleStoreITCase.<clinit>:66 » NoSuchMethod org.apache.flink.ru...
ZooKeeperStateHandleStoreITCase.testReplaceNonExistingPath » NoClassDefFound C...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220545613
The Travis builds here also segfault in all RocksDB tests. I'm assuming these test failed silently in the past since I can't make any connection to the test plugin changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220284867
Also pushed a version to my local Travis branch with some deliberately failing tests and debug output to see if the above tests are executed correctly (and don't fail silently).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220289348
Thanks @mxm ! Eagerly looking forward to the results...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220257496
I could reproduce it via maven on my machine. It is a bit odd since he complains that
```
org.apache.flink.runtime.util.ZooKeeperUtils.startCuratorFramework(Lorg/apache/flink/configuration/Configuration;)Lorg/apache/curator/framework/CuratorFramework
```
Even though `ZooKeeperUtils` is in `flink-runtime`. Maybe it has something to do with the shading and that `org.apache.curator.framework.CuratorFramework` has been relocated?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220271685
In the surefire JIRA, the "silently ignore exceptions" bug is tagged to affect 2.18, not 2.17, so it may be good.
How about:
- Checking if using surefire solves things
- If not, use failsafe 2.17 making sure it is not affected
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220321817
Thanks for looking into the problem and providing a detailed explanation @markreddy. I think we're good to go with the newest version of the Surefire plugin. I verified the tests 1) fail when errors occur 2) are actually run (added some debug output) 3) the number of tests/ITCases remains unchanged.
Just running one more time because I forgot to set the default of `reuseForks` to false for the integration tests. Reusing of forks doesn't work for some tests because of garbage collection problems (this was the same for the Failsafe plugin). Apparently almost all tests pass. So looking forward to merging this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version
Posted by markreddy <gi...@git.apache.org>.
Github user markreddy commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220307660
I took a look at the root issue of upgrading to 2.19.1. I'm able to reliably reproduce this issue on my laptop.
When I bump the version I get the same as @tillrohrmann
`java.lang.NoSuchMethodError:
org.apache.flink.runtime.util.ZooKeeperUtils.startCuratorFramework(Lorg/apache/flink/configuration/Configuration;)Lorg/apache/curator/framework/CuratorFramework`
When running the build in debug mode for both 2.18.1 and 2.19.1 I observed some differences in the classpath.
**2.18.1**
`[DEBUG] boot(compact) classpath: surefire-booter-2.18.1.jar surefire-api-2.18.1.jar test-classes classes flink-core-1.1-SNAPSHOT.jar.....`
**2.19.1**
`[DEBUG] boot(compact) classpath: surefire-booter-2.19.1.jar surefire-api-2.19.1.jar test-classes flink-runtime_2.10-1.1-SNAPSHOT.jar flink-core-1.1-SNAPSHOT.jar.....`
So 2.19.1 has changed behaviour. What is loaded onto the classpath differs, in 2.19.1 instead of loading target/classes it loads the actual built jar. https://issues.apache.org/jira/browse/SUREFIRE-855 confirms this.
The issue with this is the final jar has curator shaded while the test classes are looking for the unshaded version of curator, as shown by the debug output:
`Lorg/apache/curator/framework/CuratorFramework`
If @mxm can get everything working on a lower version thats the easiest solution. If not or we want to proceed with moving up in version, at least we know the root of the issue and can work from there....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---