[GitHub] [incubator-superset] willbarrett edited a comment on issue #9077: [SIP-35] Proposal for Improving Superset’s Python Code Organization

[GitBox <gi...@apache.org>]

willbarrett edited a comment on issue #9077: [SIP-35] Proposal for Improving Superset’s Python Code Organization
URL: https://github.com/apache/incubator-superset/issues/9077#issuecomment-587924995
 
 
   @john-bodley I didn't address your comment directly regarding blueprints. Let me do so now:
   
   I concur 100% with the idea of untangling the `app` references from the rest of the code. The problem we currently face with regards to blueprints is that:
   
   1. Blueprints cannot currently be nested (see [this issue on Flask](https://github.com/pallets/flask/issues/593))
   2. Flask-AppBuilder (FAB) currently leverages blueprints internally.
   
   Were we to move entirely to blueprints being defined in Superset, that would have substantial implications for the extent that we can leverage FAB in endpoints without either reworking FAB internals or adding the ability to nest blueprints to Flask. As we've been building out `/api/v1`, we've leveraged FAB's base classes, especially for GET endpoints.
   
   How would you recommend reconciling this problem?
   
   I think that @dpgaspar's suggestion for adding a `register_views` function to the `manager.py` files is a possible resolution - this would provide an API similar to blueprint functionality that could be leveraged in `app.py`. I'd be interested in your opinion on how close this would get us to resolving this issues you're bringing up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org