You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Paulex Yang (JIRA)" <ji...@apache.org> on 2006/06/07 07:55:29 UTC

[jira] Created: (HARMONY-567) [classlib][luni]java.util.Scanner constructors not implemented

[classlib][luni]java.util.Scanner constructors not implemented
--------------------------------------------------------------

         Key: HARMONY-567
         URL: http://issues.apache.org/jira/browse/HARMONY-567
     Project: Harmony
        Type: Bug

  Components: Classlib  
    Reporter: Paulex Yang
    Priority: Minor


Because of its big size, I'll try to implement Scanner in several steps, one JIRA/patch per step. Here goes the first one except the skeleton, the implementation of constructors. I'll attach patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-567) [classlib][luni]java.util.Scanner constructors not implemented

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-567?page=all ]

Paulex Yang updated HARMONY-567:
--------------------------------

    Attachment: 01.harmony567.diff
                02.harmony567.sh
                ScannerTest.java

Please try the diff and sh, thank you.

Please noted that the TODO in ScannerTest means some verification will be added when more methods are implemented.

> [classlib][luni]java.util.Scanner constructors not implemented
> --------------------------------------------------------------
>
>          Key: HARMONY-567
>          URL: http://issues.apache.org/jira/browse/HARMONY-567
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Priority: Minor
>  Attachments: 01.harmony567.diff, 02.harmony567.sh, ScannerTest.java
>
> Because of its big size, I'll try to implement Scanner in several steps, one JIRA/patch per step. Here goes the first one except the skeleton, the implementation of constructors. I'll attach patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[classlib][luni-util]Scanner completion(was Re: [jira] Closed: (HARMONY-567) [classlib][luni]java.util.Scanner constructors not implemented)

Posted by Paulex Yang <pa...@gmail.com>.
Ah, thank you, Richard, I modified the topic a little to make it more clear.

You are right that I'm not working on Scanner, I created two patches 
related to Scanner just because some other modules needed a skeleton to 
compile. I'm a little distracted in NIO stuffs, further I owed some 
parts of j.u.Formatter(I'm frustrating on the facts that RI shows 
different behavior on java.text.DateFormat/NumberFormat and 
Formatter.format() for number/date, so it's more complex than I 
expected). So please feel free to complete the Scanner implementation, 
thank you. And please shout if you need help because it is a big stuff.

BTW, I have an issue related to Scanner here, I had a look at the 
Scanner's document before, and I found there is some possibilities to 
make its implementation easier: Scanner has a match() method, which 
returns a MatchResult for last scanning operation, further, the 
MatchResult contains the actual regular expressions Scanner used for 
various type(digit, decimal, etc) and can be got by 
Matcher.pattern().toString(), so I wonder if it is permitted in legal 
for us to use RI's regular express directly in Harmony's Scanner? If so, 
it is much easier to make Scanner compatible with RI. How do you(and 
others) think about it?

Richard Liang wrote:
> Hello Paulex,
>
> I'm implementing some SMALL methods for j.u.Scanner, and I find 
> there's a defect in its Constructor. It seems that you're focusing on 
> NIO development. Do you still working on j.u.Scanner? If no, I'd like 
> to provide patch for it. :-)
>
> Richard.
>
> [1] http://issues.apache.org/jira/browse/HARMONY-611
>
> Mikhail Loenko (JIRA) wrote:
>>      [ http://issues.apache.org/jira/browse/HARMONY-567?page=all ]
>>      Mikhail Loenko closed HARMONY-567:
>> ----------------------------------
>>
>>
>> verified by Paulex
>>
>>  
>>> [classlib][luni]java.util.Scanner constructors not implemented
>>> --------------------------------------------------------------
>>>
>>>          Key: HARMONY-567
>>>          URL: http://issues.apache.org/jira/browse/HARMONY-567
>>>      Project: Harmony
>>>         Type: Bug
>>>     
>>
>>  
>>>   Components: Classlib
>>>     Reporter: Paulex Yang
>>>     Assignee: Mikhail Loenko
>>>     Priority: Minor
>>>  Attachments: 01.harmony567.diff, 02.harmony567.sh, ScannerTest.java
>>>
>>> Because of its big size, I'll try to implement Scanner in several 
>>> steps, one JIRA/patch per step. Here goes the first one except the 
>>> skeleton, the implementation of constructors. I'll attach patch soon.
>>>     
>>
>>   
>


-- 
Paulex Yang
China Software Development Lab
IBM



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: [jira] Closed: (HARMONY-567) [classlib][luni]java.util.Scanner constructors not implemented

Posted by Richard Liang <ri...@gmail.com>.
Hello Paulex,

I'm implementing some SMALL methods for j.u.Scanner, and I find there's 
a defect in its Constructor. It seems that you're focusing on NIO 
development. Do you still working on j.u.Scanner? If no, I'd like to 
provide patch for it. :-)

Richard.

[1] http://issues.apache.org/jira/browse/HARMONY-611

Mikhail Loenko (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/HARMONY-567?page=all ]
>      
> Mikhail Loenko closed HARMONY-567:
> ----------------------------------
>
>
> verified by Paulex
>
>   
>> [classlib][luni]java.util.Scanner constructors not implemented
>> --------------------------------------------------------------
>>
>>          Key: HARMONY-567
>>          URL: http://issues.apache.org/jira/browse/HARMONY-567
>>      Project: Harmony
>>         Type: Bug
>>     
>
>   
>>   Components: Classlib
>>     Reporter: Paulex Yang
>>     Assignee: Mikhail Loenko
>>     Priority: Minor
>>  Attachments: 01.harmony567.diff, 02.harmony567.sh, ScannerTest.java
>>
>> Because of its big size, I'll try to implement Scanner in several steps, one JIRA/patch per step. Here goes the first one except the skeleton, the implementation of constructors. I'll attach patch soon.
>>     
>
>   

-- 
Richard Liang
China Software Development Lab, IBM 


[jira] Closed: (HARMONY-567) [classlib][luni]java.util.Scanner constructors not implemented

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-567?page=all ]
     
Mikhail Loenko closed HARMONY-567:
----------------------------------


verified by Paulex

> [classlib][luni]java.util.Scanner constructors not implemented
> --------------------------------------------------------------
>
>          Key: HARMONY-567
>          URL: http://issues.apache.org/jira/browse/HARMONY-567
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 01.harmony567.diff, 02.harmony567.sh, ScannerTest.java
>
> Because of its big size, I'll try to implement Scanner in several steps, one JIRA/patch per step. Here goes the first one except the skeleton, the implementation of constructors. I'll attach patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-567) [classlib][luni]java.util.Scanner constructors not implemented

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-567?page=all ]

Mikhail Loenko reassigned HARMONY-567:
--------------------------------------

    Assign To: Mikhail Loenko

> [classlib][luni]java.util.Scanner constructors not implemented
> --------------------------------------------------------------
>
>          Key: HARMONY-567
>          URL: http://issues.apache.org/jira/browse/HARMONY-567
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 01.harmony567.diff, 02.harmony567.sh, ScannerTest.java
>
> Because of its big size, I'll try to implement Scanner in several steps, one JIRA/patch per step. Here goes the first one except the skeleton, the implementation of constructors. I'll attach patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-567) [classlib][luni]java.util.Scanner constructors not implemented

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-567?page=comments#action_12415472 ] 

Paulex Yang commented on HARMONY-567:
-------------------------------------

Looks fine,thank you, Mikhail.

> [classlib][luni]java.util.Scanner constructors not implemented
> --------------------------------------------------------------
>
>          Key: HARMONY-567
>          URL: http://issues.apache.org/jira/browse/HARMONY-567
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 01.harmony567.diff, 02.harmony567.sh, ScannerTest.java
>
> Because of its big size, I'll try to implement Scanner in several steps, one JIRA/patch per step. Here goes the first one except the skeleton, the implementation of constructors. I'll attach patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-567) [classlib][luni]java.util.Scanner constructors not implemented

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-567?page=all ]
     
Mikhail Loenko resolved HARMONY-567:
------------------------------------

    Resolution: Fixed

applied in revision 412645
Paulex, please check it was done as expected

> [classlib][luni]java.util.Scanner constructors not implemented
> --------------------------------------------------------------
>
>          Key: HARMONY-567
>          URL: http://issues.apache.org/jira/browse/HARMONY-567
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 01.harmony567.diff, 02.harmony567.sh, ScannerTest.java
>
> Because of its big size, I'll try to implement Scanner in several steps, one JIRA/patch per step. Here goes the first one except the skeleton, the implementation of constructors. I'll attach patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira