[GitHub] [helix] pkuwm commented on pull request #1570: Send partitions list instead of string to custom client Rest API

[GitBox <gi...@apache.org>]

pkuwm commented on pull request #1570:
URL: https://github.com/apache/helix/pull/1570#issuecomment-736877957


   > Code looks good for me. Do we have tests to verify it?
   
   We don’t have a specific test to just test the type of partitions in the payload. It’d be a bit complicated to specifically test the part as it’ll need a http server running and some context to verify the payload the custom client receives. Mocking doesn’t work for testing this specific part.
   I’ve manually tested it by connecting it to SN. And print out the payloads. It is what we want: list of partitions, not a string. I think this change it fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org