You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aries.apache.org by cs...@apache.org on 2019/11/18 07:51:55 UTC
[aries] branch trunk updated: Remove the useless conditional
sub-expression.
This is an automated email from the ASF dual-hosted git repository.
cschneider pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/aries.git
The following commit(s) were added to refs/heads/trunk by this push:
new adba1eb Remove the useless conditional sub-expression.
adba1eb is described below
commit adba1eb62c755347c6f0edd4db5a65effa079e48
Author: Kui LIU <br...@gmail.com>
AuthorDate: Mon Oct 9 10:25:47 2017 +0200
Remove the useless conditional sub-expression.
This statement contains a useless conditional expression, where this conditional expression returns a false value regardless of what the value of isValid is.
http://findbugs.sourceforge.net/bugDescriptions.html#UCF_USELESS_CONTROL_FLOW
---
.../src/main/java/org/apache/aries/ant/taskdefs/BundleSelector.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/esa-ant-task/src/main/java/org/apache/aries/ant/taskdefs/BundleSelector.java b/esa-ant-task/src/main/java/org/apache/aries/ant/taskdefs/BundleSelector.java
index 31793f8..75bdbe3 100755
--- a/esa-ant-task/src/main/java/org/apache/aries/ant/taskdefs/BundleSelector.java
+++ b/esa-ant-task/src/main/java/org/apache/aries/ant/taskdefs/BundleSelector.java
@@ -60,7 +60,7 @@ public class BundleSelector implements FileSelector {
}
catch (Exception e) {
// nothing to do
- isValid = isValid && false;
+ isValid = false;
}
finally {
try {