You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/18 19:45:16 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #830: TODO:
Remove simulator SMP bug
patacongo opened a new pull request #830: TODO: Remove simulator SMP bug
URL: https://github.com/apache/incubator-nuttx/pull/830
My understanding is the Xiao Xiang has corrected this problem so it should no longer be carried as a bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #830: TODO: Remove
simulator SMP bug
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #830: TODO: Remove simulator SMP bug
URL: https://github.com/apache/incubator-nuttx/pull/830#issuecomment-615934429
@xiaoxiang781216 since it appears that you are actively using SMP on the simulator, this bug must have been fixed with some of your previous changes. In that case, the bug should be removed from the TODO list.
If I am mistaken, just close this PR without merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #830: TODO:
Remove simulator SMP bug
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #830: TODO: Remove simulator SMP bug
URL: https://github.com/apache/incubator-nuttx/pull/830
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #830: TODO:
Remove simulator SMP bug
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #830: TODO: Remove simulator SMP bug
URL: https://github.com/apache/incubator-nuttx/pull/830#issuecomment-615939347
> @xiaoxiang781216 since it appears that you are actively using SMP on the simulator, this bug must have been fixed with some of your previous changes. In that case, the bug should be removed from the TODO list.
>
> If I am mistaken, just close this PR without merging.
Yes, SMP issue is fixed by this patch:
commit a87271617a5e05c02d160803f43c4d644ebb45db
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Sun Feb 9 12:44:07 2020 +0800
arch/sim: Replace pthread mutex with atomic function for up_testset
up_testset may be called from signal hander but it isn't safe to call pthread API in that context
Both ostest and smp can run sucessfully now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services