You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/05 09:51:42 UTC
[GitHub] [incubator-pekko-http] pjfanning opened a new pull request, #4: remove mima checks
pjfanning opened a new pull request, #4:
URL: https://github.com/apache/incubator-pekko-http/pull/4
Relates to https://github.com/apache/incubator-pekko/issues/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on pull request #4: remove mima checks
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #4:
URL: https://github.com/apache/incubator-pekko-http/pull/4#issuecomment-1305694636
thanks everyone - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #4: remove mima checks
Posted by GitBox <gi...@apache.org>.
jrudolph commented on code in PR #4:
URL: https://github.com/apache/incubator-pekko-http/pull/4#discussion_r1015251126
##########
.github/workflows/nightly.yml:
##########
@@ -44,8 +44,9 @@ jobs:
- name: Compile everything
run: sbt -Dakka.http.build.akka.version=${{ matrix.AKKA_VERSION }} ++${{ matrix.SCALA_VERSION }} Test/compile
+ # mima checks have been temporarily removed
- name: Run all tests JDK ${{ matrix.JABBA_JDK }}, Scala ${{ matrix.SCALA_VERSION }}, Akka ${{ matrix.AKKA_VERSION }}
- run: sbt -Dakka.http.parallelExecution=false -Dakka.test.timefactor=2 -Dakka.http.build.akka.version=${{ matrix.AKKA_VERSION }} ++${{ matrix.SCALA_VERSION }} mimaReportBinaryIssues test
+ run: sbt -Dakka.http.parallelExecution=false -Dakka.test.timefactor=2 -Dakka.http.build.akka.version=${{ matrix.AKKA_VERSION }} ++${{ matrix.SCALA_VERSION }} test
Review Comment:
We might be able to keep them here (and below) now as well, since they should be a no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #4: remove mima checks
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #4:
URL: https://github.com/apache/incubator-pekko-http/pull/4#discussion_r1015268779
##########
project/ValidatePullRequest.scala:
##########
@@ -360,9 +359,12 @@ object AggregatePRValidation extends AutoPlugin {
case KeyValue(key, i: Inc) => KeyValue(key, i)
}
+ /*
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #4: remove mima checks
Posted by GitBox <gi...@apache.org>.
jrudolph commented on code in PR #4:
URL: https://github.com/apache/incubator-pekko-http/pull/4#discussion_r1015195811
##########
project/ValidatePullRequest.scala:
##########
@@ -360,9 +359,12 @@ object AggregatePRValidation extends AutoPlugin {
case KeyValue(key, i: Inc) => KeyValue(key, i)
}
+ /*
Review Comment:
I.e. make `mimaPreviousArtifacts` empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #4: remove mima checks
Posted by GitBox <gi...@apache.org>.
jrudolph commented on code in PR #4:
URL: https://github.com/apache/incubator-pekko-http/pull/4#discussion_r1015195236
##########
project/ValidatePullRequest.scala:
##########
@@ -360,9 +359,12 @@ object AggregatePRValidation extends AutoPlugin {
case KeyValue(key, i: Inc) => KeyValue(key, i)
}
+ /*
Review Comment:
Maybe we can keep this file as is and just remove the versions to check against in `project/Mima.scala`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #4: remove mima checks
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #4:
URL: https://github.com/apache/incubator-pekko-http/pull/4#discussion_r1015293008
##########
.github/workflows/nightly.yml:
##########
@@ -44,8 +44,9 @@ jobs:
- name: Compile everything
run: sbt -Dakka.http.build.akka.version=${{ matrix.AKKA_VERSION }} ++${{ matrix.SCALA_VERSION }} Test/compile
+ # mima checks have been temporarily removed
- name: Run all tests JDK ${{ matrix.JABBA_JDK }}, Scala ${{ matrix.SCALA_VERSION }}, Akka ${{ matrix.AKKA_VERSION }}
- run: sbt -Dakka.http.parallelExecution=false -Dakka.test.timefactor=2 -Dakka.http.build.akka.version=${{ matrix.AKKA_VERSION }} ++${{ matrix.SCALA_VERSION }} mimaReportBinaryIssues test
+ run: sbt -Dakka.http.parallelExecution=false -Dakka.test.timefactor=2 -Dakka.http.build.akka.version=${{ matrix.AKKA_VERSION }} ++${{ matrix.SCALA_VERSION }} test
Review Comment:
I reverted the workflow changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning merged pull request #4: remove mima checks
Posted by GitBox <gi...@apache.org>.
pjfanning merged PR #4:
URL: https://github.com/apache/incubator-pekko-http/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org