You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2018/03/08 20:19:11 UTC

[GitHub] activemq-artemis pull request #1942: ARTEMIS-1682 Set packaging jar for arte...

GitHub user mtaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1942

    ARTEMIS-1682 Set packaging jar for artemis-server

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1682

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1942.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1942
    
----
commit fde86c0c3ad1390feba92fcf151558abfacc4a48
Author: Martyn Taylor <mt...@...>
Date:   2018-03-08T20:07:41Z

    ARTEMIS-1682 Set packaging jar for artemis-server

----


---

[GitHub] activemq-artemis issue #1942: ARTEMIS-1682 Set packaging jar for artemis-ser...

Posted by mtaylor <gi...@git.apache.org>.

Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1942
  
    @jbertram There's actually a seperate "artemis-server-osgi" module that should be used for osgi related stuff.  We shouldn't be including classes from other modules in our jars.


---

[GitHub] activemq-artemis issue #1942: ARTEMIS-1682 Set packaging jar for artemis-ser...

Posted by jbertram <gi...@git.apache.org>.

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1942
  
    I'm guessing that this will break the stuff committed for https://issues.apache.org/jira/browse/ARTEMIS-1630, but at this point I can't even get the tests in that commit to run successfully so it might already be broken anyway.


---

[GitHub] activemq-artemis issue #1942: ARTEMIS-1682 Set packaging jar for artemis-ser...

Posted by jbertram <gi...@git.apache.org>.

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1942
  
    Agreed.  I just wanted to make a note for posterity's sake before I merged it.  :)


---

[GitHub] activemq-artemis pull request #1942: ARTEMIS-1682 Set packaging jar for arte...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1942


---