You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org> on 2019/11/01 05:51:44 UTC
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14610
Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC.
......................................................................
IMPALA-9116: Work around SASL bug when FQDN is >=64 characters
in Kudu RPC.
This adds a workaround for an upstream SASL bug which is triggered when
the FQDN has more than 64 characters. In this case, SASL would truncate
the FQDN and not be able to find the relevant keytab.
After this change, we do not rely on SASL getting the FQDN but use our
own implementation to get FQDN.
Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
---
M be/src/kudu/rpc/server_negotiation.cc
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/14610/1
--
To view, visit http://gerrit.cloudera.org:8080/14610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
Gerrit-Change-Number: 14610
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14610 )
Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC.
......................................................................
IMPALA-9116: Work around SASL bug when FQDN is >=64 characters
in Kudu RPC.
This adds a workaround for an upstream SASL bug which is triggered when
the FQDN has more than 64 characters. In this case, SASL would truncate
the FQDN and not be able to find the relevant keytab.
After this change, we do not rely on SASL getting the FQDN but use our
own implementation to get FQDN.
Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
---
M be/src/kudu/rpc/server_negotiation.cc
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/14610/2
--
To view, visit http://gerrit.cloudera.org:8080/14610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
Gerrit-Change-Number: 14610
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 )
Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC.
......................................................................
Patch Set 2:
Abandoning this change, cherry-picked KUDU's change here:
https://gerrit.cloudera.org/#/c/14614/
--
To view, visit http://gerrit.cloudera.org:8080/14610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
Gerrit-Change-Number: 14610
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 17:02:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 )
Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC.
......................................................................
Patch Set 1:
(1 comment)
LGTM. Is the plan to do it on Impala side first and then backport it to Kudu ? We usually do changes the other way (i.e. from Kudu side first and then cherry-picked to Impala side).
http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc
File be/src/kudu/rpc/server_negotiation.cc:
http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc@391
PS1, Line 391: (!server_fqdn
nit: server_fqdn == nullptr
--
To view, visit http://gerrit.cloudera.org:8080/14610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
Gerrit-Change-Number: 14610
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 06:07:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 )
Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4927/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
Gerrit-Change-Number: 14610
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 06:35:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 )
Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC.
......................................................................
Patch Set 2:
We usually cherry-pick the Kudu patch so it's easier to track the original change (including the gerrit link to the original Kudu change). I am okay with exception if this is super urgent.
--
To view, visit http://gerrit.cloudera.org:8080/14610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
Gerrit-Change-Number: 14610
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 06:28:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 )
Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC.
......................................................................
Patch Set 2:
(1 comment)
Kudu made the same change here: https://gerrit.cloudera.org/#/c/14609/.
Since it was a small change, I cross-ported it. Shall I wait for the kudu change to get merged?
http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc
File be/src/kudu/rpc/server_negotiation.cc:
http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc@391
PS1, Line 391: (server_fqdn
> nit: server_fqdn == nullptr
Done
--
To view, visit http://gerrit.cloudera.org:8080/14610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
Gerrit-Change-Number: 14610
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 06:13:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has abandoned this change. ( http://gerrit.cloudera.org:8080/14610 )
Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC.
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/14610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
Gerrit-Change-Number: 14610
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 )
Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC.
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4928/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6
Gerrit-Change-Number: 14610
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 06:57:07 +0000
Gerrit-HasComments: No