You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/01/25 18:29:04 UTC

[GitHub] sterlinghughes commented on issue #762: upgrade STM32 Cube for the F4, and re-org to make future upgrades eas?

sterlinghughes commented on issue #762: upgrade STM32 Cube for the F4, and re-org to make future upgrades eas?
URL: https://github.com/apache/mynewt-core/pull/762#issuecomment-360556487
 
 
   Hi @utzig  -- I updated the commits to change the files so they build.  
   
   @utzig @mkiiskila -- take a look, paying specific attention to my changes removing the HAL_I2C_MODE_MASTER_SEL.  I did not want to change the vanilla I2C modes, and thought it was fine to check if the bus was busy every time, even if a STOP had not been generated -- although I have not tested this much.  
   
   I instead set the mode to HAL_I2C_MODE_MASTER, so that functions like abort will still work on the bus if a STOP has not been sent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services