You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/07/11 08:47:29 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3048: "One trace segment has been abandoned, cause by buffer is full" bug fix.

wu-sheng commented on a change in pull request #3048: "One trace segment has been abandoned, cause by buffer is full" bug fix.
URL: https://github.com/apache/skywalking/pull/3048#discussion_r302429728
 
 

 ##########
 File path: oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java
 ##########
 @@ -210,7 +210,8 @@ public void afterBulk(long executionId, BulkRequest request, Throwable failure)
         return BulkProcessor.builder(client::bulkAsync, listener)
             .setBulkActions(bulkActions)
             .setBulkSize(new ByteSizeValue(bulkSize, ByteSizeUnit.MB))
-            .setFlushInterval(TimeValue.timeValueSeconds(flushInterval))
+            // modified by zhaoze, if set auto flush, there will cause deadlock with bulk commit.
 
 Review comment:
   You can't set this comment in the repo, remove it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services