You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/06 01:16:00 UTC

[jira] [Commented] (MINIFICPP-531) Adjust licensing for libuvc

    [ https://issues.apache.org/jira/browse/MINIFICPP-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502718#comment-16502718 ] 

ASF GitHub Bot commented on MINIFICPP-531:
------------------------------------------

GitHub user apiri opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/353

    MINIFICPP-531 Adding LICENSE entry for utlist bundled as part of libuvc.

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [X] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apiri/nifi-minifi-cpp MINIFICPP-531

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #353
    
----
commit 65232c7c1eb3f2c5010e38b399803a7351a1bfc5
Author: Aldrin Piri <al...@...>
Date:   2018-06-06T01:14:14Z

    MINIFICPP-531 Adding LICENSE entry for utlist bundled as part of libuvc.

----


> Adjust licensing for libuvc
> ---------------------------
>
>                 Key: MINIFICPP-531
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-531
>             Project: NiFi MiNiFi C++
>          Issue Type: Task
>            Reporter: Aldrin Piri
>            Assignee: Aldrin Piri
>            Priority: Major
>
> It looks like libuvc also bundles uthash.  We should capture this information in our LICENSE file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)