You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "vamsikarnika (via GitHub)" <gi...@apache.org> on 2025/08/28 14:22:44 UTC
[PR] Improve log file pattern match operation [hudi]
vamsikarnika opened a new pull request, #13799:
URL: https://github.com/apache/hudi/pull/13799
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve log file pattern match operation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13799:
URL: https://github.com/apache/hudi/pull/13799#issuecomment-3233722456
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9899db5d97281a38d949783d37bb822323a777b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9899db5d97281a38d949783d37bb822323a777b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9899db5d97281a38d949783d37bb822323a777b4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve log file pattern match operation [hudi]
Posted by "vamsikarnika (via GitHub)" <gi...@apache.org>.
vamsikarnika commented on code in PR #13799:
URL: https://github.com/apache/hudi/pull/13799#discussion_r2310644070
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -79,7 +79,7 @@ public class FSUtils {
// Archive log files are of this pattern - .commits_.archive.1_1-0-1
public static final String PATH_SEPARATOR = "/";
public static final Pattern LOG_FILE_PATTERN =
- Pattern.compile("^\\.(.+)_(.*)\\.(log|archive)\\.(\\d+)(_((\\d+)-(\\d+)-(\\d+))(.cdc)?)?");
+ Pattern.compile("^\\.(.+)_(.*)\\.(log|archive)\\.(\\d+)(_((\\d+)-(\\d+)-(\\d+))(.cdc)?)?$");
Review Comment:
Tracking this change in this pr: https://github.com/apache/hudi/pull/13803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve log file pattern match operation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13799:
URL: https://github.com/apache/hudi/pull/13799#issuecomment-3233732291
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9899db5d97281a38d949783d37bb822323a777b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8215",
"triggerID" : "9899db5d97281a38d949783d37bb822323a777b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9899db5d97281a38d949783d37bb822323a777b4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8215)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve log file pattern match operation [hudi]
Posted by "vamsikarnika (via GitHub)" <gi...@apache.org>.
vamsikarnika closed pull request #13799: Improve log file pattern match operation
URL: https://github.com/apache/hudi/pull/13799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve log file pattern match operation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13799:
URL: https://github.com/apache/hudi/pull/13799#issuecomment-3233783732
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9899db5d97281a38d949783d37bb822323a777b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8215",
"triggerID" : "9899db5d97281a38d949783d37bb822323a777b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9899db5d97281a38d949783d37bb822323a777b4 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8215)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve log file pattern match operation [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13799:
URL: https://github.com/apache/hudi/pull/13799#discussion_r2309004072
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -79,7 +79,7 @@ public class FSUtils {
// Archive log files are of this pattern - .commits_.archive.1_1-0-1
public static final String PATH_SEPARATOR = "/";
public static final Pattern LOG_FILE_PATTERN =
- Pattern.compile("^\\.(.+)_(.*)\\.(log|archive)\\.(\\d+)(_((\\d+)-(\\d+)-(\\d+))(.cdc)?)?");
+ Pattern.compile("^\\.(.+)_(.*)\\.(log|archive)\\.(\\d+)(_((\\d+)-(\\d+)-(\\d+))(.cdc)?)?$");
Review Comment:
it's great to see a micro-benchmark test in this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org