You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Robert Burke (Jira)" <ji...@apache.org> on 2022/01/25 16:55:00 UTC

[jira] [Updated] (BEAM-13736) [Go SDK] Fix hash collision risk in Combiner Lifting cache

     [ https://issues.apache.org/jira/browse/BEAM-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Burke updated BEAM-13736:
--------------------------------
    Status: Open  (was: Triage Needed)

> [Go SDK] Fix hash collision risk in Combiner Lifting cache
> ----------------------------------------------------------
>
>                 Key: BEAM-13736
>                 URL: https://issues.apache.org/jira/browse/BEAM-13736
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Robert Burke
>            Priority: P2
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Relying only on a hash is brittle for map implementations, and can lead to correctness issues when keys collide.
> While the Go SDK implementation is leaning on the Go map, we need to rely on byte equality so we need to fend for ourselves a bit, and handle overflow buckets and the like.
> We won't go so far as to do a rehash or similar balancing techniques as it's not clear that between the caches' size constraint, and the evenness of the hash function that they are all that likely.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)