You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/08 14:00:24 UTC
[GitHub] [incubator-doris] xlwh opened a new pull request, #9456: [Refactor] Replace '#ifndef' with '#pragma once'
xlwh opened a new pull request, #9456:
URL: https://github.com/apache/incubator-doris/pull/9456
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No Need
3. Has document been added or modified: No Need
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9456: [Refactor] Replace '#ifndef' with '#pragma once'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9456:
URL: https://github.com/apache/incubator-doris/pull/9456#issuecomment-1121141638
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9456: [Refactor] Replace '#ifndef' with '#pragma once'
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9456:
URL: https://github.com/apache/incubator-doris/pull/9456#issuecomment-1121087725
> > Is there any way to automatically detect header guard style?
>
> Sorry, I don't have a good way to automatically check. Do you have any good suggest? thanks!
I didn't either, just curious to ask
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] lverson3 commented on pull request #9456: [Refactor] Replace '#ifndef' with '#pragma once'
Posted by GitBox <gi...@apache.org>.
lverson3 commented on PR #9456:
URL: https://github.com/apache/incubator-doris/pull/9456#issuecomment-1140731351
In file included from /home/htcc/gopr/doris/incubator-doris/be/src/vec/columns/columns_common.cpp:25:
/home/htcc/gopr/doris/incubator-doris/be/src/util/simd/bits.h: In function 'uint32_t doris::simd::bytes32_mask_to_bits32_mask(const uint8_t*)':
/home/htcc/gopr/doris/incubator-doris/be/src/util/simd/bits.h:49:10: error: 'size_t' was not declared in this scope; did you mean 'std::size_t'?
49 | for (size_t i = 0; i < 32; ++i)
编译报错是什么原因导致的呢?辛苦帮忙看下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9456: [Refactor] Replace '#ifndef' with '#pragma once'
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9456:
URL: https://github.com/apache/incubator-doris/pull/9456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9456: [Refactor] Replace '#ifndef' with '#pragma once'
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9456:
URL: https://github.com/apache/incubator-doris/pull/9456#issuecomment-1120661122
Is there any way to automatically detect header guard style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xlwh commented on pull request #9456: [Refactor] Replace '#ifndef' with '#pragma once'
Posted by GitBox <gi...@apache.org>.
xlwh commented on PR #9456:
URL: https://github.com/apache/incubator-doris/pull/9456#issuecomment-1120696408
> Is there any way to automatically detect header guard style?
Sorry, I don't have a good way to automatically check. Do you have any good suggest? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org