You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/28 03:29:06 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #13685: [FLINK-19702][hive] Avoid using HiveConf::hiveSiteURL
JingsongLi commented on a change in pull request #13685:
URL: https://github.com/apache/flink/pull/13685#discussion_r513158356
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -214,7 +202,19 @@ private static HiveConf createHiveConf(@Nullable String hiveConfDir, @Nullable S
} else {
hadoopConf = getHadoopConfiguration(hadoopConfDir);
}
- return new HiveConf(hadoopConf == null ? new Configuration() : hadoopConf, HiveConf.class);
+ HiveConf hiveConf = new HiveConf(hadoopConf == null ? new Configuration() : hadoopConf, HiveConf.class);
+
+ LOG.info("Setting hive conf dir as {}", hiveConfDir);
+
+ if (hiveConfDir != null) {
+ Path hiveSite = new Path(hiveConfDir, "hive-site.xml");
Review comment:
Maybe you should use `new File(..).toURI()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org