[GitHub] [accumulo] dlmarion commented on a change in pull request #1818: Fixes #1808 - Stop server side VM on Error in Thread

[GitBox <gi...@apache.org>]

dlmarion commented on a change in pull request #1818:
URL: https://github.com/apache/accumulo/pull/1818#discussion_r533742044



##########
File path: assemble/conf/accumulo-env.sh
##########
@@ -95,7 +95,7 @@ JAVA_OPTS=("${JAVA_OPTS[@]}"
 
 case "$cmd" in
   monitor|gc|master|tserver|tracer)
-    JAVA_OPTS=("${JAVA_OPTS[@]}" "-Dlog4j.configurationFile=log4j2-service.properties")
+    JAVA_OPTS=("${JAVA_OPTS[@]}" "-Dlog4j.configurationFile=log4j2-service.properties" "-DHaltVMOnThreadError=true")

Review comment:
       > know that it wouldn't necessarily make sense to re-throw from the handler... because the docs say stuff thrown from the handler are ignored... but not sure if that applies to Error types as well as Exceptions.
   
   I'm pretty sure I have seen a StackOverflowError from a Thread that kills the Thread but not the VM. My guess is that an Error re-thrown from the handler on a Thread would do nothing, unless its the OutOfMemoryError and the OnOutOfMemoryError parameter is set.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org