You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/06/01 22:14:00 UTC
[jira] [Commented] (YARN-8372) Distributed shell app master should
not release containers when shutdown if keep-container is true
[ https://issues.apache.org/jira/browse/YARN-8372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498638#comment-16498638 ]
Hudson commented on YARN-8372:
------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14338 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14338/])
YARN-8372. Distributed shell app master should not release containers (wangda: rev 8956e5b8db3059e0872e49f59adc6affc76e2274)
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
> Distributed shell app master should not release containers when shutdown if keep-container is true
> --------------------------------------------------------------------------------------------------
>
> Key: YARN-8372
> URL: https://issues.apache.org/jira/browse/YARN-8372
> Project: Hadoop YARN
> Issue Type: Bug
> Components: distributed-shell
> Reporter: Charan Hebri
> Assignee: Suma Shivaprasad
> Priority: Major
> Attachments: YARN-8372.1.patch, YARN-8372.2.patch, YARN-8372.3.patch
>
>
> {noformat}
> try {
> response = client.allocate(progress);
> } catch (ApplicationAttemptNotFoundException e) {
> handler.onShutdownRequest();
> LOG.info("Shutdown requested. Stopping callback.");
> return;{noformat}
> is a code snippet from AMRMClientAsyncImpl. The corresponding onShutdownRequest call for the Distributed Shell App master,
> {noformat}
> @Override
> public void onShutdownRequest() {
> done = true;
> }{noformat}
> Due to the above change, the current behavior is that whenever an application attempt fails due to a NM restart (NM where the DS AM is running), an ApplicationAttemptNotFoundException is thrown and all containers for that attempt including the ones that are running on other NMs are killed by the AM and marked as COMPLETE. The subsequent attempt spawns new containers just like a new attempt. This behavior is different to a Map Reduce application where the containers are not killed.
> cc [~rohithsharma]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org