[GitHub] [maven-release] michael-o commented on a diff in pull request #104: [MRELEASE-1078] Conventional commits

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #104:
URL: https://github.com/apache/maven-release/pull/104#discussion_r926864996


##########
maven-release-manager/src/main/mdo/release-descriptor.mdo:
##########
@@ -491,10 +491,10 @@
         <field>
           <name>projectVersionPolicyConfig</name>
           <version>3.0.0+</version>
-          <type>String</type>
+          <type>DOM</type>

Review Comment:
   DOM is exactly what you need. Just like here: https://github.com/apache/maven/blob/8125b3131f2e0f88837040b0baf4e0aaa8210679/maven-settings/src/main/mdo/settings.mdo#L574-L582 
   
    I assumed that I have provided this pointer to you.



##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/config/PropertiesReleaseDescriptorStore.java:
##########
@@ -271,7 +271,7 @@ public void write( BuilderReleaseDescriptor config, File file )
         }
         if ( config.getProjectVersionPolicyConfig() != null )
         {
-            properties.setProperty( "projectVersionPolicyConfig", config.getProjectVersionPolicyConfig() );
+            properties.setProperty( "projectVersionPolicyConfig", config.getProjectVersionPolicyConfig().toString() );

Review Comment:
   Why `toString()`? I don't understand this reasoning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org