You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "Olga Tkachova (JIRA)" <ji...@apache.org> on 2009/10/26 09:31:59 UTC

[jira] Created: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Finish modeler support for embeddables and embedded attributes
--------------------------------------------------------------

                 Key: CAY-1295
                 URL: https://issues.apache.org/jira/browse/CAY-1295
             Project: Cayenne
          Issue Type: Task
          Components: CayenneModeler GUI
            Reporter: Olga Tkachova


- add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Posted by "Olga Tkachova (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Tkachova updated CAY-1295:
-------------------------------

    Attachment: 0001-CAY-1295-2.patch

- added validation case if new ClassName in Embedddable duplicated in other DataMaps
- added validation ClassName (in Embeddables) in Validate Project

> Finish modeler support for embeddables and embedded attributes
> --------------------------------------------------------------
>
>                 Key: CAY-1295
>                 URL: https://issues.apache.org/jira/browse/CAY-1295
>             Project: Cayenne
>          Issue Type: Task
>          Components: CayenneModeler GUI
>            Reporter: Olga Tkachova
>            Assignee: Andrus Adamchik
>             Fix For: 3.0
>
>         Attachments: 0001-CAY-1295-1.patch, 0001-CAY-1295-2.patch, 0001-CAY-1295.patch, 0001-CAY-1295.patch
>
>
> - add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAY-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770442#action_12770442 ] 

Andrus Adamchik commented on CAY-1295:
--------------------------------------

I committed both patches. Works much better now. Found one remaining problem:

* When I rename an Embeddable, all referenced embedded attributes are not renamed. Also attribute type dropdowns are not refreshed.

> Finish modeler support for embeddables and embedded attributes
> --------------------------------------------------------------
>
>                 Key: CAY-1295
>                 URL: https://issues.apache.org/jira/browse/CAY-1295
>             Project: Cayenne
>          Issue Type: Task
>          Components: CayenneModeler GUI
>            Reporter: Olga Tkachova
>            Assignee: Andrus Adamchik
>             Fix For: 3.0
>
>         Attachments: 0001-CAY-1295.patch, 0001-CAY-1295.patch
>
>
> - add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrus Adamchik reassigned CAY-1295:
------------------------------------

    Assignee: Andrus Adamchik

> Finish modeler support for embeddables and embedded attributes
> --------------------------------------------------------------
>
>                 Key: CAY-1295
>                 URL: https://issues.apache.org/jira/browse/CAY-1295
>             Project: Cayenne
>          Issue Type: Task
>          Components: CayenneModeler GUI
>            Reporter: Olga Tkachova
>            Assignee: Andrus Adamchik
>             Fix For: 3.0
>
>         Attachments: 0001-CAY-1295.patch, 0001-CAY-1295.patch
>
>
> - add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Posted by "Olga Tkachova (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Tkachova updated CAY-1295:
-------------------------------

    Attachment: 0001-CAY-1295-1.patch

- fix: When I rename an Embeddable, all referenced embedded attributes are not renamed. Also attribute type dropdowns are not refreshed.
- now in DataDomain don't show embeddables with another DataDomain

> Finish modeler support for embeddables and embedded attributes
> --------------------------------------------------------------
>
>                 Key: CAY-1295
>                 URL: https://issues.apache.org/jira/browse/CAY-1295
>             Project: Cayenne
>          Issue Type: Task
>          Components: CayenneModeler GUI
>            Reporter: Olga Tkachova
>            Assignee: Andrus Adamchik
>             Fix For: 3.0
>
>         Attachments: 0001-CAY-1295-1.patch, 0001-CAY-1295.patch, 0001-CAY-1295.patch
>
>
> - add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Posted by "Olga Tkachova (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Tkachova updated CAY-1295:
-------------------------------

    Attachment: 0001-CAY-1295.patch

fix: the Dialog don't shown if changed package in DataMap and model contains only Embeddables (doesn't contain ObjEntity)  then push button "update".

> Finish modeler support for embeddables and embedded attributes
> --------------------------------------------------------------
>
>                 Key: CAY-1295
>                 URL: https://issues.apache.org/jira/browse/CAY-1295
>             Project: Cayenne
>          Issue Type: Task
>          Components: CayenneModeler GUI
>            Reporter: Olga Tkachova
>         Attachments: 0001-CAY-1295.patch, 0001-CAY-1295.patch
>
>
> - add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Posted by "Olga Tkachova (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Tkachova updated CAY-1295:
-------------------------------

    Attachment: 0001-CAY-1295(3).patch

> Finish modeler support for embeddables and embedded attributes
> --------------------------------------------------------------
>
>                 Key: CAY-1295
>                 URL: https://issues.apache.org/jira/browse/CAY-1295
>             Project: Cayenne
>          Issue Type: Task
>          Components: CayenneModeler GUI
>            Reporter: Olga Tkachova
>            Assignee: Andrus Adamchik
>             Fix For: 3.0
>
>         Attachments: 0001-CAY-1295(3).patch, 0001-CAY-1295-1.patch, 0001-CAY-1295-2.patch, 0001-CAY-1295.patch, 0001-CAY-1295.patch
>
>
> - add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Posted by "Olga Tkachova (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Tkachova updated CAY-1295:
-------------------------------

    Attachment: 0001-CAY-1295.patch

> Finish modeler support for embeddables and embedded attributes
> --------------------------------------------------------------
>
>                 Key: CAY-1295
>                 URL: https://issues.apache.org/jira/browse/CAY-1295
>             Project: Cayenne
>          Issue Type: Task
>          Components: CayenneModeler GUI
>            Reporter: Olga Tkachova
>         Attachments: 0001-CAY-1295.patch
>
>
> - add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAY-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771970#action_12771970 ] 

Andrus Adamchik commented on CAY-1295:
--------------------------------------

I committed 2 more patches. Getting much better now. A few remaining issues:

1. After I renamed an embeddable which was referenced by an entity, on save I am getting a warning about invalid embeddable in the embedded attribute (not sure if rename is related to that though, maybe not?)

2. When I click on invalid embedded attribute in the warning dialog, and then close the warning dialog , the "I" button for that attribute is disabled even though the attribute is selected. I have to reselect it to be able to edit.

3. When editing embedded attribute , I don't see what the embeddable columns are mapped to if their mappings do not correspond to columns in the  DbEntity

4. We need a few more validations:

    * An embeddable with no attributes
    * An embeddable with column names missing from DbEntity, and no valid overrides provided

> Finish modeler support for embeddables and embedded attributes
> --------------------------------------------------------------
>
>                 Key: CAY-1295
>                 URL: https://issues.apache.org/jira/browse/CAY-1295
>             Project: Cayenne
>          Issue Type: Task
>          Components: CayenneModeler GUI
>            Reporter: Olga Tkachova
>            Assignee: Andrus Adamchik
>             Fix For: 3.0
>
>         Attachments: 0001-CAY-1295-1.patch, 0001-CAY-1295-2.patch, 0001-CAY-1295.patch, 0001-CAY-1295.patch
>
>
> - add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrus Adamchik closed CAY-1295.
--------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 3.0)
                   3.0 beta 1

This was actually fixed in B1

> Finish modeler support for embeddables and embedded attributes
> --------------------------------------------------------------
>
>                 Key: CAY-1295
>                 URL: https://issues.apache.org/jira/browse/CAY-1295
>             Project: Cayenne
>          Issue Type: Task
>          Components: CayenneModeler GUI
>            Reporter: Olga Tkacheva
>            Assignee: Andrus Adamchik
>             Fix For: 3.0 beta 1
>
>         Attachments: 0001-CAY-1295(3).patch, 0001-CAY-1295-1.patch, 0001-CAY-1295-2.patch, 0001-CAY-1295.patch, 0001-CAY-1295.patch
>
>
> - add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAY-1295) Finish modeler support for embeddables and embedded attributes

Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrus Adamchik updated CAY-1295:
---------------------------------

    Fix Version/s: 3.0

> Finish modeler support for embeddables and embedded attributes
> --------------------------------------------------------------
>
>                 Key: CAY-1295
>                 URL: https://issues.apache.org/jira/browse/CAY-1295
>             Project: Cayenne
>          Issue Type: Task
>          Components: CayenneModeler GUI
>            Reporter: Olga Tkachova
>             Fix For: 3.0
>
>         Attachments: 0001-CAY-1295.patch, 0001-CAY-1295.patch
>
>
> - add embeddable types in table in ObjEntityAttributeTab and support it 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.