You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/11/21 01:35:28 UTC

[GitHub] [samza] sborya opened a new pull request #1447: corrected/added some release instructions

sborya opened a new pull request #1447:
URL: https://github.com/apache/samza/pull/1447


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [samza] mynameborat commented on a change in pull request #1447: corrected/added some release instructions

Posted by GitBox <gi...@apache.org>.
mynameborat commented on a change in pull request #1447:
URL: https://github.com/apache/samza/pull/1447#discussion_r528918635



##########
File path: KEYS
##########
@@ -6,18 +6,28 @@ Developers:
   Create a key:
     gpg --gen-key
 
+  Private keys is stored in ~/.gnupg
+
   Adding your key to this file:
     (gpg --list-sigs <key id> && gpg --armor --export <key id>) >> this file.
 
   Publish the key:
     gpg --keyserver pgp.mit.edu --send-keys <key id>

Review comment:
       I suppose this got updated to `pgpkeys.mit.edu`. 

##########
File path: KEYS
##########
@@ -6,18 +6,28 @@ Developers:
   Create a key:
     gpg --gen-key
 
+  Private keys is stored in ~/.gnupg
+
   Adding your key to this file:
     (gpg --list-sigs <key id> && gpg --armor --export <key id>) >> this file.
 
   Publish the key:
     gpg --keyserver pgp.mit.edu --send-keys <key id>
+    gpg --keyserver keyserver.ubuntu.com --send-keys <key id>
 
   Signing another developers key:
     gpg --keyserver pgp.mit.edu --search-keys <name or email>
     gpg --keyserver pgp.mit.edu --recv-keys <key id>
     gpg --sign-key <key id>
     gpg --keyserver pgp.mit.edu --send-keys <key id>
 
+  Siggning release with the key *may* require the following some of these steps:

Review comment:
       nit: s/siggning/signing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [samza] sborya merged pull request #1447: [Docs] corrected/added some release instructions

Posted by GitBox <gi...@apache.org>.
sborya merged pull request #1447:
URL: https://github.com/apache/samza/pull/1447


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org