[jira] [Commented] (SLING-11715) ResourceResolver.map resolves same resource twice

["Joerg Hoh (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772205#comment-17772205 ] 

Joerg Hoh commented on SLING-11715:
-----------------------------------

PR merged.

 

It turned out that in the code path of the optimized alias resolution no repository access is required anymore; but it is still done because much code was actually shared with the non-optimized case, which still requires repository access.
So it's just a large refactoring to split the execution paths of both cases.

With the changed code just 1 {{ResourceResolver.resolveInternal()}} call is done for mapping a path, while without it for each path segment such a call was done. That means that the biggest improvement can be seen when the ResourceResolver.map() is invoked on a deep path.

> ResourceResolver.map resolves same resource twice
> -------------------------------------------------
>
>                 Key: SLING-11715
>                 URL: https://issues.apache.org/jira/browse/SLING-11715
>             Project: Sling
>          Issue Type: Improvement
>          Components: ResourceResolver
>    Affects Versions: Resource Resolver 1.10.0
>            Reporter: Joerg Hoh
>            Assignee: Joerg Hoh
>            Priority: Major
>
> While investigation repository access I found that a {{ResourceResolver.map()}} call invokes {{ResourceResolver.resolveInternal()}} twice for the same resource. 
> See these parts of the call stack:
> {noformat}
>         at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.getAbsoluteResourceInternal(ResourceResolverImpl.java:901) [org.apache.sling.resourceresolver:1.10.0]
>         at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolveInternal(ResourceResolverImpl.java:727) [org.apache.sling.resourceresolver:1.10.0]
>         at org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:145) [org.apache.sling.resourceresolver:1.10.0]
>         at org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73) [org.apache.sling.resourceresolver:1.10.0]
>         at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:445) [org.apache.sling.resourceresolver:1.10.0]
> {noformat}
> {noformat}
>         at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolveInternal(ResourceResolverImpl.java:384) [org.apache.sling.resourceresolver:1.10.0]
>         at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolve(ResourceResolverImpl.java:256) [org.apache.sling.resourceresolver:1.10.0]
>         at org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.loadAliasesIfApplicable(ResourceMapperImpl.java:220) [org.apache.sling.resourceresolver:1.10.0]
>         at org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:147) [org.apache.sling.resourceresolver:1.10.0]
>         at org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73) [org.apache.sling.resourceresolver:1.10.0]
>         at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:445) [org.apache.sling.resourceresolver:1.10.0]
> {noformat}
> In [ResourceResolverMapperImpl.loadAliasesIfApplicable()|https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/ac8b0ad5a75a26a00ef88c7d322b8be2b5495dfb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L189] a resolved resource is passed, and when no alias is encountered the same resource will be resolved again in [line 220|https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/ac8b0ad5a75a26a00ef88c7d322b8be2b5495dfb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L220].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)