You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/29 16:54:56 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #10964:
[FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session
cluster
tillrohrmann opened a new pull request #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964
## What is the purpose of the change
The recommended way to shut down a detached Yarn session cluster is to reattach via
the yarn-session.sh script and to issue a stop command. This will ensure that all
job artifacts and temporary files are properly cleaned up.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10964: [FLINK-15806][yarn] Log
recommended way how to stop a detached Yarn session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964#issuecomment-579861664
<!--
Meta data
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
-->
## CI report:
* ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10964:
[FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session
cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964#issuecomment-579861664
<!--
Meta data
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146630418 TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660 TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
-->
## CI report:
* ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146630418) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10964:
[FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session
cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964#issuecomment-579861664
<!--
Meta data
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146630418 TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660 TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
Hash:773cdd25c14ec123411e09baabd9522467cd6dbf Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:773cdd25c14ec123411e09baabd9522467cd6dbf
-->
## CI report:
* ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146630418) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660)
* 773cdd25c14ec123411e09baabd9522467cd6dbf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10964: [FLINK-15806][yarn]
Log recommended way how to stop a detached Yarn session cluster
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964#issuecomment-581400845
Thanks for the review @kl0u. Merging this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10964:
[FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session
cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964#issuecomment-579861664
<!--
Meta data
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146630418 TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660 TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
Hash:773cdd25c14ec123411e09baabd9522467cd6dbf Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146799827 TriggerType:PUSH TriggerID:773cdd25c14ec123411e09baabd9522467cd6dbf
Hash:773cdd25c14ec123411e09baabd9522467cd6dbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4700 TriggerType:PUSH TriggerID:773cdd25c14ec123411e09baabd9522467cd6dbf
-->
## CI report:
* ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146630418) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660)
* 773cdd25c14ec123411e09baabd9522467cd6dbf Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146799827) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10964:
[FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session
cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964#issuecomment-579861664
<!--
Meta data
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146630418 TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660 TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
Hash:773cdd25c14ec123411e09baabd9522467cd6dbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146799827 TriggerType:PUSH TriggerID:773cdd25c14ec123411e09baabd9522467cd6dbf
Hash:773cdd25c14ec123411e09baabd9522467cd6dbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4700 TriggerType:PUSH TriggerID:773cdd25c14ec123411e09baabd9522467cd6dbf
-->
## CI report:
* ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146630418) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660)
* 773cdd25c14ec123411e09baabd9522467cd6dbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146799827) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #10964:
[FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session
cluster
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10964: [FLINK-15806][yarn] Log
recommended way how to stop a detached Yarn session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964#issuecomment-579855268
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 (Wed Jan 29 16:57:46 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10964: [FLINK-15806][yarn]
Log recommended way how to stop a detached Yarn session cluster
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964#issuecomment-580365091
Good point @kl0u. I will update the PR accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10964:
[FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session
cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
URL: https://github.com/apache/flink/pull/10964#issuecomment-579861664
<!--
Meta data
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146630418 TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
Hash:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660 TriggerType:PUSH TriggerID:ca1a1bd8f2a853008dc6dbbeb088090f535b9e14
-->
## CI report:
* ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146630418) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services