You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/10/12 13:58:22 UTC
[PR] Minor: improve `join_on` docs [arrow-datafusion]
alamb opened a new pull request, #7813:
URL: https://github.com/apache/arrow-datafusion/pull/7813
Draft as it builds on https://github.com/apache/arrow-datafusion/pull/7805
## Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/pull/7805 and https://github.com/apache/arrow-datafusion/issues/7766
## Rationale for this change
The capabilities of datafusion with `joins` could be better documented, so let's fix that.
## What changes are included in this PR?
Update documentation comments
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: improve `join` / `join_on` docs [arrow-datafusion]
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #7813:
URL: https://github.com/apache/arrow-datafusion/pull/7813#discussion_r1363165103
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -650,8 +659,15 @@ impl LogicalPlanBuilder {
///
/// let right_plan = LogicalPlanBuilder::scan("right", right_table, None)?.build()?;
///
- /// let exprs = vec![col("left.a").eq(col("right.a")), col("left.b").not_eq(col("right.b"))];
+ /// // Form the expression `(left.a != right.a)` AND `(left.b != right.b)`
+ /// let exprs = vec![
+ /// col("left.a").eq(col("right.a")),
+ /// col("left.b").not_eq(col("right.b"))
+ /// ];
///
+ /// // Perform the equivalent of `left INNER JOIN right ON (a != a2 AND b != b2)`
+ /// // finding all pairs of rows from `left` and `right` where
+ /// // where `a != a2` and `b != b2`.
Review Comment:
```suggestion
/// // where `a = a2` and `b != b2`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: improve `join` / `join_on` docs [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7813:
URL: https://github.com/apache/arrow-datafusion/pull/7813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: improve `join` / `join_on` docs [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7813:
URL: https://github.com/apache/arrow-datafusion/pull/7813#discussion_r1364528869
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -650,8 +659,15 @@ impl LogicalPlanBuilder {
///
/// let right_plan = LogicalPlanBuilder::scan("right", right_table, None)?.build()?;
///
- /// let exprs = vec![col("left.a").eq(col("right.a")), col("left.b").not_eq(col("right.b"))];
+ /// // Form the expression `(left.a != right.a)` AND `(left.b != right.b)`
+ /// let exprs = vec![
+ /// col("left.a").eq(col("right.a")),
+ /// col("left.b").not_eq(col("right.b"))
+ /// ];
///
+ /// // Perform the equivalent of `left INNER JOIN right ON (a != a2 AND b != b2)`
+ /// // finding all pairs of rows from `left` and `right` where
+ /// // where `a != a2` and `b != b2`.
Review Comment:
Good catch -- thanks @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: improve `join` / `join_on` docs [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7813:
URL: https://github.com/apache/arrow-datafusion/pull/7813#issuecomment-1769371414
Thanks for the review @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org