You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/06 12:52:05 UTC

[GitHub] [incubator-superset] kkucharc commented on pull request #11131: test: removed unicode_test example from unit tests

kkucharc commented on pull request #11131:
URL: https://github.com/apache/incubator-superset/pull/11131#issuecomment-704247237


   @dpgaspar Thanks for review! 
   About moving file, I am not sure if putting this file in `tests/dashboards/` would be good idea, since `schedules_test.py` and `security_tests.py` which also use it are in `tests/` dir. Also actually `api_tests.py` which uses this fixture is in `databases/` - not in `dashboards/`. But it still creates dashboards for those tests, so I don't have really strong opinion about it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org