You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Mark Bretl <mb...@pivotal.io> on 2015/11/16 20:26:53 UTC
Review Request 40362: GEODE-151: Convert to use Gradle Git plugin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40362/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Dick Cavender, and Dan Smith.
Bugs: GEODE-151
https://issues.apache.org/jira/browse/GEODE-151
Repository: geode
Description
-------
The build was using the executable git command to populate version
information, which created big blocks of Gradle code and could be
unstable. All Git executable commands have been changed to use the
Gradle Git plugin. If directory is not a valid Git workspace, then
it will log a warning and use default values to populate version
information.
Diffs
-----
build.gradle e3b1033e1205ed3064691ecfd63fe92f08096af4
gemfire-core/build.gradle 80761ed8894567f20b450caa059ea4526b24b0ee
Diff: https://reviews.apache.org/r/40362/diff/
Testing
-------
Tested compiling with and without Git workspace. Verified GemFireVersion.properties is correct.
Thanks,
Mark Bretl
Re: Review Request 40362: GEODE-151: Convert to use Gradle Git plugin
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40362/#review106708
-----------------------------------------------------------
gemfire-core/build.gradle (line 106)
<https://reviews.apache.org/r/40362/#comment165441>
Remove dead code.
gemfire-core/build.gradle (line 108)
<https://reviews.apache.org/r/40362/#comment165444>
Let's combine this into one log line.
gemfire-core/build.gradle (line 113)
<https://reviews.apache.org/r/40362/#comment165442>
Can you move this into the success code block above?
gemfire-core/build.gradle (line 117)
<https://reviews.apache.org/r/40362/#comment165445>
Is this logging necessary?
gemfire-core/build.gradle (line 121)
<https://reviews.apache.org/r/40362/#comment165443>
Can you move this into the exception block above?
- Anthony Baker
On Nov. 16, 2015, 7:26 p.m., Mark Bretl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40362/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 7:26 p.m.)
>
>
> Review request for geode, Anthony Baker, Dick Cavender, and Dan Smith.
>
>
> Bugs: GEODE-151
> https://issues.apache.org/jira/browse/GEODE-151
>
>
> Repository: geode
>
>
> Description
> -------
>
> The build was using the executable git command to populate version
> information, which created big blocks of Gradle code and could be
> unstable. All Git executable commands have been changed to use the
> Gradle Git plugin. If directory is not a valid Git workspace, then
> it will log a warning and use default values to populate version
> information.
>
>
> Diffs
> -----
>
> build.gradle e3b1033e1205ed3064691ecfd63fe92f08096af4
> gemfire-core/build.gradle 80761ed8894567f20b450caa059ea4526b24b0ee
>
> Diff: https://reviews.apache.org/r/40362/diff/
>
>
> Testing
> -------
>
> Tested compiling with and without Git workspace. Verified GemFireVersion.properties is correct.
>
>
> Thanks,
>
> Mark Bretl
>
>
Re: Review Request 40362: GEODE-151: Convert to use Gradle Git plugin
Posted by Dick Cavender <dc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40362/#review107814
-----------------------------------------------------------
Ship it!
We still need to work on changing the build number from a date string to the commit count. Is there a Jira for doing this?
- Dick Cavender
On Nov. 16, 2015, 7:45 p.m., Mark Bretl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40362/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 7:45 p.m.)
>
>
> Review request for geode, Anthony Baker, Dick Cavender, and Dan Smith.
>
>
> Bugs: GEODE-151
> https://issues.apache.org/jira/browse/GEODE-151
>
>
> Repository: geode
>
>
> Description
> -------
>
> The build was using the executable git command to populate version
> information, which created big blocks of Gradle code and could be
> unstable. All Git executable commands have been changed to use the
> Gradle Git plugin. If directory is not a valid Git workspace, then
> it will log a warning and use default values to populate version
> information.
>
>
> Diffs
> -----
>
> build.gradle e3b1033e1205ed3064691ecfd63fe92f08096af4
> gemfire-core/build.gradle 80761ed8894567f20b450caa059ea4526b24b0ee
>
> Diff: https://reviews.apache.org/r/40362/diff/
>
>
> Testing
> -------
>
> Tested compiling with and without Git workspace. Verified GemFireVersion.properties is correct.
>
>
> Thanks,
>
> Mark Bretl
>
>
Re: Review Request 40362: GEODE-151: Convert to use Gradle Git plugin
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40362/#review106715
-----------------------------------------------------------
Ship it!
Ship It!
- Anthony Baker
On Nov. 16, 2015, 7:45 p.m., Mark Bretl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40362/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 7:45 p.m.)
>
>
> Review request for geode, Anthony Baker, Dick Cavender, and Dan Smith.
>
>
> Bugs: GEODE-151
> https://issues.apache.org/jira/browse/GEODE-151
>
>
> Repository: geode
>
>
> Description
> -------
>
> The build was using the executable git command to populate version
> information, which created big blocks of Gradle code and could be
> unstable. All Git executable commands have been changed to use the
> Gradle Git plugin. If directory is not a valid Git workspace, then
> it will log a warning and use default values to populate version
> information.
>
>
> Diffs
> -----
>
> build.gradle e3b1033e1205ed3064691ecfd63fe92f08096af4
> gemfire-core/build.gradle 80761ed8894567f20b450caa059ea4526b24b0ee
>
> Diff: https://reviews.apache.org/r/40362/diff/
>
>
> Testing
> -------
>
> Tested compiling with and without Git workspace. Verified GemFireVersion.properties is correct.
>
>
> Thanks,
>
> Mark Bretl
>
>
Re: Review Request 40362: GEODE-151: Convert to use Gradle Git plugin
Posted by Mark Bretl <mb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40362/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 7:45 p.m.)
Review request for geode, Anthony Baker, Dick Cavender, and Dan Smith.
Changes
-------
Updates from Anthony's review
Bugs: GEODE-151
https://issues.apache.org/jira/browse/GEODE-151
Repository: geode
Description
-------
The build was using the executable git command to populate version
information, which created big blocks of Gradle code and could be
unstable. All Git executable commands have been changed to use the
Gradle Git plugin. If directory is not a valid Git workspace, then
it will log a warning and use default values to populate version
information.
Diffs (updated)
-----
build.gradle e3b1033e1205ed3064691ecfd63fe92f08096af4
gemfire-core/build.gradle 80761ed8894567f20b450caa059ea4526b24b0ee
Diff: https://reviews.apache.org/r/40362/diff/
Testing
-------
Tested compiling with and without Git workspace. Verified GemFireVersion.properties is correct.
Thanks,
Mark Bretl