You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/08/25 13:19:29 UTC
[I] ACL user pagination loads every Apache account before slicing [rocketmq-dashboard]
tju-yxq opened a new issue, #2582:
URL: https://github.com/apache/rocketmq-dashboard/issues/2582
## Problem
`GET /api/acl/users/page` currently uses a full-list read for Apache instances:
```java
List<AclUserVO> users = (isTencentInstance(instanceId)
? tencentAclService.listUsers(instanceId) : aclRepository.findUsers()).stream()
...
int from = ...
int to = ...
return PageResult.of(users.subList(from, to), users.size(), page, pageSize);
```
For Apache users, this:
1. reads every row from `rmq_acl_user`;
2. decodes every secret;
3. filters and sorts all users in memory;
4. finally slices one page.
The paginated endpoint is therefore O(total ACL users), not O(pageSize). This is inconsistent with `GET /api/acl/rules`, which already performs filtering, ordering, and pagination in SQL.
## Expected behavior
- For Apache instances, `GET /api/acl/users/page` should paginate at the database level.
- Apply keyword filtering in SQL against username and access key.
- Use deterministic ordering: `gmt_create DESC, id DESC`, matching the current frontend-visible order.
- Read and decode credentials only for the returned page.
- Return the existing `items / total / page / size` contract.
- Preserve masked credentials in the page response.
- Keep the Tencent role path unchanged because Tencent role discovery remains a paginated remote API collection without a local database.
- Keep the existing unpaginated endpoint for callers that intentionally need the full inventory.
## Verification scope
Tests should prove that the repository uses `selectPage` rather than `selectList`, the SQL contains username/access-key filtering and deterministic ordering, the service delegates to the repository page method for Apache users, and credentials remain masked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ACL user pagination loads every Apache account before slicing [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq commented on issue #2582:
URL: https://github.com/apache/rocketmq-dashboard/issues/2582#issuecomment-5445560813
The Apache ACL user pagination fix was accepted through merged batch PR #2581 (merge commit 6202e6f). The current rocketmq-studio branch applies database-backed filtering and paging. Closing this issue as completed; PR #2583 was consolidated rather than independently merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ACL user pagination loads every Apache account before slicing [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2582:
URL: https://github.com/apache/rocketmq-dashboard/issues/2582#issuecomment-5412432962
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
Valid performance bug. Loading all ACL users into memory before slicing for pagination is inefficient and will degrade as the number of Apache accounts grows.
**Root Cause:** The ACL user list endpoint fetches the full dataset and then applies pagination in-memory, rather than using server-side pagination (LIMIT/OFFSET or cursor-based).
**Impact:**
- Increased API response time as the user base grows.
- Unnecessary memory and bandwidth usage on both server and client.
- Inconsistent with the pattern used in other paginated endpoints (consumer groups, alerts).
**Severity:** Medium — functional but increasingly slow. The fix pattern already exists in the codebase (other endpoints use server-side pagination).
This should be fixed to use server-side pagination, consistent with the approach taken for consumer groups and other entities.
---
*Automated evaluation by github-manager*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ACL user pagination loads every Apache account before slicing [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq closed issue #2582: ACL user pagination loads every Apache account before slicing
URL: https://github.com/apache/rocketmq-dashboard/issues/2582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org