You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/09 04:27:57 UTC

[GitHub] [arrow] milesgranger commented on a diff in pull request #14574: ARROW-18225: [Python] Fully use filesystem in parquet.write_metadata

milesgranger commented on code in PR #14574:
URL: https://github.com/apache/arrow/pull/14574#discussion_r1017416364


##########
python/pyarrow/parquet/core.py:
##########
@@ -3430,10 +3430,14 @@ def write_metadata(schema, where, metadata_collector=None, **kwargs):
     if metadata_collector is not None:
         # ParquetWriter doesn't expose the metadata until it's written. Write
         # it and read it again.
-        metadata = read_metadata(where)
+        metadata = read_metadata(where, filesystem=kwargs.get("filesystem"))

Review Comment:
   Oi, I misinterpreted this one. Updated now. :) https://github.com/apache/arrow/pull/14574/commits/e120e9ada309d83df674be22e2106e8e056cab44 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org