You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jira-importer (via GitHub)" <gi...@apache.org> on 2025/02/28 10:41:36 UTC

[I] [MCLEAN-39] followSymLinks is always set to true [maven-clean-plugin]

jira-importer opened a new issue, #202:
URL: https://github.com/apache/maven-clean-plugin/issues/202

   **[Sébastien Deleuze](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=bouiaw)** opened **[MCLEAN-39](https://issues.apache.org/jira/browse/MCLEAN-39?redirect=false)** and commented
   
   From my tests, followSymLinks that is used to delete the content of symlink when it is set to true, is not taken in account.
   It should be a regression caused by http://jira.codehaus.org/browse/MCLEAN-28
   
   This is a blocker bug, since it could delete all the filesystem easily, and there is no workaround. Even when I set followSymLinks  explicitley to false, Maven clean 2.3 follow symlinks and delete its contents.
   
   To reproduce :
   Declare 2.3 clean plugin in your pom
   mkdir /tmp/test
   touch /tmp/test/foo
   symlink -s /tmp/test /myproject/target/test
   cd /myproject
   mvn clean
   
   After runnig that, /tmp/test is empty !
   
   If it is confirmed, I would recommand to release quickly a 2.4 version with a fix, since in is REALLY dansgerous.
   
   
   ---
   
   **Affects:** 2.3
   
   **Attachments:**
   - [clean.txt](https://issues.apache.org/jira/secure/attachment/12714808/clean.txt) (_22.81 kB_)
   - [test-clean.zip](https://issues.apache.org/jira/secure/attachment/12714801/test-clean.zip) (_845 bytes_)
   
   **Issue Links:**
   - [MWAR-205](https://issues.apache.org/jira/browse/MWAR-205) A useDefaultExcludes=false option, like the assembly plugin has.
   
   
   4 votes, 0 watchers
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MCLEAN-39] followSymLinks is always set to true [maven-clean-plugin]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #202:
URL: https://github.com/apache/maven-clean-plugin/issues/202#issuecomment-2690314693

   **[Sébastien Deleuze](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=bouiaw)** commented
   
   From what I saw, there is a few code in the clean plugin, and from a diff between 2.1.1 (where the issue did not occure) and 2.3, I don't see any change that could cause this bug.
   
   I think the issue come from something that has been broken between Maven file-management 1.0 (Maven clean 2.1.1) and Maven file-management 1.2.1 (Maven clean 2.3), eventually from its plexus-utils dependency.
   
   For information, this bug is not testable with Maven Clean 2.2 (file-management 1.2) because of http://jira.codehaus.org/browse/MCLEAN-28.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MCLEAN-39] followSymLinks is always set to true [maven-clean-plugin]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #202:
URL: https://github.com/apache/maven-clean-plugin/issues/202#issuecomment-2690314679

   **[Sébastien Deleuze](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=bouiaw)** commented
   
   The only workaround I have found is to use 2.1.1 release.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MCLEAN-39] followSymLinks is always set to true [maven-clean-plugin]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #202:
URL: https://github.com/apache/maven-clean-plugin/issues/202#issuecomment-2690314684

   **[Brian E. Fox (imported)](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brianf@infinity.nu)** commented
   
   A quick scan of the code shows everything in order. Can you include output of "mvn clean -X"  ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MCLEAN-39] followSymLinks is always set to true [maven-clean-plugin]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #202:
URL: https://github.com/apache/maven-clean-plugin/issues/202#issuecomment-2690314701

   **[Benjamin Bentmann](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=bentmann)** commented
   
   Fixed in [r897682](http://svn.apache.org/viewvc?view=revision&revision=897682).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MCLEAN-39] followSymLinks is always set to true [maven-clean-plugin]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #202:
URL: https://github.com/apache/maven-clean-plugin/issues/202#issuecomment-2690314688

   **[Sébastien Deleuze](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=bouiaw)** commented
   
   You will find attached the output of mvn -X clean, and a test case to reproduce the issue.
   Run the sh script and next run mvn clean to see the issue : /tmp/test/toto is deleted with default configuration !
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org