You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2018/08/31 22:14:10 UTC

Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/
-----------------------------------------------------------

Review request for mesos, Meng Zhu and Till Toenshoff.


Bugs: MESOS-9187
    https://issues.apache.org/jira/browse/MESOS-9187


Repository: mesos


Description
-------

This tests measures allocation performance with non-uniform framework
characteristics. Each framework profile launches a different number of
tasks with different task sizes.


Diffs
-----

  src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68591/diff/1/


Testing
-------

Make check with the new test.


Thanks,

Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Meng Zhu <mz...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208322
-----------------------------------------------------------



Can you post the test result?


src/tests/hierarchical_allocator_benchmarks.cpp
Lines 290 (patched)
<https://reviews.apache.org/r/68591/#comment292163>

    "measures the allocator performance" -- can you elaborate?
    
    One of the pain points I got from reading the benchmark code is that it is not clear what is being tested and what is the figure of merits.
    
    Let's make a good model here and future readers will be grateful :)
    
    Please also update the commit description along with it.



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 357-358 (patched)
<https://reviews.apache.org/r/68591/#comment292166>

    Move this TODO to the frameworkProfile struct.



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 360 (patched)
<https://reviews.apache.org/r/68591/#comment292167>

    Use `at` for readonly access



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 365-370 (patched)
<https://reviews.apache.org/r/68591/#comment292168>

    I suggest moving the `--` and `++` to the loop body for readibility.



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 367 (patched)
<https://reviews.apache.org/r/68591/#comment292170>

    "&" --> "&&"
    
    I think the compiler will complain in this case. Did you forget to send out the most recent commit?



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 379 (patched)
<https://reviews.apache.org/r/68591/#comment292175>

    s/process:://
    
    Also, why we need to `settle` here? Can you add some comments?



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 382 (patched)
<https://reviews.apache.org/r/68591/#comment292169>

    why do we need to settle here? Can you add some comments?



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 389-397 (patched)
<https://reviews.apache.org/r/68591/#comment292174>

    The logic here is surprising. When we advance the clock, it will generate offers but since we haven't processed anything yet, I do not expect to see the "cout" log line.
    
    Also, I believe if we fix the pause bug I mentioned in the previous patch, the first log line will look like "Launched 0 tasks", how about:
    
    while() {
      advance clock
      settle
      process the result
      cout the result
    }


- Meng Zhu


On Aug. 31, 2018, 3:14 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2018, 3:14 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This tests measures allocation performance with non-uniform framework
> characteristics. Each framework profile launches a different number of
> tasks with different task sizes.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/1/
> 
> 
> Testing
> -------
> 
> Make check with the new test.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208207
-----------------------------------------------------------



PASS: Mesos patch 68591 was successfully built and tested.

Reviews applied: `['68549', '68548', '68591']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2270/mesos-review-68591

- Mesos Reviewbot Windows


On Aug. 31, 2018, 10:14 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2018, 10:14 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This tests measures allocation performance with non-uniform framework
> characteristics. Each framework profile launches a different number of
> tasks with different task sizes.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/1/
> 
> 
> Testing
> -------
> 
> Make check with the new test.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.


> On Sept. 11, 2018, 8:17 p.m., Meng Zhu wrote:
> > src/tests/hierarchical_allocator_benchmarks.cpp
> > Lines 378 (patched)
> > <https://reviews.apache.org/r/68591/diff/2/?file=2088300#file2088300line378>
> >
> >     As I mentioned in the previous patch, it is confusing here that the test needs to resume the allocator even it did not pause it. The test will control the clock, and that should be enough for it to dictate the test progress.

That was an oversight. Thanks for the catch


> On Sept. 11, 2018, 8:17 p.m., Meng Zhu wrote:
> > src/tests/hierarchical_allocator_benchmarks.cpp
> > Lines 409-411 (patched)
> > <https://reviews.apache.org/r/68591/diff/2/?file=2088300#file2088300line409>
> >
> >     We might as well `unallocate` the offered resources instead of allocating the `taskResources`, both are not ideal, but with the former, we at least save some writes:
> >     
> >     ```
> >     Resources remainingResources = offer.resources;
> >     const Resources& taskResources = frameworkTaskResources.at(offer.frameworkId);
> >     
> >     // We strip allocation information of `remainingResources` so that we
> >     // can compare/subtract with `taskResources`.
> >     remainingResources.unallocate();
> >     
> >     ```

We need to "reallocate" before calling allocator to recover. But yeah, it saves some writes.


> On Sept. 11, 2018, 8:17 p.m., Meng Zhu wrote:
> > src/tests/hierarchical_allocator_benchmarks.cpp
> > Lines 436-437 (patched)
> > <https://reviews.apache.org/r/68591/diff/2/?file=2088300#file2088300line436>
> >
> >     in << ... << allocation rounds/cycles

That was a weird mix of wordings. I have updated the patch to address some of that.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208533
-----------------------------------------------------------


On Sept. 13, 2018, 4:25 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2018, 4:25 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This tests measures allocation performance with non-uniform framework
> characteristics. Each framework profile launches a different number of
> tasks with different task sizes.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/3/
> 
> 
> Testing
> -------
> 
> ```
> [ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
> Added 80 agents in 17.162452ms
> Added 554 frameworks in 220.842289ms
> Start allocation
> Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
> Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
> Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
> Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
> Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
> Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
> Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
> Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
> Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
> Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
> Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
> Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
> Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
> Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
> Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
> Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
> Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
> Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
> Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
> Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
> Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
> Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
> Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
> Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
> Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
> Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
> Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
> Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
> Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
> ...
> Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
> Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
> Failed to launch all tasks: Timed out after 1mins
> Resource statistics:
> Cluster capacity: cpus:5120; mem:39040000
> Cluster allocation: cpus:1093.4; mem:1688000
> Target allocation: cpus:2370; mem:17400000
> [       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
> ```
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Meng Zhu <mz...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208533
-----------------------------------------------------------




src/tests/hierarchical_allocator_benchmarks.cpp
Lines 350-372 (patched)
<https://reviews.apache.org/r/68591/#comment292541>

    Can you add some comments here to each framework, it is hard to grasp the difference between these framework profiles at the first glance.



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 378 (patched)
<https://reviews.apache.org/r/68591/#comment292530>

    As I mentioned in the previous patch, it is confusing here that the test needs to resume the allocator even it did not pause it. The test will control the clock, and that should be enough for it to dictate the test progress.



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 380-381 (patched)
<https://reviews.apache.org/r/68591/#comment292531>

    Is this comment accurate? It looks like we run the test for a fixed amount of time, not "perform a fixed number of allocations".



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 409-411 (patched)
<https://reviews.apache.org/r/68591/#comment292535>

    We might as well `unallocate` the offered resources instead of allocating the `taskResources`, both are not ideal, but with the former, we at least save some writes:
    
    ```
    Resources remainingResources = offer.resources;
    const Resources& taskResources = frameworkTaskResources.at(offer.frameworkId);
    
    // We strip allocation information of `remainingResources` so that we
    // can compare/subtract with `taskResources`.
    remainingResources.unallocate();
    
    ```



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 413 (patched)
<https://reviews.apache.org/r/68591/#comment292536>

    `maxTasksPerOffer` sounds like a const, can you rename the current `tasksLaunched` to `totalTaskLaunched`. And use `tasksLaunched` or whatever to track tasks launched in this iteration and compare that with `maxTasksPerOffer`?



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 436-437 (patched)
<https://reviews.apache.org/r/68591/#comment292537>

    in << ... << allocation rounds/cycles


- Meng Zhu


On Sept. 11, 2018, 12:22 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2018, 12:22 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This tests measures allocation performance with non-uniform framework
> characteristics. Each framework profile launches a different number of
> tasks with different task sizes.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> [ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
> Added 80 agents in 17.162452ms
> Added 554 frameworks in 220.842289ms
> Start allocation
> Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
> Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
> Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
> Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
> Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
> Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
> Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
> Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
> Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
> Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
> Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
> Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
> Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
> Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
> Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
> Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
> Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
> Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
> Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
> Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
> Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
> Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
> Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
> Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
> Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
> Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
> Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
> Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
> Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
> ...
> Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
> Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
> Failed to launch all tasks: Timed out after 1mins
> Resource statistics:
> Cluster capacity: cpus:5120; mem:39040000
> Cluster allocation: cpus:1093.4; mem:1688000
> Target allocation: cpus:2370; mem:17400000
> [       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
> ```
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208526
-----------------------------------------------------------



PASS: Mesos patch 68591 was successfully built and tested.

Reviews applied: `['68549', '68548', '68591']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2321/mesos-review-68591

- Mesos Reviewbot Windows


On Sept. 11, 2018, 12:22 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2018, 12:22 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This tests measures allocation performance with non-uniform framework
> characteristics. Each framework profile launches a different number of
> tasks with different task sizes.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> [ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
> Added 80 agents in 17.162452ms
> Added 554 frameworks in 220.842289ms
> Start allocation
> Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
> Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
> Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
> Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
> Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
> Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
> Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
> Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
> Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
> Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
> Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
> Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
> Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
> Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
> Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
> Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
> Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
> Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
> Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
> Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
> Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
> Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
> Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
> Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
> Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
> Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
> Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
> Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
> Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
> ...
> Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
> Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
> Failed to launch all tasks: Timed out after 1mins
> Resource statistics:
> Cluster capacity: cpus:5120; mem:39040000
> Cluster allocation: cpus:1093.4; mem:1688000
> Target allocation: cpus:2370; mem:17400000
> [       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
> ```
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.


> On Sept. 14, 2018, 3:07 p.m., Meng Zhu wrote:
> > src/tests/hierarchical_allocator_benchmarks.cpp
> > Lines 422 (patched)
> > <https://reviews.apache.org/r/68591/diff/6/?file=2089056#file2089056line422>
> >
> >     Is this redundant? since we already checked `frameworkTasksLaunched[frameworkId] < frameworkProfile.maxTasksPerInstance`
> 
> Kapil Arya wrote:
>     This is tracking total tasks across all frameworks as opposed to total tasks per framework.

Fixed now.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208632
-----------------------------------------------------------


On Sept. 14, 2018, 3:22 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2018, 3:22 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This benchmark launches frameworks with different profiles (number of
> tasks, task sizes and etc.) and prints out statistics such as total
> tasks launched, cluster utilization and allocation latency. The test has
> a timeout of 30 seconds
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/8/
> 
> 
> Testing
> -------
> 
> ```
> [ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
> Added 80 agents in 2.727787ms
> Added 554 frameworks in 33.126141ms
> Start allocation
> Launched 1152 tasks out of 19500 total tasks in 1 rounds. Current allocation round generated 80 offers and took 18.470138ms
> Launched 1828 tasks out of 19500 total tasks in 2 rounds. Current allocation round generated 79 offers and took 12.000794ms
> Launched 2404 tasks out of 19500 total tasks in 3 rounds. Current allocation round generated 78 offers and took 19.469854ms
> Launched 2605 tasks out of 19500 total tasks in 4 rounds. Current allocation round generated 77 offers and took 20.271342ms
> Launched 2706 tasks out of 19500 total tasks in 5 rounds. Current allocation round generated 76 offers and took 20.172579ms
> Launched 2806 tasks out of 19500 total tasks in 6 rounds. Current allocation round generated 75 offers and took 19.731885ms
> Launched 2906 tasks out of 19500 total tasks in 7 rounds. Current allocation round generated 74 offers and took 19.9954ms
> Launched 3006 tasks out of 19500 total tasks in 8 rounds. Current allocation round generated 73 offers and took 18.969235ms
> Launched 3106 tasks out of 19500 total tasks in 9 rounds. Current allocation round generated 72 offers and took 11.915086ms
> Launched 3106 tasks out of 19500 total tasks in 10 rounds. Current allocation round generated 71 offers and took 19.106293ms
> ...
> Launched 3106 tasks out of 19500 total tasks in 2749 rounds. Current allocation round generated 0 offers and took 11.747351ms
> Failed to launch all tasks: Timed out after 30secs
> Resource statistics:
> Cluster capacity: cpus:5120; mem:39040000
> Cluster allocation: cpus:1147.6; mem:1864000
> Target allocation: cpus:2370; mem:17400000
> [       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (30055 ms)
> ```
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.


> On Sept. 14, 2018, 3:07 p.m., Meng Zhu wrote:
> > src/tests/hierarchical_allocator_benchmarks.cpp
> > Lines 422 (patched)
> > <https://reviews.apache.org/r/68591/diff/6/?file=2089056#file2089056line422>
> >
> >     Is this redundant? since we already checked `frameworkTasksLaunched[frameworkId] < frameworkProfile.maxTasksPerInstance`

This is tracking total tasks across all frameworks as opposed to total tasks per framework.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208632
-----------------------------------------------------------


On Sept. 14, 2018, 3:17 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2018, 3:17 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This benchmark launches frameworks with different profiles (number of
> tasks, task sizes and etc.) and prints out statistics such as total
> tasks launched, cluster utilization and allocation latency. The test has
> a timeout of 30 seconds
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/7/
> 
> 
> Testing
> -------
> 
> ```
> [ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
> Added 80 agents in 2.727787ms
> Added 554 frameworks in 33.126141ms
> Start allocation
> Launched 1152 tasks out of 19500 total tasks in 1 rounds. Current allocation round generated 80 offers and took 18.470138ms
> Launched 1828 tasks out of 19500 total tasks in 2 rounds. Current allocation round generated 79 offers and took 12.000794ms
> Launched 2404 tasks out of 19500 total tasks in 3 rounds. Current allocation round generated 78 offers and took 19.469854ms
> Launched 2605 tasks out of 19500 total tasks in 4 rounds. Current allocation round generated 77 offers and took 20.271342ms
> Launched 2706 tasks out of 19500 total tasks in 5 rounds. Current allocation round generated 76 offers and took 20.172579ms
> Launched 2806 tasks out of 19500 total tasks in 6 rounds. Current allocation round generated 75 offers and took 19.731885ms
> Launched 2906 tasks out of 19500 total tasks in 7 rounds. Current allocation round generated 74 offers and took 19.9954ms
> Launched 3006 tasks out of 19500 total tasks in 8 rounds. Current allocation round generated 73 offers and took 18.969235ms
> Launched 3106 tasks out of 19500 total tasks in 9 rounds. Current allocation round generated 72 offers and took 11.915086ms
> Launched 3106 tasks out of 19500 total tasks in 10 rounds. Current allocation round generated 71 offers and took 19.106293ms
> ...
> Launched 3106 tasks out of 19500 total tasks in 2749 rounds. Current allocation round generated 0 offers and took 11.747351ms
> Failed to launch all tasks: Timed out after 30secs
> Resource statistics:
> Cluster capacity: cpus:5120; mem:39040000
> Cluster allocation: cpus:1147.6; mem:1864000
> Target allocation: cpus:2370; mem:17400000
> [       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (30055 ms)
> ```
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Meng Zhu <mz...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208632
-----------------------------------------------------------


Fix it, then Ship it!




Just a few minor issues, mostly comments.


src/tests/hierarchical_allocator_benchmarks.cpp
Lines 313-315 (patched)
<https://reviews.apache.org/r/68591/#comment292747>

    How about:
    
    // This benchmark launches frameworks with different profiles (number of tasks,
    // task sizes and etc.) and prints out statistics such as total tasks launched, cluster
    // utilization and allocation latency. The test has a timeout of 30 seconds.
    
    Let's also use this for the commit message.



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 332-367 (patched)
<https://reviews.apache.org/r/68591/#comment292740>

    These comments are lovely!



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 334 (patched)
<https://reviews.apache.org/r/68591/#comment292739>

    spread the load more uniformly across what? I suppose allocation cycles?



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 337 (patched)
<https://reviews.apache.org/r/68591/#comment292741>

    Since you mentioned Marathon, might as well name them that way? Ditto below.



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 422 (patched)
<https://reviews.apache.org/r/68591/#comment292742>

    Is this redundant? since we already checked `frameworkTasksLaunched[frameworkId] < frameworkProfile.maxTasksPerInstance`



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 431 (patched)
<https://reviews.apache.org/r/68591/#comment292744>

    // We restore the allocation information to recover the resources.



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 444 (patched)
<https://reviews.apache.org/r/68591/#comment292745>

    This is getting hard to read. How about:
    
    ```
        cout << "Launched " << totalTasksLaunched << " tasks out of "
             << totalTasksToLaunch << " total tasks in "
             << allocationCount << " rounds. Current allocation round generated" << offerCount
             << " offers and took " << watch.elapsed() << endl;
    ```


- Meng Zhu


On Sept. 14, 2018, 11:01 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2018, 11:01 a.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This tests measures allocation performance with non-uniform framework
> characteristics. Each framework profile launches a different number of
> tasks with different task sizes.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/6/
> 
> 
> Testing
> -------
> 
> ```
> [ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
> Added 80 agents in 17.162452ms
> Added 554 frameworks in 220.842289ms
> Start allocation
> Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
> Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
> Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
> Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
> Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
> Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
> Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
> Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
> Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
> Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
> Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
> Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
> Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
> Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
> Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
> Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
> Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
> Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
> Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
> Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
> Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
> Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
> Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
> Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
> Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
> Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
> Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
> Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
> Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
> ...
> Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
> Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
> Failed to launch all tasks: Timed out after 1mins
> Resource statistics:
> Cluster capacity: cpus:5120; mem:39040000
> Cluster allocation: cpus:1093.4; mem:1688000
> Target allocation: cpus:2370; mem:17400000
> [       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
> ```
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208647
-----------------------------------------------------------



PASS: Mesos patch 68591 was successfully built and tested.

Reviews applied: `['68549', '68548', '68591']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2338/mesos-review-68591

- Mesos Reviewbot Windows


On Sept. 14, 2018, 7:22 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2018, 7:22 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This benchmark launches frameworks with different profiles (number of
> tasks, task sizes and etc.) and prints out statistics such as total
> tasks launched, cluster utilization and allocation latency. The test has
> a timeout of 30 seconds
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/9/
> 
> 
> Testing
> -------
> 
> ```
> [ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
> Added 80 agents in 2.727787ms
> Added 554 frameworks in 33.126141ms
> Start allocation
> Launched 1152 tasks out of 19500 total tasks in 1 rounds. Current allocation round generated 80 offers and took 18.470138ms
> Launched 1828 tasks out of 19500 total tasks in 2 rounds. Current allocation round generated 79 offers and took 12.000794ms
> Launched 2404 tasks out of 19500 total tasks in 3 rounds. Current allocation round generated 78 offers and took 19.469854ms
> Launched 2605 tasks out of 19500 total tasks in 4 rounds. Current allocation round generated 77 offers and took 20.271342ms
> Launched 2706 tasks out of 19500 total tasks in 5 rounds. Current allocation round generated 76 offers and took 20.172579ms
> Launched 2806 tasks out of 19500 total tasks in 6 rounds. Current allocation round generated 75 offers and took 19.731885ms
> Launched 2906 tasks out of 19500 total tasks in 7 rounds. Current allocation round generated 74 offers and took 19.9954ms
> Launched 3006 tasks out of 19500 total tasks in 8 rounds. Current allocation round generated 73 offers and took 18.969235ms
> Launched 3106 tasks out of 19500 total tasks in 9 rounds. Current allocation round generated 72 offers and took 11.915086ms
> Launched 3106 tasks out of 19500 total tasks in 10 rounds. Current allocation round generated 71 offers and took 19.106293ms
> ...
> Launched 3106 tasks out of 19500 total tasks in 2749 rounds. Current allocation round generated 0 offers and took 11.747351ms
> Failed to launch all tasks: Timed out after 30secs
> Resource statistics:
> Cluster capacity: cpus:5120; mem:39040000
> Cluster allocation: cpus:1147.6; mem:1864000
> Target allocation: cpus:2370; mem:17400000
> [       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (30055 ms)
> ```
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/
-----------------------------------------------------------

(Updated Sept. 14, 2018, 3:22 p.m.)

Review request for mesos, Meng Zhu and Till Toenshoff.

Bugs: MESOS-9187
https://issues.apache.org/jira/browse/MESOS-9187

Repository: mesos

Description
-------

This benchmark launches frameworks with different profiles (number of
tasks, task sizes and etc.) and prints out statistics such as total
tasks launched, cluster utilization and allocation latency. The test has
a timeout of 30 seconds

Diffs (updated)
-----

src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION

Diff: https://reviews.apache.org/r/68591/diff/8/

Changes: https://reviews.apache.org/r/68591/diff/7-8/

Testing
-------

```
[ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
Added 80 agents in 2.727787ms
Added 554 frameworks in 33.126141ms
Start allocation
Launched 1152 tasks out of 19500 total tasks in 1 rounds. Current allocation round generated 80 offers and took 18.470138ms
Launched 1828 tasks out of 19500 total tasks in 2 rounds. Current allocation round generated 79 offers and took 12.000794ms
Launched 2404 tasks out of 19500 total tasks in 3 rounds. Current allocation round generated 78 offers and took 19.469854ms
Launched 2605 tasks out of 19500 total tasks in 4 rounds. Current allocation round generated 77 offers and took 20.271342ms
Launched 2706 tasks out of 19500 total tasks in 5 rounds. Current allocation round generated 76 offers and took 20.172579ms
Launched 2806 tasks out of 19500 total tasks in 6 rounds. Current allocation round generated 75 offers and took 19.731885ms
Launched 2906 tasks out of 19500 total tasks in 7 rounds. Current allocation round generated 74 offers and took 19.9954ms
Launched 3006 tasks out of 19500 total tasks in 8 rounds. Current allocation round generated 73 offers and took 18.969235ms
Launched 3106 tasks out of 19500 total tasks in 9 rounds. Current allocation round generated 72 offers and took 11.915086ms
Launched 3106 tasks out of 19500 total tasks in 10 rounds. Current allocation round generated 71 offers and took 19.106293ms
...
Launched 3106 tasks out of 19500 total tasks in 2749 rounds. Current allocation round generated 0 offers and took 11.747351ms
Failed to launch all tasks: Timed out after 30secs
Resource statistics:
Cluster capacity: cpus:5120; mem:39040000
Cluster allocation: cpus:1147.6; mem:1864000
Target allocation: cpus:2370; mem:17400000
[ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (30055 ms)
```

Thanks,

Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.

(Updated Sept. 14, 2018, 3:17 p.m.)

Review request for mesos, Meng Zhu and Till Toenshoff.

Bugs: MESOS-9187
https://issues.apache.org/jira/browse/MESOS-9187

Repository: mesos

Description (updated)
-------

Diffs (updated)
-----

src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION

Diff: https://reviews.apache.org/r/68591/diff/7/

Changes: https://reviews.apache.org/r/68591/diff/6-7/

Testing (updated)
-------

Thanks,

Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/
-----------------------------------------------------------

(Updated Sept. 14, 2018, 2:01 p.m.)


Review request for mesos, Meng Zhu and Till Toenshoff.


Bugs: MESOS-9187
    https://issues.apache.org/jira/browse/MESOS-9187


Repository: mesos


Description
-------

This tests measures allocation performance with non-uniform framework
characteristics. Each framework profile launches a different number of
tasks with different task sizes.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68591/diff/6/

Changes: https://reviews.apache.org/r/68591/diff/5-6/


Testing
-------

```
[ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
Added 80 agents in 17.162452ms
Added 554 frameworks in 220.842289ms
Start allocation
Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
...
Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
Failed to launch all tasks: Timed out after 1mins
Resource statistics:
Cluster capacity: cpus:5120; mem:39040000
Cluster allocation: cpus:1093.4; mem:1688000
Target allocation: cpus:2370; mem:17400000
[       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
```


Thanks,

Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208615
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68549', '68548', '68591']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2332/mesos-review-68591

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2332/mesos-review-68591/logs/mesos-tests.log):

```
I0914 00:08:33.265436 26940 executor.cpp:909] Sending SIGTERM to process tree at pid 260000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0914 00:08:33.262449 23164 slave.cpp:6640] Shutting down executor 'b40dbd8c-eafa-4af0-b6b0-51d0f90be082' of framework 19853ac1-1072-4cb5-9b9c-775dbca25c0a-0000 at executor(1)@192.10.1.5:59611
I0914 00:08:33.264442 23164 slave.cpp:909] Agent terminating
I0914 00:08:33.264442 28544 master.cpp:11030] Removing task b40dbd8c-eafa-4af0-b6b0-51d0f90be082 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 19853ac1-1072-4cb5-9b9c-775dbca25c0a-0000 on agent 19853ac1-1072-4cb5-9b9c-775dbca25c0a-S0 at slave(462)@192.10.1.5:57840 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
W0914 00:08:33.265436 23164 slave.cpp:3917] Ignoring shutdown framework 19853ac1-1072-4cb5-9b9c-775dbca25c0a-0000 because it is terminating
I0914 00:08:33.268432 28356 master.cpp:1251] Agent 19853ac1-1072-4cb5-9b9c-775dbca25c0a-S0 at slave(462)@192.10.1.5:57840 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I0914 00:08:33.268432 28356 master.cpp:3267] Disconnecting agent 19853ac1-1072-4cb5-9b9c-775dbca25c0a-S0 at slave(462)@192.10.1.5:57840 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I0914 00:08:33.268432 28356 master.cpp:3286] Deactivating agent 19853ac1-1072-4cb5-9b9c-775dbca25c0a-S0 at slave(462)@192.10.1.5:57840 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I0914 00:08:33.269448 27484 hierarchical.cpp:359] Removed framework 19853ac1-1072-4cb5-9b9c-775dbca25c0a-0000
I0914 00:08:33.269448 27484 hierarchical.cpp:795] Agent 19853ac1-1072-4cb5-9b9c-775dbca25c0a-S0 deactivated
I0914 00:08:33.270464 27316 containerizer.cpp:2455] Destroying container 69ade250-0327-4028-a7f7-f3e526315b91 in RUNNING state
I0914 00:08:33.270464 27316 containerizer.cpp:3118] Transitioning the state of container 69ade250-0327-4028-a7f7-f3e526315b91 from RUNNING to DESTROYING
I0914 00:08:33.271445 27316 launcher.cpp:166] Asked to destroy containe[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (684 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)

[----------] Global test environment tear-down
[==========] 1051 tests from 103 test cases ran. (514705 ms total)
[  PASSED  ] 1050 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage

 1 FAILED TEST
  YOU HAVE 229 DISABLED TESTS

r 69ade250-0327-4028-a7f7-f3e526315b91
I0914 00:08:33.316506 25040 containerizer.cpp:2957] Container 69ade250-0327-4028-a7f7-f3e526315b91 has exited
I0914 00:08:33.345450 28284 master.cpp:1093] Master terminating
I0914 00:08:33.347450 25040 hierarchical.cpp:637] Removed agent 19853ac1-1072-4cb5-9b9c-775dbca25c0a-S0
I0914 00:08:33.800485 23320 process.cpp:926] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Sept. 13, 2018, 11:08 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2018, 11:08 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This tests measures allocation performance with non-uniform framework
> characteristics. Each framework profile launches a different number of
> tasks with different task sizes.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/5/
> 
> 
> Testing
> -------
> 
> ```
> [ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
> Added 80 agents in 17.162452ms
> Added 554 frameworks in 220.842289ms
> Start allocation
> Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
> Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
> Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
> Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
> Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
> Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
> Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
> Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
> Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
> Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
> Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
> Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
> Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
> Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
> Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
> Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
> Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
> Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
> Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
> Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
> Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
> Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
> Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
> Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
> Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
> Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
> Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
> Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
> Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
> ...
> Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
> Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
> Failed to launch all tasks: Timed out after 1mins
> Resource statistics:
> Cluster capacity: cpus:5120; mem:39040000
> Cluster allocation: cpus:1093.4; mem:1688000
> Target allocation: cpus:2370; mem:17400000
> [       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
> ```
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/
-----------------------------------------------------------

(Updated Sept. 13, 2018, 7:08 p.m.)


Review request for mesos, Meng Zhu and Till Toenshoff.


Bugs: MESOS-9187
    https://issues.apache.org/jira/browse/MESOS-9187


Repository: mesos


Description
-------

This tests measures allocation performance with non-uniform framework
characteristics. Each framework profile launches a different number of
tasks with different task sizes.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68591/diff/5/

Changes: https://reviews.apache.org/r/68591/diff/4-5/


Testing
-------

```
[ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
Added 80 agents in 17.162452ms
Added 554 frameworks in 220.842289ms
Start allocation
Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
...
Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
Failed to launch all tasks: Timed out after 1mins
Resource statistics:
Cluster capacity: cpus:5120; mem:39040000
Cluster allocation: cpus:1093.4; mem:1688000
Target allocation: cpus:2370; mem:17400000
[       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
```


Thanks,

Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/
-----------------------------------------------------------

(Updated Sept. 13, 2018, 7:05 p.m.)


Review request for mesos, Meng Zhu and Till Toenshoff.


Bugs: MESOS-9187
    https://issues.apache.org/jira/browse/MESOS-9187


Repository: mesos


Description
-------

This tests measures allocation performance with non-uniform framework
characteristics. Each framework profile launches a different number of
tasks with different task sizes.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68591/diff/4/

Changes: https://reviews.apache.org/r/68591/diff/3-4/


Testing
-------

```
[ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
Added 80 agents in 17.162452ms
Added 554 frameworks in 220.842289ms
Start allocation
Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
...
Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
Failed to launch all tasks: Timed out after 1mins
Resource statistics:
Cluster capacity: cpus:5120; mem:39040000
Cluster allocation: cpus:1093.4; mem:1688000
Target allocation: cpus:2370; mem:17400000
[       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
```


Thanks,

Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/#review208613
-----------------------------------------------------------



PASS: Mesos patch 68591 was successfully built and tested.

Reviews applied: `['68549', '68548', '68591']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2331/mesos-review-68591

- Mesos Reviewbot Windows


On Sept. 13, 2018, 4:25 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68591/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2018, 4:25 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This tests measures allocation performance with non-uniform framework
> characteristics. Each framework profile launches a different number of
> tasks with different task sizes.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68591/diff/3/
> 
> 
> Testing
> -------
> 
> ```
> [ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
> Added 80 agents in 17.162452ms
> Added 554 frameworks in 220.842289ms
> Start allocation
> Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
> Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
> Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
> Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
> Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
> Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
> Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
> Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
> Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
> Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
> Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
> Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
> Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
> Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
> Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
> Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
> Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
> Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
> Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
> Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
> Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
> Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
> Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
> Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
> Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
> Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
> Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
> Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
> Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
> ...
> Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
> Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
> Failed to launch all tasks: Timed out after 1mins
> Resource statistics:
> Cluster capacity: cpus:5120; mem:39040000
> Cluster allocation: cpus:1093.4; mem:1688000
> Target allocation: cpus:2370; mem:17400000
> [       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
> ```
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/
-----------------------------------------------------------

(Updated Sept. 13, 2018, 4:25 p.m.)


Review request for mesos, Meng Zhu and Till Toenshoff.


Bugs: MESOS-9187
    https://issues.apache.org/jira/browse/MESOS-9187


Repository: mesos


Description
-------

This tests measures allocation performance with non-uniform framework
characteristics. Each framework profile launches a different number of
tasks with different task sizes.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68591/diff/3/

Changes: https://reviews.apache.org/r/68591/diff/2-3/


Testing
-------

```
[ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
Added 80 agents in 17.162452ms
Added 554 frameworks in 220.842289ms
Start allocation
Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
...
Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
Failed to launch all tasks: Timed out after 1mins
Resource statistics:
Cluster capacity: cpus:5120; mem:39040000
Cluster allocation: cpus:1093.4; mem:1688000
Target allocation: cpus:2370; mem:17400000
[       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
```


Thanks,

Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/
-----------------------------------------------------------

(Updated Sept. 11, 2018, 3:22 p.m.)


Review request for mesos, Meng Zhu and Till Toenshoff.


Bugs: MESOS-9187
    https://issues.apache.org/jira/browse/MESOS-9187


Repository: mesos


Description
-------

This tests measures allocation performance with non-uniform framework
characteristics. Each framework profile launches a different number of
tasks with different task sizes.


Diffs
-----

  src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68591/diff/2/


Testing (updated)
-------

```
[ RUN      ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations
Added 80 agents in 17.162452ms
Added 554 frameworks in 220.842289ms
Start allocation
Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms
Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms
Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms
Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms
Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms
Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms
Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms
Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms
Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms
Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms
Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms
Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms
Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms
Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms
Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms
Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms
Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms
Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms
Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms
Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms
Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms
Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms
Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms
Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms
Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms
Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms
Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms
Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms
Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms
...
Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms
Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms
Failed to launch all tasks: Timed out after 1mins
Resource statistics:
Cluster capacity: cpus:5120; mem:39040000
Cluster allocation: cpus:1093.4; mem:1688000
Target allocation: cpus:2370; mem:17400000
[       OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms)
```


Thanks,

Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68591/
-----------------------------------------------------------

(Updated Sept. 11, 2018, 3:15 p.m.)


Review request for mesos, Meng Zhu and Till Toenshoff.


Changes
-------

Addressed Meng's comments.


Bugs: MESOS-9187
    https://issues.apache.org/jira/browse/MESOS-9187


Repository: mesos


Description
-------

This tests measures allocation performance with non-uniform framework
characteristics. Each framework profile launches a different number of
tasks with different task sizes.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68591/diff/2/

Changes: https://reviews.apache.org/r/68591/diff/1-2/


Testing
-------

Make check with the new test.


Thanks,

Kapil Arya