You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/21 01:35:57 UTC

[GitHub] [beam] thiagotnunes opened a new pull request, #17422: fix: remove tracing from spannerio change streams

thiagotnunes opened a new pull request, #17422:
URL: https://github.com/apache/beam/pull/17422

   Removes distributed tracing from spannerio change streams. The distributed tracing is not currently adding any value to the debugging or understanding of the process execution. We remove tracing here in order to simplify the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #17422: [BEAM-14344]: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17422:
URL: https://github.com/apache/beam/pull/17422#issuecomment-1114045533

   LGTM. Failures unrelated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] thiagotnunes commented on pull request #17422: [BEAM-14344]: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on PR #17422:
URL: https://github.com/apache/beam/pull/17422#issuecomment-1112800994

   PreCommit failures are unrelated to this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17422: fix: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17422:
URL: https://github.com/apache/beam/pull/17422#issuecomment-1104619396

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #17422: [BEAM-14344]: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17422:
URL: https://github.com/apache/beam/pull/17422#issuecomment-1112906540

   can you rebase the change? I'm starting to review it anyway


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #17422: [BEAM-14344]: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17422:
URL: https://github.com/apache/beam/pull/17422#issuecomment-1112905461

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] thiagotnunes commented on pull request #17422: fix: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on PR #17422:
URL: https://github.com/apache/beam/pull/17422#issuecomment-1112765073

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17422: fix: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17422:
URL: https://github.com/apache/beam/pull/17422#issuecomment-1104619395

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] thiagotnunes commented on pull request #17422: [BEAM-14344]: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on PR #17422:
URL: https://github.com/apache/beam/pull/17422#issuecomment-1112927535

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #17422: [BEAM-14344]: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #17422:
URL: https://github.com/apache/beam/pull/17422


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aaltay commented on pull request #17422: fix: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #17422:
URL: https://github.com/apache/beam/pull/17422#issuecomment-1112444166

   @thiagotnunes - please feel free to tag reviewers or ping them in future PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17422: fix: remove tracing from spannerio change streams

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17422:
URL: https://github.com/apache/beam/pull/17422#issuecomment-1104619390

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org