You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2014/02/12 15:56:06 UTC
Review Request 18005: Delimiter Comma not handled while creating NodeManager
log and local directories
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18005/
-----------------------------------------------------------
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-4629
https://issues.apache.org/jira/browse/AMBARI-4629
Repository: ambari
Description
-------
Added proper code for comma separated list of directories for properties yarn.nodemanager.log-dirs and yarn.nodemanager.local-dirs.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 2d9cb71
ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 0c515b0
ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 0744349
ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py f4b9e8c
ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 57e0244
ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02d8af2
ambari-server/src/test/python/stacks/2.0.6/configs/default.json 32717e1
ambari-server/src/test/python/stacks/2.1.1/YARN/test_apptimelineserver.py ce779e0
Diff: https://reviews.apache.org/r/18005/diff/
Testing
-------
Tested on real cluster with comma separated values of properties. Added special test case for this in stack tests.
Thanks,
Eugene Chekanskiy
Re: Review Request 18005: Delimiter Comma not handled while creating
NodeManager log and local directories
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18005/#review34290
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Feb. 12, 2014, 2:56 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18005/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 2:56 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-4629
> https://issues.apache.org/jira/browse/AMBARI-4629
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added proper code for comma separated list of directories for properties yarn.nodemanager.log-dirs and yarn.nodemanager.local-dirs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 2d9cb71
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 0c515b0
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 0744349
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py f4b9e8c
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 57e0244
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02d8af2
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json 32717e1
> ambari-server/src/test/python/stacks/2.1.1/YARN/test_apptimelineserver.py ce779e0
>
> Diff: https://reviews.apache.org/r/18005/diff/
>
>
> Testing
> -------
>
> Tested on real cluster with comma separated values of properties. Added special test case for this in stack tests.
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>