You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "AnandInguva (via GitHub)" <gi...@apache.org> on 2023/04/25 20:05:58 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #26419: Run unit tests with pre-released dependencies.
AnandInguva opened a new pull request, #26419:
URL: https://github.com/apache/beam/pull/26419
To capture regressions early, we will use the pre-released dependencies for unit tests(precommits). More discussion at https://lists.apache.org/thread/owcm7x208wlpgohgn60z5fzdc3vclw0f
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26419: Run unit tests with pre-released dependencies.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26419:
URL: https://github.com/apache/beam/pull/26419#issuecomment-1522416352
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @tvalentyn for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #26419: Run unit tests with pre-released dependencies.
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on code in PR #26419:
URL: https://github.com/apache/beam/pull/26419#discussion_r1179277321
##########
sdks/python/tox.ini:
##########
@@ -62,23 +62,32 @@ commands_post =
bash {toxinidir}/scripts/run_tox_cleanup.sh
commands = false {envname} is misconfigured
+# Run the tests using pre-released dependencies.
+# https://github.com/apache/beam/issues/25668
[testenv:py{37,38,39,310,311}]
+pip_pre = True
Review Comment:
Okay. Understood what you meant. I was thinking `other tests` meant `jenkins` test suites but `other tests ` means the tests in the tox itself. If every one agrees on adding it to every testenv in tox, i am +1 too. I will make the change.
QQ: do we want to make postcommit tests use release candidates as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26419: Run unit tests with pre-released dependencies.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26419:
URL: https://github.com/apache/beam/pull/26419#issuecomment-1522373353
## [Codecov](https://codecov.io/gh/apache/beam/pull/26419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26419](https://codecov.io/gh/apache/beam/pull/26419?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1d92d4) into [master](https://codecov.io/gh/apache/beam/commit/1a51ba5edebef9622c016331071764830adffc94?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a51ba5) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #26419 +/- ##
=======================================
Coverage 81.10% 81.11%
=======================================
Files 469 469
Lines 67294 67294
=======================================
+ Hits 54579 54583 +4
+ Misses 12715 12711 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `81.11% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 3 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26419/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26419: Run unit tests with pre-released dependencies.
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26419:
URL: https://github.com/apache/beam/pull/26419#issuecomment-1525800609
I think I would explore enabling this for all test suites, not just unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #26419: Run unit tests with pre-released dependencies.
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #26419:
URL: https://github.com/apache/beam/pull/26419#discussion_r1178058852
##########
sdks/python/tox.ini:
##########
@@ -62,23 +62,32 @@ commands_post =
bash {toxinidir}/scripts/run_tox_cleanup.sh
commands = false {envname} is misconfigured
+# Run the tests using pre-released dependencies.
+# https://github.com/apache/beam/issues/25668
[testenv:py{37,38,39,310,311}]
+pip_pre = True
Review Comment:
Can we just define this once in the shared config? https://github.com/apache/beam/blob/f1d92d47cb34ed9190030c875fdcf5b84f62e253/sdks/python/tox.ini#L29
Is there a reason to have it defined in some locations, but not others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #26419: Run unit tests with pre-released dependencies.
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #26419:
URL: https://github.com/apache/beam/pull/26419#issuecomment-1525803624
> I think I would explore enabling this for all test suites, not just unit tests.
Okay. I plan to do it. I am doing a PR per tests. I will raise a PR for post commits soon since it uses jenkins and groovy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva merged pull request #26419: Run unit tests with pre-released dependencies.
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva merged PR #26419:
URL: https://github.com/apache/beam/pull/26419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #26419: Run unit tests with pre-released dependencies.
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #26419:
URL: https://github.com/apache/beam/pull/26419#issuecomment-1522383192
R : @damccorm @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #26419: Run unit tests with pre-released dependencies.
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #26419:
URL: https://github.com/apache/beam/pull/26419#issuecomment-1526055004
Note: the failing test `Run Python_PVR_Flink PreCommit` is not related to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #26419: Run unit tests with pre-released dependencies.
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #26419:
URL: https://github.com/apache/beam/pull/26419#issuecomment-1526057879
FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #26419: Run unit tests with pre-released dependencies.
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #26419:
URL: https://github.com/apache/beam/pull/26419#discussion_r1179273650
##########
sdks/python/tox.ini:
##########
@@ -62,23 +62,32 @@ commands_post =
bash {toxinidir}/scripts/run_tox_cleanup.sh
commands = false {envname} is misconfigured
+# Run the tests using pre-released dependencies.
+# https://github.com/apache/beam/issues/25668
[testenv:py{37,38,39,310,311}]
+pip_pre = True
Review Comment:
I am not sure I undestood the answer. Is there a way (or disadvantage to do so) to enable this once and apply for all tox envs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #26419: Run unit tests with pre-released dependencies.
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #26419:
URL: https://github.com/apache/beam/pull/26419#discussion_r1179412211
##########
sdks/python/tox.ini:
##########
@@ -62,23 +62,32 @@ commands_post =
bash {toxinidir}/scripts/run_tox_cleanup.sh
commands = false {envname} is misconfigured
+# Run the tests using pre-released dependencies.
+# https://github.com/apache/beam/issues/25668
[testenv:py{37,38,39,310,311}]
+pip_pre = True
Review Comment:
> QQ: do we want to make postcommit tests use release candidates as well?
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #26419: Run unit tests with pre-released dependencies.
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on code in PR #26419:
URL: https://github.com/apache/beam/pull/26419#discussion_r1178079216
##########
sdks/python/tox.ini:
##########
@@ -62,23 +62,32 @@ commands_post =
bash {toxinidir}/scripts/run_tox_cleanup.sh
commands = false {envname} is misconfigured
+# Run the tests using pre-released dependencies.
+# https://github.com/apache/beam/issues/25668
[testenv:py{37,38,39,310,311}]
+pip_pre = True
Review Comment:
If I define it here, it would be applicable to all the test envs defined in the tox file. My focus is only for the precommits right now so I just defined it for relevant testenvs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org