You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/21 07:07:49 UTC

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1621: feat: Support Substring(str [from int] [for int])

xudong963 commented on a change in pull request #1621:
URL: https://github.com/apache/arrow-datafusion/pull/1621#discussion_r789405811



##########
File path: datafusion/tests/sql/expr.rs
##########
@@ -499,6 +499,16 @@ async fn test_interval_expressions() -> Result<()> {
     Ok(())
 }
 
+#[cfg(feature = "unicode_expressions")]
+#[tokio::test]
+async fn test_substring_expr() -> Result<()> {

Review comment:
       We can add a test which `from k` (k <=0)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org