You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ex00 <gi...@git.apache.org> on 2017/02/07 09:35:17 UTC

[GitHub] flink pull request #3033: [FLINK-5256] Extend DataSetSingleRowJoin to suppor...

Github user ex00 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3033#discussion_r99778650
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala ---
    @@ -144,21 +150,46 @@ class DataSetSingleRowJoin(
     
         val condition = codeGenerator.generateExpression(joinCondition)
     
    -    val joinMethodBody = s"""
    -                  |${condition.code}
    -                  |if (${condition.resultTerm}) {
    -                  |  ${conversion.code}
    -                  |  ${codeGenerator.collectorTerm}.collect(${conversion.resultTerm});
    -                  |}
    -                  |""".stripMargin
    +    val joinMethodBody =
    +      if (joinType == JoinRelType.INNER) {
    +        s"""
    +         |${condition.code}
    +         |if (${condition.resultTerm}) {
    +         |  ${conversion.code}
    +         |  ${codeGenerator.collectorTerm}.collect(${conversion.resultTerm});
    +         |}
    +         |""".stripMargin
    +    } else {
    +        val singleNode =
    +          if (leftIsSingle) {
    +            leftNode
    +          }
    +          else {
    +            rightNode
    +          }
    +        val notSuitedToCondition = singleNode
    +          .getRowType
    +          .getFieldList
    +          .map(field => getRowType.getFieldNames.indexOf(field.getName))
    +          .map(i => s"${conversion.resultTerm}.setField($i,null);")
    --- End diff --
    
    Hi @fhueske,
    Could you explain that we need generate in ```generateFieldAccesses(boolean firstInput)``` and in ```generateNullValues(boolean firstInput)``` from your coment? What is different between they and ```generateFieldAccess( inputType: TypeInformation[_], inputTerm: String, index: Int, pojoFieldMapping: Option[Array[Int]])``` and 
    ```generateNullLiteral(resultType: TypeInformation[_])``` from ```CodeGenerator``` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---