[GitHub] [incubator-kyuubi] Kwafoor commented on pull request #3164: [KYUUBI #833] Check if `spark.kubernetes.executor.podNamePrefix` is invalid

[GitBox <gi...@apache.org>]

Kwafoor commented on PR #3164:
URL: https://github.com/apache/incubator-kyuubi/pull/3164#issuecomment-1202253149

   > we can move the conf validator closer to proc builder of spark, for 2 main reasons,
   > 
   > 1. it's unnecessary to do this in KyuubiSessionImpl as it will affect other engine types too
   > 2. a session could successfully establish even if the conf is invalid as it only fails when creating apps.
   
   I agree, so I changed validateConf to ProcBuilder.And is it necessary for other engine types validateConf?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org