[GitHub] [spark] allisonwang-db commented on a change in pull request #34402: [SPARK-30220] Enable using Exists/In subqueries outside of the Filter node

[GitBox <gi...@apache.org>]

allisonwang-db commented on a change in pull request #34402:
URL: https://github.com/apache/spark/pull/34402#discussion_r829617806



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -782,10 +782,11 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
 
       case inSubqueryOrExistsSubquery =>
         plan match {
-          case _: Filter | _: SupportsSubquery | _: Join => // Ok
+          case _: Filter | _: SupportsSubquery | _: Join |
+            _: Project | _: Aggregate | _: Window => // Ok

Review comment:
       If so we will also need to check the ScalarSubquery checks above:
   https://github.com/apache/spark/blob/f36a5fb2b88620c1c490d087b0293c4e58d29979/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala#L743-L747




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org