You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gillespeiffer-db (via GitHub)" <gi...@apache.org> on 2026/06/25 12:20:29 UTC
[PR] [SPARK-57669][BUILD] Remove redundant Jackson version declarations managed by jackson-bom [spark]
gillespeiffer-db opened a new pull request, #56773:
URL: https://github.com/apache/spark/pull/56773
### What changes were proposed in this pull request?
This PR drops the redundant per-module `<version>${fasterxml.jackson.version}</version>` declarations on the `com.fasterxml.jackson.dataformat` dependencies in three modules:
- `connector/kinesis-asl` (`jackson-dataformat-cbor`)
- `hadoop-cloud` (`jackson-dataformat-cbor`)
- `resource-managers/kubernetes/core` (`jackson-dataformat-yaml`)
These artifacts are already managed by the `com.fasterxml.jackson:jackson-bom` import in the root POM's `<dependencyManagement>` (and mirrored in `project/SparkBuild.scala`'s `DependencyOverrides`), so the explicit per-module versions are redundant. This is a follow-up to the `jackson-bom` import (apache/spark#52668) and is consistent with the recent `grpc-bom` (apache/spark#56741) and `jjwt-bom` (apache/spark#56155) simplifications.
### Why are the changes needed?
Simplify dependency management. The Jackson version is sourced from `jackson-bom` in a single place rather than repeated per module, which avoids version drift between the BOM and the individual declarations.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No-op on dependency resolution. For each affected module, `build/mvn <profile> -pl <module> dependency:tree -Dincludes='com.fasterxml.jackson*'` resolves the Jackson artifacts identically before and after this change:
- `connector/kinesis-asl` (`-Pkinesis-asl`): `com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.22.0` (plus transitive `jackson-core`/`jackson-databind`/`jackson-annotations`) -- identical.
- `hadoop-cloud` (`-Phadoop-cloud`): `com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.22.0` -- identical.
- `resource-managers/kubernetes/core` (`-Pkubernetes`): `com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.22.0` -- identical.
Plus the usual CI.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58259][BUILD] Remove redundant Jackson version declarations managed by jackson-bom [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56773:
URL: https://github.com/apache/spark/pull/56773#issuecomment-5073755893
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/06e0ee7f3a71d66f3a61aed4490a7e5ec8ef2f56
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58259][BUILD] Remove redundant Jackson version declarations managed by jackson-bom [spark]
Posted by "gillespeiffer-db (via GitHub)" <gi...@apache.org>.
gillespeiffer-db commented on PR #56773:
URL: https://github.com/apache/spark/pull/56773#issuecomment-5044629242
Hello @dongjoon-hyun!
Thank you for catching this! Please excuse the oversight...
I have created a new Jira issue: [[SPARK-58259]: Remove Jackson version declarations managed by jackson-bom](https://issues.apache.org/jira/browse/SPARK-58259), which is linked to the initial issue. I have updated the PR title to reflect this change as well.
I was unable to assign the issue to myself. Can you assist me with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58259][BUILD] Remove redundant Jackson version declarations managed by jackson-bom [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #56773: [SPARK-58259][BUILD] Remove redundant Jackson version declarations managed by jackson-bom
URL: https://github.com/apache/spark/pull/56773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org