You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Yin Huai <hu...@cse.ohio-state.edu> on 2012/09/24 16:10:52 UTC
Review Request: HIVE-3495 elements in aggParameters passed to
SemanticAnalyzer.getGenericUDAFEvaluator are generated in two different ways
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7221/
-----------------------------------------------------------
Review request for hive.
Description
-------
Please see jira for detailed description
This addresses bug HIVE-3495.
https://issues.apache.org/jira/browse/HIVE-3495
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 33ce6ca
ql/src/test/results/clientpositive/count.q.out 61e54c7
ql/src/test/results/clientpositive/nullgroup.q.out 434fa6c
ql/src/test/results/clientpositive/nullgroup2.q.out aa52d62
ql/src/test/results/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
Diff: https://reviews.apache.org/r/7221/diff/
Testing
-------
Cannot test TestHBaseMinimrCliDriver, TestHBaseCliDriver, TestHBaseNegativeCliDriver, testSynchronized in TestEmbeddedHiveMetaStore, testSynchronized in TestRemoteHiveMetaStore, testSynchronized in TestSetUGIOnBothClientServer, testSynchronized in TestSetUGIOnOnlyClient, testSynchronized in TestSetUGIOnOnlyServer, and testNegativeCliDriver_local_mapred_error_cache in TestNegativeCliDriver, since trunk failed on these tests on my machine. Also, since trunk will generate a different order of results (rows are in a different order) for queries skewjoinopt1.q to skewjoinopt5.q, skewjoinopt10.q, skewjoinopt15.q to skewjoinopt17.q, and skewjoinopt19.q to skewjoinopt20.q, I cannot test these queries on my machine either. All other tests pass.
Thanks,
Yin Huai
Re: Review Request: HIVE-3495: For UDAFs,
when generating a plan without map-side-aggregation,
constant agg parameters will be replaced by ExprNodeColumnDesc
Posted by namit jain <nj...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7221/#review12070
-----------------------------------------------------------
Ship it!
Ship It!
- namit jain
On Oct. 1, 2012, 2:35 p.m., Yin Huai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7221/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2012, 2:35 p.m.)
>
>
> Review request for hive.
>
>
> Description
> -------
>
> Please see jira for detailed description
>
>
> This addresses bug HIVE-3495.
> https://issues.apache.org/jira/browse/HIVE-3495
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java bce2a06
> ql/src/test/queries/clientpositive/udaf_percentile_approx.q c436a63
> ql/src/test/results/clientpositive/count.q.out 61e54c7
> ql/src/test/results/clientpositive/nullgroup.q.out 434fa6c
> ql/src/test/results/clientpositive/nullgroup2.q.out aa52d62
> ql/src/test/results/clientpositive/nullgroup4.q.out 3dd3c66
> ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
> ql/src/test/results/clientpositive/udaf_percentile_approx.q.out 4f85a82
>
> Diff: https://reviews.apache.org/r/7221/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Yin Huai
>
>
Re: Review Request: HIVE-3495: For UDAFs,
when generating a plan without map-side-aggregation,
constant agg parameters will be replaced by ExprNodeColumnDesc
Posted by Yin Huai <hu...@cse.ohio-state.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7221/
-----------------------------------------------------------
(Updated Oct. 1, 2012, 2:35 p.m.)
Review request for hive.
Changes
-------
address Namit's comments.
Description
-------
Please see jira for detailed description
This addresses bug HIVE-3495.
https://issues.apache.org/jira/browse/HIVE-3495
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java bce2a06
ql/src/test/queries/clientpositive/udaf_percentile_approx.q c436a63
ql/src/test/results/clientpositive/count.q.out 61e54c7
ql/src/test/results/clientpositive/nullgroup.q.out 434fa6c
ql/src/test/results/clientpositive/nullgroup2.q.out aa52d62
ql/src/test/results/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
ql/src/test/results/clientpositive/udaf_percentile_approx.q.out 4f85a82
Diff: https://reviews.apache.org/r/7221/diff/
Testing
-------
All tests pass.
Thanks,
Yin Huai
Re: Review Request: HIVE-3495: For UDAFs,
when generating a plan without map-side-aggregation,
constant agg parameters will be replaced by ExprNodeColumnDesc
Posted by namit jain <nj...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7221/#review12053
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/7221/#comment25696>
Add lot of comments in this function - when can this
function be invoked etc.
Please change the name of the function.
This looks like a fairly generic function, but it is not.
Please add comments to explain what you are trying
- namit jain
On Sept. 30, 2012, 8:55 p.m., Yin Huai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7221/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2012, 8:55 p.m.)
>
>
> Review request for hive.
>
>
> Description
> -------
>
> Please see jira for detailed description
>
>
> This addresses bug HIVE-3495.
> https://issues.apache.org/jira/browse/HIVE-3495
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 3f2aaaa
> ql/src/test/queries/clientpositive/udaf_percentile_approx.q c436a63
> ql/src/test/results/clientpositive/count.q.out 61e54c7
> ql/src/test/results/clientpositive/nullgroup.q.out 434fa6c
> ql/src/test/results/clientpositive/nullgroup2.q.out aa52d62
> ql/src/test/results/clientpositive/nullgroup4.q.out 3dd3c66
> ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
> ql/src/test/results/clientpositive/udaf_percentile_approx.q.out 4f85a82
>
> Diff: https://reviews.apache.org/r/7221/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Yin Huai
>
>
Re: Review Request: HIVE-3495: For UDAFs,
when generating a plan without map-side-aggregation,
constant agg parameters will be replaced by ExprNodeColumnDesc
Posted by Yin Huai <hu...@cse.ohio-state.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7221/
-----------------------------------------------------------
(Updated Sept. 30, 2012, 8:55 p.m.)
Review request for hive.
Changes
-------
add test
Description
-------
Please see jira for detailed description
This addresses bug HIVE-3495.
https://issues.apache.org/jira/browse/HIVE-3495
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 3f2aaaa
ql/src/test/queries/clientpositive/udaf_percentile_approx.q c436a63
ql/src/test/results/clientpositive/count.q.out 61e54c7
ql/src/test/results/clientpositive/nullgroup.q.out 434fa6c
ql/src/test/results/clientpositive/nullgroup2.q.out aa52d62
ql/src/test/results/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
ql/src/test/results/clientpositive/udaf_percentile_approx.q.out 4f85a82
Diff: https://reviews.apache.org/r/7221/diff/
Testing
-------
All tests pass.
Thanks,
Yin Huai
Re: Review Request: HIVE-3495: For UDAFs,
when generating a plan without map-side-aggregation,
constant agg parameters will be replaced by ExprNodeColumnDesc
Posted by Yin Huai <hu...@cse.ohio-state.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7221/
-----------------------------------------------------------
(Updated Sept. 27, 2012, 1:12 a.m.)
Review request for hive.
Summary (updated)
-----------------
HIVE-3495: For UDAFs, when generating a plan without map-side-aggregation, constant agg parameters will be replaced by ExprNodeColumnDesc
Description
-------
Please see jira for detailed description
This addresses bug HIVE-3495.
https://issues.apache.org/jira/browse/HIVE-3495
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 33ce6ca
ql/src/test/results/clientpositive/count.q.out 61e54c7
ql/src/test/results/clientpositive/nullgroup.q.out 434fa6c
ql/src/test/results/clientpositive/nullgroup2.q.out aa52d62
ql/src/test/results/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
Diff: https://reviews.apache.org/r/7221/diff/
Testing
-------
All tests pass.
Thanks,
Yin Huai
Re: Review Request: HIVE-3495: For UDFAs,
when generating a plan without map-side-aggregation,
constant agg parameters will be replaced by ExprNodeColumnDesc
Posted by Yin Huai <hu...@cse.ohio-state.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7221/
-----------------------------------------------------------
(Updated Sept. 26, 2012, 3:35 p.m.)
Review request for hive.
Summary (updated)
-----------------
HIVE-3495: For UDFAs, when generating a plan without map-side-aggregation, constant agg parameters will be replaced by ExprNodeColumnDesc
Description
-------
Please see jira for detailed description
This addresses bug HIVE-3495.
https://issues.apache.org/jira/browse/HIVE-3495
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 33ce6ca
ql/src/test/results/clientpositive/count.q.out 61e54c7
ql/src/test/results/clientpositive/nullgroup.q.out 434fa6c
ql/src/test/results/clientpositive/nullgroup2.q.out aa52d62
ql/src/test/results/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
Diff: https://reviews.apache.org/r/7221/diff/
Testing
-------
All tests pass.
Thanks,
Yin Huai
Re: Review Request: For UDFAs,
when generating a plan without map-side-aggregation,
constant agg parameters will be replaced by ExprNodeColumnDesc
Posted by Yin Huai <hu...@cse.ohio-state.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7221/
-----------------------------------------------------------
(Updated Sept. 26, 2012, 3:34 p.m.)
Review request for hive.
Summary (updated)
-----------------
For UDFAs, when generating a plan without map-side-aggregation, constant agg parameters will be replaced by ExprNodeColumnDesc
Description
-------
Please see jira for detailed description
This addresses bug HIVE-3495.
https://issues.apache.org/jira/browse/HIVE-3495
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 33ce6ca
ql/src/test/results/clientpositive/count.q.out 61e54c7
ql/src/test/results/clientpositive/nullgroup.q.out 434fa6c
ql/src/test/results/clientpositive/nullgroup2.q.out aa52d62
ql/src/test/results/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
Diff: https://reviews.apache.org/r/7221/diff/
Testing (updated)
-------
All tests pass.
Thanks,
Yin Huai