You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "dcapwell (via GitHub)" <gi...@apache.org> on 2023/09/29 22:07:44 UTC
[GitHub] [cassandra-accord] dcapwell opened a new pull request, #68: CASSANDRA-18816: backport changes from repair patch
dcapwell opened a new pull request, #68:
URL: https://github.com/apache/cassandra-accord/pull/68
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-accord] dcapwell commented on a diff in pull request #68: CASSANDRA-18816: backport changes from repair patch
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #68:
URL: https://github.com/apache/cassandra-accord/pull/68#discussion_r1341827839
##########
accord-core/src/main/java/accord/utils/DefaultRandom.java:
##########
@@ -20,25 +20,20 @@
import java.util.Random;
-public class DefaultRandom extends Random implements RandomSource
+public class DefaultRandom extends WrappedRandomSource
Review Comment:
needed for jdk17 support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-accord] dcapwell commented on a diff in pull request #68: CASSANDRA-18816: backport changes from repair patch
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #68:
URL: https://github.com/apache/cassandra-accord/pull/68#discussion_r1341828715
##########
accord-core/src/test/java/accord/burn/random/FrequentLargeRangeTest.java:
##########
@@ -30,7 +30,7 @@
import static accord.utils.Property.qt;
-class SegmentedRandomRangeTest
+class FrequentLargeRangeTest
Review Comment:
looks like I forgot to rename this class when I renamed `SegmentedRandomRange ` to `FrequentLargeRange`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-accord] dcapwell merged pull request #68: CASSANDRA-18816: backport changes from repair patch
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell merged PR #68:
URL: https://github.com/apache/cassandra-accord/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-accord] dcapwell commented on a diff in pull request #68: CASSANDRA-18816: backport changes from repair patch
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #68:
URL: https://github.com/apache/cassandra-accord/pull/68#discussion_r1341827839
##########
accord-core/src/main/java/accord/utils/DefaultRandom.java:
##########
@@ -20,25 +20,20 @@
import java.util.Random;
-public class DefaultRandom extends Random implements RandomSource
+public class DefaultRandom extends WrappedRandomSource
Review Comment:
needed for jdk17 support as `Random` conflicts with methods in `RandomSource`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org