You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "seawinde (via GitHub)" <gi...@apache.org> on 2025/11/05 14:29:45 UTC
[PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
seawinde opened a new pull request, #57741:
URL: https://github.com/apache/doris/pull/57741
### What problem does this PR solve?
Fix query rewrite by mv fail when both use cte and group sets
Such as mv def is as following:
```sql
select l_shipdate, o_orderdate, l_partkey, l_suppkey,
sum(o_totalprice) as sum_total,
max(o_totalprice) as max_total,
min(o_totalprice) as min_total,
count(*) as count_all,
bitmap_union(to_bitmap(case when o_shippriority > 1 and o_orderkey IN (1, 3) then o_custkey else null end)) as bitmap_union_basic
from lineitem
left join orders on lineitem.l_orderkey = orders.o_orderkey and l_shipdate = o_orderdate
group by
l_shipdate,
o_orderdate,
l_partkey,
l_suppkey;
```
query is as fllowing, use both group sets and cte, would rewrite fail, the pr fix this
```sql
with t as (
select t1.l_partkey, t1.l_suppkey, o_orderdate,
grouping(t1.l_suppkey),
grouping(o_orderdate),
grouping_id(t1.l_partkey, t1.l_suppkey),
grouping_id(t1.l_partkey, t1.l_suppkey, o_orderdate),
sum(o_totalprice),
max(o_totalprice),
min(o_totalprice),
count(*),
count(distinct case when o_shippriority > 1 and o_orderkey IN (1, 3) then o_custkey else null end)
from (select * from lineitem where l_shipdate = '2023-12-11') t1
left join orders on t1.l_orderkey = orders.o_orderkey and t1.l_shipdate = o_orderdate
group by
GROUPING SETS ((l_shipdate, o_orderdate, l_partkey), (l_partkey, l_suppkey), (l_suppkey), ())
)
select t1.l_suppkey, t2.o_orderdate
from
t t1
inner join
t t2 on t1.l_partkey = t2.l_partkey;
```
Issue Number: close #xxx
Related PR: #36056
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3644755402
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3510869846
<details>
<summary>ClickBench: <b>Total hot run time: 27.42 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0e86ad0c0e49865d18f26b176c15dc8197a754ad, data reload: false
query1 0.06 0.05 0.06
query2 0.10 0.05 0.05
query3 0.25 0.08 0.09
query4 1.61 0.12 0.12
query5 0.27 0.25 0.27
query6 1.14 0.65 0.65
query7 0.03 0.02 0.02
query8 0.05 0.04 0.04
query9 0.62 0.53 0.52
query10 0.58 0.57 0.57
query11 0.17 0.12 0.11
query12 0.16 0.12 0.12
query13 0.63 0.62 0.61
query14 1.01 0.99 1.01
query15 0.86 0.84 0.85
query16 0.40 0.40 0.38
query17 0.99 1.04 1.06
query18 0.22 0.20 0.19
query19 1.92 1.78 1.79
query20 0.02 0.01 0.01
query21 15.44 0.19 0.13
query22 5.08 0.06 0.05
query23 15.65 0.26 0.10
query24 2.82 0.62 0.27
query25 0.06 0.06 0.07
query26 0.14 0.13 0.13
query27 0.07 0.07 0.05
query28 4.26 1.14 0.95
query29 12.60 3.90 3.18
query30 0.28 0.13 0.12
query31 2.82 0.61 0.39
query32 3.23 0.57 0.47
query33 3.11 3.12 3.13
query34 15.87 5.19 4.59
query35 4.56 4.55 4.61
query36 0.68 0.50 0.49
query37 0.10 0.07 0.06
query38 0.06 0.04 0.04
query39 0.04 0.03 0.03
query40 0.18 0.15 0.13
query41 0.08 0.03 0.04
query42 0.04 0.03 0.02
query43 0.04 0.04 0.04
Total cold run time: 98.3 s
Total hot run time: 27.42 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3492017770
<details>
<summary>TPC-DS: <b>Total hot run time: 189866 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b9afd1a1acb18ac51a93c506c37d29531cc958dd, data reload: false
query1 1053 412 397 397
query2 6577 1711 1687 1687
query3 6749 222 223 222
query4 26651 23597 23363 23363
query5 4936 668 492 492
query6 342 250 257 250
query7 4655 506 301 301
query8 321 282 262 262
query9 8739 2602 2590 2590
query10 511 350 300 300
query11 15622 15178 14897 14897
query12 193 122 117 117
query13 1694 577 442 442
query14 12569 9402 9466 9402
query15 208 194 186 186
query16 7685 715 491 491
query17 1614 809 666 666
query18 2129 458 368 368
query19 229 230 195 195
query20 149 147 144 144
query21 212 160 131 131
query22 4691 4678 4565 4565
query23 35034 33669 34373 33669
query24 8290 2601 2589 2589
query25 593 564 463 463
query26 1324 287 177 177
query27 2970 522 346 346
query28 4392 2224 2213 2213
query29 862 662 543 543
query30 297 229 202 202
query31 960 852 798 798
query32 87 78 78 78
query33 613 419 355 355
query34 832 891 552 552
query35 854 912 787 787
query36 1008 1060 962 962
query37 144 115 92 92
query38 3604 3572 3486 3486
query39 1481 1418 1431 1418
query40 221 122 117 117
query41 59 58 55 55
query42 116 110 110 110
query43 491 504 465 465
query44 1243 758 747 747
query45 184 175 171 171
query46 879 1005 659 659
query47 1727 1779 1727 1727
query48 393 428 318 318
query49 763 527 395 395
query50 641 690 406 406
query51 3922 3913 3876 3876
query52 109 110 100 100
query53 237 275 197 197
query54 305 285 269 269
query55 91 84 79 79
query56 324 304 318 304
query57 1172 1188 1119 1119
query58 280 277 272 272
query59 2528 2643 2519 2519
query60 355 348 317 317
query61 161 163 160 160
query62 781 728 665 665
query63 230 198 200 198
query64 4470 1172 862 862
query65 4042 3963 3939 3939
query66 1093 455 333 333
query67 15434 15217 15013 15013
query68 8511 957 597 597
query69 490 326 299 299
query70 1357 1295 1357 1295
query71 508 351 313 313
query72 5885 4918 4365 4365
query73 698 622 367 367
query74 8834 9188 8981 8981
query75 4065 3388 2885 2885
query76 3821 1149 784 784
query77 823 414 302 302
query78 9471 9938 8985 8985
query79 2381 821 589 589
query80 669 560 508 508
query81 502 262 225 225
query82 428 171 133 133
query83 286 272 251 251
query84 297 116 94 94
query85 912 474 440 440
query86 335 324 308 308
query87 3675 3710 3657 3657
query88 3508 2278 2256 2256
query89 390 322 295 295
query90 2022 223 223 223
query91 178 173 134 134
query92 81 67 71 67
query93 1640 978 641 641
query94 696 449 343 343
query95 409 325 303 303
query96 493 567 283 283
query97 2967 2973 2876 2876
query98 247 213 213 213
query99 1434 1435 1264 1264
Total cold run time: 281138 ms
Total hot run time: 189866 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3491535458
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3547277756
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3510841445
<details>
<summary>TPC-DS: <b>Total hot run time: 187838 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0e86ad0c0e49865d18f26b176c15dc8197a754ad, data reload: false
query1 1054 404 407 404
query2 6617 1717 1734 1717
query3 6759 228 219 219
query4 27000 23791 22967 22967
query5 4372 627 471 471
query6 322 244 215 215
query7 4646 500 291 291
query8 305 250 240 240
query9 8713 2586 2539 2539
query10 489 325 289 289
query11 16083 15107 15309 15107
query12 192 122 114 114
query13 1669 562 463 463
query14 11220 9253 9336 9253
query15 202 188 169 169
query16 7656 682 527 527
query17 1206 757 604 604
query18 2027 412 324 324
query19 215 210 185 185
query20 130 158 122 122
query21 213 129 111 111
query22 3882 4157 3998 3998
query23 33977 33197 33044 33044
query24 8468 2432 2384 2384
query25 588 532 436 436
query26 1241 270 165 165
query27 2737 503 363 363
query28 4418 2199 2156 2156
query29 814 622 481 481
query30 312 230 200 200
query31 942 825 742 742
query32 81 79 75 75
query33 629 370 337 337
query34 803 859 526 526
query35 818 867 754 754
query36 948 1002 897 897
query37 119 109 92 92
query38 3561 3556 3486 3486
query39 1487 1426 1437 1426
query40 232 128 124 124
query41 65 59 61 59
query42 126 114 111 111
query43 477 491 476 476
query44 1236 752 721 721
query45 189 185 175 175
query46 877 1009 634 634
query47 1731 1797 1704 1704
query48 384 422 308 308
query49 782 511 432 432
query50 651 681 421 421
query51 3915 4078 3941 3941
query52 109 113 109 109
query53 245 273 201 201
query54 304 300 285 285
query55 87 87 86 86
query56 344 325 337 325
query57 1170 1191 1132 1132
query58 289 296 275 275
query59 2596 2763 2490 2490
query60 370 361 342 342
query61 195 185 193 185
query62 817 742 683 683
query63 229 199 202 199
query64 4587 1282 960 960
query65 4058 3959 3972 3959
query66 1107 456 366 366
query67 15298 15022 14886 14886
query68 6719 935 611 611
query69 501 333 302 302
query70 1332 1374 1228 1228
query71 438 334 330 330
query72 6079 5046 4830 4830
query73 642 580 359 359
query74 8935 8811 9047 8811
query75 3330 3328 2835 2835
query76 3266 1172 748 748
query77 522 408 307 307
query78 9566 9678 8818 8818
query79 2297 838 627 627
query80 648 579 489 489
query81 499 259 221 221
query82 460 161 138 138
query83 270 264 253 253
query84 260 109 97 97
query85 931 476 434 434
query86 388 316 301 301
query87 3680 3739 3679 3679
query88 3732 2222 2231 2222
query89 395 327 288 288
query90 1921 222 215 215
query91 166 174 132 132
query92 84 68 66 66
query93 1867 991 644 644
query94 762 453 336 336
query95 408 330 325 325
query96 487 571 285 285
query97 2945 2943 2917 2917
query98 250 213 214 213
query99 1668 1447 1295 1295
Total cold run time: 274833 ms
Total hot run time: 187838 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3520334254
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3552016504
<details>
<summary>TPC-H: <b>Total hot run time: 34873 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 198e36a697434bf1a3c60c1bedb5a850160b0146, data reload: false
------ Round 1 ----------------------------------
q1 17636 5041 4902 4902
q2 2003 312 200 200
q3 10272 1275 732 732
q4 10396 932 371 371
q5 7550 2507 2330 2330
q6 187 181 139 139
q7 950 770 630 630
q8 9354 1337 1136 1136
q9 7098 5284 5327 5284
q10 6853 2217 1784 1784
q11 492 298 285 285
q12 352 358 233 233
q13 17773 3606 3046 3046
q14 227 237 215 215
q15 580 516 500 500
q16 992 982 938 938
q17 577 855 367 367
q18 7470 7534 7705 7534
q19 1204 989 565 565
q20 365 351 232 232
q21 3996 3340 2421 2421
q22 1159 1149 1029 1029
Total cold run time: 107486 ms
Total hot run time: 34873 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5214 5120 5280 5120
q2 336 412 328 328
q3 2375 2802 2437 2437
q4 1463 1888 1410 1410
q5 4617 4490 4650 4490
q6 214 162 128 128
q7 1990 1852 1826 1826
q8 2856 2614 2511 2511
q9 7466 7528 7656 7528
q10 2969 3087 2658 2658
q11 560 499 484 484
q12 637 715 589 589
q13 3218 3620 3056 3056
q14 279 277 262 262
q15 540 490 489 489
q16 1024 1060 1001 1001
q17 1096 1502 1303 1303
q18 7306 7191 7180 7180
q19 785 799 843 799
q20 1914 1992 1800 1800
q21 4632 4307 4573 4307
q22 1057 1047 1029 1029
Total cold run time: 52548 ms
Total hot run time: 50735 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3553929853
# FE Regression Coverage Report
Increment line coverage ` 88.75% (71/80)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_198e36a697434bf1a3c60c1bedb5a850160b0146_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_198e36a697434bf1a3c60c1bedb5a850160b0146_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3520499268
<details>
<summary>TPC-DS: <b>Total hot run time: 188110 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21519fdcaa30ab55a166f0421cff748c0ee19c89, data reload: false
query1 1030 414 397 397
query2 6571 1679 1726 1679
query3 6752 230 218 218
query4 26942 23324 23290 23290
query5 4437 652 478 478
query6 341 249 230 230
query7 4646 512 302 302
query8 322 282 261 261
query9 8698 2606 2621 2606
query10 490 319 288 288
query11 15305 15093 14975 14975
query12 172 118 111 111
query13 1677 558 448 448
query14 10453 9423 9354 9354
query15 207 188 177 177
query16 7312 663 499 499
query17 1236 748 620 620
query18 1987 419 321 321
query19 241 205 179 179
query20 138 130 128 128
query21 214 138 112 112
query22 3961 4209 3913 3913
query23 33924 32934 32988 32934
query24 8429 2436 2452 2436
query25 598 529 444 444
query26 1240 273 161 161
query27 2745 495 350 350
query28 4392 2198 2181 2181
query29 881 603 482 482
query30 299 231 204 204
query31 880 808 750 750
query32 88 75 71 71
query33 601 375 334 334
query34 812 839 520 520
query35 805 878 765 765
query36 968 996 874 874
query37 120 113 89 89
query38 3563 3504 3426 3426
query39 1484 1432 1427 1427
query40 225 132 123 123
query41 63 60 61 60
query42 126 115 121 115
query43 492 516 491 491
query44 1287 750 756 750
query45 191 179 179 179
query46 881 999 658 658
query47 1734 1808 1688 1688
query48 401 434 329 329
query49 767 509 414 414
query50 680 689 407 407
query51 3909 3933 3961 3933
query52 107 110 101 101
query53 238 274 198 198
query54 317 315 276 276
query55 89 85 88 85
query56 321 316 321 316
query57 1201 1169 1112 1112
query58 292 282 285 282
query59 2527 2751 2547 2547
query60 366 388 349 349
query61 207 190 185 185
query62 811 737 677 677
query63 236 201 204 201
query64 4647 1267 962 962
query65 4051 3925 3984 3925
query66 1209 457 350 350
query67 15442 14929 14844 14844
query68 8181 940 594 594
query69 505 338 302 302
query70 1319 1227 1256 1227
query71 464 349 310 310
query72 6103 4886 4868 4868
query73 633 599 354 354
query74 8818 9100 8869 8869
query75 3558 3323 2863 2863
query76 3385 1198 784 784
query77 585 403 327 327
query78 9504 9742 8905 8905
query79 2793 834 615 615
query80 690 574 524 524
query81 498 263 232 232
query82 474 161 134 134
query83 270 271 255 255
query84 251 109 93 93
query85 959 485 432 432
query86 381 321 317 317
query87 3760 3796 3620 3620
query88 3938 2263 2242 2242
query89 403 322 289 289
query90 1887 226 229 226
query91 164 168 134 134
query92 86 74 68 68
query93 2579 1001 642 642
query94 721 419 356 356
query95 416 328 310 310
query96 489 600 281 281
query97 2873 2958 2861 2861
query98 251 221 206 206
query99 1335 1418 1279 1279
Total cold run time: 276051 ms
Total hot run time: 188110 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3491533671
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3540783050
<details>
<summary>ClickBench: <b>Total hot run time: 27.87 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9e134f235d6ede1eb9c735abc53f133d2a127c23, data reload: false
query1 0.06 0.04 0.05
query2 0.09 0.05 0.05
query3 0.26 0.08 0.09
query4 1.60 0.11 0.11
query5 0.27 0.24 0.25
query6 1.15 0.64 0.64
query7 0.04 0.03 0.03
query8 0.05 0.04 0.04
query9 0.57 0.52 0.52
query10 0.57 0.58 0.56
query11 0.16 0.12 0.11
query12 0.15 0.12 0.12
query13 0.61 0.60 0.60
query14 1.01 1.01 1.00
query15 0.84 0.84 0.83
query16 0.38 0.39 0.39
query17 1.02 1.08 1.03
query18 0.21 0.20 0.20
query19 1.85 1.85 1.76
query20 0.02 0.01 0.01
query21 15.49 0.18 0.13
query22 5.07 0.07 0.05
query23 15.66 0.27 0.09
query24 2.38 1.02 0.83
query25 0.06 0.06 0.06
query26 0.15 0.13 0.12
query27 0.05 0.06 0.06
query28 5.03 1.21 0.96
query29 12.62 3.92 3.27
query30 0.31 0.13 0.11
query31 2.82 0.59 0.37
query32 3.22 0.54 0.48
query33 3.09 3.04 3.15
query34 15.75 5.20 4.52
query35 4.56 4.60 4.60
query36 0.66 0.50 0.49
query37 0.10 0.06 0.06
query38 0.06 0.04 0.04
query39 0.03 0.02 0.03
query40 0.16 0.13 0.14
query41 0.08 0.04 0.03
query42 0.04 0.03 0.02
query43 0.04 0.04 0.03
Total cold run time: 98.34 s
Total hot run time: 27.87 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3491929837
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/5)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_b9afd1a1acb18ac51a93c506c37d29531cc958dd/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_b9afd1a1acb18ac51a93c506c37d29531cc958dd/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3556595957
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3552059536
<details>
<summary>TPC-DS: <b>Total hot run time: 187765 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 198e36a697434bf1a3c60c1bedb5a850160b0146, data reload: false
query1 1021 404 421 404
query2 6550 1705 1666 1666
query3 6741 235 235 235
query4 26504 23110 22585 22585
query5 4474 639 507 507
query6 332 244 232 232
query7 4655 493 303 303
query8 295 258 268 258
query9 8656 2922 2897 2897
query10 505 368 321 321
query11 15815 14984 14786 14786
query12 178 126 118 118
query13 1688 594 465 465
query14 11109 9271 9134 9134
query15 199 196 174 174
query16 7529 646 500 500
query17 1244 781 643 643
query18 2035 437 342 342
query19 219 211 186 186
query20 134 132 128 128
query21 220 134 117 117
query22 4164 4391 4177 4177
query23 33842 33184 33061 33061
query24 8112 2419 2394 2394
query25 646 557 496 496
query26 1251 277 171 171
query27 2728 512 367 367
query28 4382 2238 2245 2238
query29 829 645 520 520
query30 299 228 196 196
query31 898 813 736 736
query32 95 85 80 80
query33 607 402 354 354
query34 797 867 519 519
query35 851 825 762 762
query36 960 1015 892 892
query37 128 113 93 93
query38 3567 3496 3491 3491
query39 1462 1441 1398 1398
query40 228 132 127 127
query41 61 60 59 59
query42 129 114 113 113
query43 476 478 460 460
query44 1258 790 800 790
query45 189 183 168 168
query46 888 981 635 635
query47 1787 1816 1733 1733
query48 395 433 325 325
query49 763 500 411 411
query50 652 689 420 420
query51 3910 3971 3899 3899
query52 119 117 112 112
query53 247 275 202 202
query54 331 310 296 296
query55 97 97 90 90
query56 358 335 335 335
query57 1200 1206 1090 1090
query58 301 283 289 283
query59 2588 2565 2555 2555
query60 404 354 349 349
query61 163 160 154 154
query62 806 722 642 642
query63 227 209 201 201
query64 4433 1142 860 860
query65 4011 3950 3960 3950
query66 1161 448 366 366
query67 15204 15219 14906 14906
query68 8354 946 637 637
query69 498 333 308 308
query70 1337 1255 1274 1255
query71 479 356 330 330
query72 5948 4735 4889 4735
query73 703 588 368 368
query74 9229 9079 8829 8829
query75 3909 3209 2817 2817
query76 3695 1150 727 727
query77 806 404 339 339
query78 9502 9665 8908 8908
query79 2251 835 599 599
query80 656 594 522 522
query81 510 254 227 227
query82 219 161 143 143
query83 268 260 268 260
query84 252 118 96 96
query85 892 486 438 438
query86 393 309 300 300
query87 3664 3713 3569 3569
query88 3637 2228 2252 2228
query89 393 319 284 284
query90 1969 234 224 224
query91 165 161 133 133
query92 91 77 74 74
query93 1826 1011 686 686
query94 670 421 316 316
query95 420 335 323 323
query96 486 569 279 279
query97 2893 2961 2858 2858
query98 256 222 219 219
query99 1296 1386 1257 1257
Total cold run time: 275774 ms
Total hot run time: 187765 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3552152999
# FE UT Coverage Report
Increment line coverage ` 61.25% (49/80)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_198e36a697434bf1a3c60c1bedb5a850160b0146/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_198e36a697434bf1a3c60c1bedb5a850160b0146/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3641329842
# FE Regression Coverage Report
Increment line coverage ` 85.00% (17/20)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_571a11da70eec16f397b9d1429a7dc1380442d8d_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_571a11da70eec16f397b9d1429a7dc1380442d8d_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3492682652
# FE Regression Coverage Report
Increment line coverage ` 100.00% (5/5)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_b9afd1a1acb18ac51a93c506c37d29531cc958dd_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_b9afd1a1acb18ac51a93c506c37d29531cc958dd_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3631117297
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3626628899
<details>
<summary>ClickBench: <b>Total hot run time: 27.15 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 86ffb4edfd6d27f6eeddc9669c152b446cbb8a48, data reload: false
query1 0.04 0.05 0.04
query2 0.10 0.05 0.05
query3 0.26 0.09 0.08
query4 1.60 0.11 0.11
query5 0.27 0.25 0.25
query6 1.16 0.63 0.64
query7 0.03 0.03 0.03
query8 0.05 0.05 0.04
query9 0.56 0.52 0.49
query10 0.56 0.55 0.56
query11 0.14 0.11 0.12
query12 0.16 0.12 0.12
query13 0.63 0.61 0.59
query14 0.98 0.98 0.99
query15 0.82 0.80 0.82
query16 0.42 0.40 0.40
query17 1.07 1.05 1.09
query18 0.23 0.22 0.21
query19 1.95 1.71 1.77
query20 0.01 0.02 0.01
query21 15.45 0.29 0.14
query22 4.89 0.05 0.04
query23 15.97 0.28 0.10
query24 1.81 0.62 0.25
query25 0.05 0.06 0.05
query26 0.14 0.13 0.14
query27 0.06 0.05 0.05
query28 3.74 1.29 1.03
query29 12.61 4.04 3.14
query30 0.28 0.13 0.11
query31 2.83 0.65 0.39
query32 3.23 0.57 0.46
query33 3.03 3.14 3.10
query34 16.94 5.38 4.54
query35 4.53 4.52 4.55
query36 0.66 0.50 0.49
query37 0.11 0.06 0.06
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.14 0.14
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.05 0.03 0.03
Total cold run time: 97.83 s
Total hot run time: 27.15 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #57741:
URL: https://github.com/apache/doris/pull/57741#discussion_r2522712222
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/MaterializedViewExprReplacer.java:
##########
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.exploration.mv;
+
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.nereids.trees.expressions.VirtualSlotReference;
+import org.apache.doris.nereids.trees.expressions.functions.scalar.GroupingScalarFunction;
+import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.algebra.Repeat;
+import org.apache.doris.nereids.util.ExpressionUtils;
+
+import java.util.ArrayList;
+import java.util.BitSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * Expression replacer which support to handle VirtualSlotReference, if replaceMap contained, just use it
+ */
+public class MaterializedViewExprReplacer extends DefaultExpressionRewriter<Void> {
+
+ private final Map<? extends Expression, ? extends Expression> replaceMap;
+ private final Plan queryTopPlan;
+ private final BitSet sourcePlanBitSet;
+ private boolean valid = true;
+
+ public MaterializedViewExprReplacer(
+ Map<? extends Expression, ? extends Expression> replaceMap,
+ Plan queryTopPlan,
+ BitSet sourcePlanBitSet) {
+ this.replaceMap = replaceMap;
+ this.queryTopPlan = queryTopPlan;
+ this.sourcePlanBitSet = sourcePlanBitSet;
+ }
+
+ public boolean isValid() {
+ return valid;
+ }
+
+ @Override
+ public Expression visit(Expression expr, Void context) {
+ if (!valid) {
+ return expr;
+ }
+ Expression replacedExpr = replaceMap.get(expr);
+ if (replacedExpr != null) {
+ return replacedExpr;
+ }
+ List<Expression> newChildren = new ArrayList<>();
+ boolean hasChanged = false;
+ for (Expression child : expr.children()) {
+ Expression newChild = child.accept(this, context);
+ if (!valid) {
+ return expr;
+ }
+ if (newChild != child) {
+ hasChanged = true;
+ }
+ newChildren.add(newChild);
+ }
+ return hasChanged ? expr.withChildren(newChildren) : expr;
+ }
+
+ @Override
+ public Expression visitSlot(Slot slot, Void context) {
+ if (!valid) {
+ return slot;
+ }
+ if (slot instanceof VirtualSlotReference) {
+ return handleVirtualSlot((VirtualSlotReference) slot, context);
+ }
+ Expression replacedExpr = replaceMap.get(slot);
+ if (replacedExpr != null) {
+ return replacedExpr;
+ }
+ valid = false;
+ return slot;
+ }
+
Review Comment:
Missing JavaDoc for the `handleVirtualSlot` method. This is a critical method that implements the core logic for handling VirtualSlotReference. It should document:
- The purpose of the method
- What happens when originExpression is not present vs. present
- The role of `shuttleExpressionWithLineage` in the context
- Return value semantics
Suggested addition:
```java
/**
* Handles VirtualSlotReference replacement for grouping sets.
*
* @param virtualSlot the VirtualSlotReference to handle
* @param context the rewrite context (currently unused)
* @return a new VirtualSlotReference with the grouping function replaced according to the replaceMap,
* or a virtual grouping ID slot if no origin expression exists
*/
```
```suggestion
/**
* Handles VirtualSlotReference replacement for grouping sets.
* <p>
* If the VirtualSlotReference has an origin grouping function, rewrites it using lineage information
* and returns a new virtual slot based on the rewritten function. If no origin expression exists,
* returns a virtual grouping ID slot.
* <p>
* The method uses {@code ExpressionUtils.shuttleExpressionWithLineage} to rewrite the grouping function
* according to the query plan and source plan bitset.
*
* @param virtualSlot the VirtualSlotReference to handle
* @param context the rewrite context (currently unused)
* @return a new VirtualSlotReference with the grouping function replaced according to the replaceMap,
* or a virtual grouping ID slot if no origin expression exists
*/
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/MaterializedViewExprReplacer.java:
##########
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.exploration.mv;
+
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.nereids.trees.expressions.VirtualSlotReference;
+import org.apache.doris.nereids.trees.expressions.functions.scalar.GroupingScalarFunction;
+import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.algebra.Repeat;
+import org.apache.doris.nereids.util.ExpressionUtils;
+
+import java.util.ArrayList;
+import java.util.BitSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * Expression replacer which support to handle VirtualSlotReference, if replaceMap contained, just use it
Review Comment:
The class-level documentation comment should be more descriptive. It should explain:
1. What problem this class solves (handling VirtualSlotReference in expression replacement for MV rewrite)
2. The context in which it's used (materialized view query rewriting with group sets/CTEs)
3. The key behaviors, especially the `valid` flag mechanism
Current comment: "Expression replacer which support to handle VirtualSlotReference, if replaceMap contained, just use it"
Suggested improvement:
```java
/**
* Expression replacer for materialized view query rewriting that handles VirtualSlotReference.
* This replacer is used when rewriting queries with GROUPING SETS and CTEs against materialized views.
*
* <p>For VirtualSlotReference (used in group sets with grouping functions), this replacer:
* - Uses the replaceMap if the VirtualSlotReference is contained
* - Otherwise, reconstructs the virtual slot by shuttling the origin GroupingScalarFunction
* through the query plan lineage and applying the replacement recursively
*
* <p>The replacer maintains a `valid` flag that becomes false if any expression cannot be
* successfully replaced, allowing callers to detect incomplete rewrites.
*/
```
```suggestion
* Expression replacer for materialized view query rewriting that handles VirtualSlotReference.
* This replacer is used when rewriting queries with GROUPING SETS and CTEs against materialized views.
*
* <p>For VirtualSlotReference (used in group sets with grouping functions), this replacer:
* - Uses the replaceMap if the VirtualSlotReference is contained
* - Otherwise, reconstructs the virtual slot by shuttling the origin GroupingScalarFunction
* through the query plan lineage and applying the replacement recursively
*
* <p>The replacer maintains a {@code valid} flag that becomes false if any expression cannot be
* successfully replaced, allowing callers to detect incomplete rewrites.
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewAggregateRule.java:
##########
@@ -765,6 +767,8 @@ public Expression visitSlot(Slot slot, AggregateExpressionRewriteContext rewrite
return Repeat.generateVirtualGroupingIdSlot();
} else {
GroupingScalarFunction groupingScalarFunction = originExpression.get();
Review Comment:
Missing explanation for why `shuttleExpressionWithLineage` is needed here. This code change adds lineage shuttling for the grouping scalar function before replacement, which is a key part of fixing the CTE + group sets issue.
Consider adding a comment:
```java
// Shuttle the grouping function through the query plan to resolve references
// correctly when CTEs are involved, ensuring proper slot mapping
groupingScalarFunction = (GroupingScalarFunction) ExpressionUtils.shuttleExpressionWithLineage(
groupingScalarFunction, rewriteContext.getQueryTopPlan(), new BitSet());
```
```suggestion
GroupingScalarFunction groupingScalarFunction = originExpression.get();
// Shuttle the grouping function through the query plan to resolve references
// correctly when CTEs are involved, ensuring proper slot mapping.
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewAggregateRule.java:
##########
@@ -244,7 +244,9 @@ protected LogicalAggregate<Plan> aggregateRewriteByView(
if (queryAggregate.getSourceRepeat().isPresent()) {
// construct group sets for repeat
List<List<Expression>> rewrittenGroupSetsExpressions = new ArrayList<>();
Review Comment:
This change modifies how grouping sets are retrieved for queries with CTEs. While the logic appears correct (preferring the actual LogicalRepeat node if found via collectFirst, then falling back to sourceRepeat), it lacks an explanatory comment about why this change is necessary.
Consider adding a comment explaining the issue this fixes:
```java
// When queries use both CTEs and group sets, the sourceRepeat may not reflect
// the actual LogicalRepeat node in the plan tree. Collect the LogicalRepeat directly
// from the plan to get the correct grouping sets, falling back to sourceRepeat if needed.
List<List<Expression>> groupingSets = queryAggregate.collectFirst(LogicalRepeat.class::isInstance)
.map(repeat -> ((LogicalRepeat<? extends Plan>) repeat).getGroupingSets())
.orElse(queryAggregate.getSourceRepeat().get().getGroupingSets());
```
This would help future maintainers understand the fix for the CTE + group sets issue mentioned in the PR description.
```suggestion
List<List<Expression>> rewrittenGroupSetsExpressions = new ArrayList<>();
// When queries use both CTEs and grouping sets, the sourceRepeat may not reflect
// the actual LogicalRepeat node in the plan tree. Collect the LogicalRepeat directly
// from the plan to get the correct grouping sets, falling back to sourceRepeat if needed.
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewRule.java:
##########
@@ -423,7 +422,7 @@ protected List<Plan> doRewrite(StructInfo queryStructInfo, CascadesContext casca
rewrittenPlanOutput, queryPlan.getOutput()));
continue;
}
- // Merge project
+ // Merge project if contains mult same project
Review Comment:
The comment on line 425 has a grammatical issue. It says "Merge project if contains mult same project" which should be "Merge project if it contains multiple identical projects" or similar.
Current: `// Merge project if contains mult same project`
Suggested: `// Merge project if it contains multiple identical projects`
```suggestion
// Merge project if it contains multiple identical projects
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewRule.java:
##########
@@ -641,11 +640,14 @@ protected List<Expression> rewriteExpression(List<? extends Expression> sourceEx
expressionShuttledToRewrite.collectToSet(expression -> expression instanceof SlotReference
&& ((SlotReference) expression).getDataType() instanceof VariantType);
extendMappingByVariant(variants, targetToTargetReplacementMappingQueryBased);
- Expression replacedExpression = ExpressionUtils.replace(expressionShuttledToRewrite,
- targetToTargetReplacementMappingQueryBased);
- Set<Expression> replacedExpressionSlotQueryUsed = replacedExpression.collect(slotsToRewrite::contains);
- if (!replacedExpressionSlotQueryUsed.isEmpty()) {
- // if contains any slot to rewrite, which means could not be rewritten by target,
+
+ MaterializedViewExprReplacer materializedViewExprReplacer = new MaterializedViewExprReplacer(
+ targetToTargetReplacementMappingQueryBased,
+ sourcePlan, sourcePlanBitSet);
+ Expression replacedExpression =
+ expressionShuttledToRewrite.accept(materializedViewExprReplacer, null);
+ if (!materializedViewExprReplacer.isValid()) {
+ // if contains any slot to rewrite, which means can not be rewritten by target,
Review Comment:
The comment on line 650 has a grammatical issue. "can not" should be "cannot" (single word) for proper grammar.
Current: `// if contains any slot to rewrite, which means can not be rewritten by target,`
Suggested: `// if contains any slot to rewrite, which means cannot be rewritten by target,`
```suggestion
// if contains any slot to rewrite, which means cannot be rewritten by target,
```
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPlanUtil.java:
##########
@@ -145,6 +145,7 @@ public static ConnectContext createBasicMvContext(@Nullable ConnectContext paren
ctx.getSessionVariable().skipStorageEngineMerge = false;
ctx.getSessionVariable().showHiddenColumns = false;
ctx.getSessionVariable().allowModifyMaterializedViewData = true;
Review Comment:
The addition of `skipPrunePredicate = true` lacks explanation in the code. While this change is necessary for the fix (based on the PR description), it's not clear why skipping predicate pruning is needed for materialized views.
Consider adding a comment explaining why this is necessary:
```java
// Skip predicate pruning to preserve all predicates needed for materialized view rewriting,
// especially when dealing with complex scenarios like CTEs and group sets
ctx.getSessionVariable().skipPrunePredicate = true;
```
This would help future maintainers understand the purpose of this setting.
```suggestion
ctx.getSessionVariable().allowModifyMaterializedViewData = true;
// Skip predicate pruning to preserve all predicates needed for materialized view rewriting,
// especially when dealing with complex scenarios like CTEs and group sets.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3525379518
# FE Regression Coverage Report
Increment line coverage ` 67.92% (36/53)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_ec2c64e6574924d17a2eb36be02c00560da7e6b4_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_ec2c64e6574924d17a2eb36be02c00560da7e6b4_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3524998774
<details>
<summary>ClickBench: <b>Total hot run time: 27.54 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ec2c64e6574924d17a2eb36be02c00560da7e6b4, data reload: false
query1 0.05 0.04 0.05
query2 0.09 0.05 0.05
query3 0.25 0.08 0.08
query4 1.61 0.11 0.12
query5 0.28 0.25 0.26
query6 1.20 0.65 0.63
query7 0.03 0.03 0.03
query8 0.06 0.04 0.04
query9 0.58 0.54 0.51
query10 0.59 0.58 0.57
query11 0.16 0.11 0.11
query12 0.15 0.12 0.12
query13 0.63 0.61 0.60
query14 1.00 0.99 1.00
query15 0.85 0.83 0.83
query16 0.40 0.41 0.38
query17 1.01 1.02 1.01
query18 0.22 0.19 0.20
query19 1.91 1.82 1.86
query20 0.02 0.01 0.01
query21 15.46 0.20 0.13
query22 5.07 0.07 0.05
query23 15.67 0.27 0.11
query24 2.49 0.81 0.44
query25 0.07 0.06 0.06
query26 0.15 0.15 0.13
query27 0.07 0.05 0.06
query28 4.60 1.14 0.93
query29 12.61 3.93 3.28
query30 0.29 0.14 0.12
query31 2.81 0.60 0.39
query32 3.23 0.55 0.47
query33 3.03 3.00 3.10
query34 15.85 5.16 4.60
query35 4.57 4.59 4.62
query36 0.68 0.50 0.48
query37 0.10 0.07 0.06
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.18 0.13 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.02
query43 0.04 0.03 0.03
Total cold run time: 98.3 s
Total hot run time: 27.54 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3540120101
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3524850634
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3547391981
<details>
<summary>TPC-H: <b>Total hot run time: 34560 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e4307566fbf75ee5bfe1cc7ab3aada29274347fe, data reload: false
------ Round 1 ----------------------------------
q1 17596 5020 4886 4886
q2 2073 312 203 203
q3 10213 1282 696 696
q4 10241 957 378 378
q5 7584 2436 2324 2324
q6 184 174 143 143
q7 980 763 626 626
q8 9351 1352 1169 1169
q9 6887 5025 5062 5025
q10 6892 2238 1796 1796
q11 507 300 290 290
q12 346 364 233 233
q13 17776 3601 3049 3049
q14 235 236 213 213
q15 585 518 507 507
q16 988 1002 932 932
q17 587 875 364 364
q18 7402 7426 7667 7426
q19 1494 1069 567 567
q20 368 391 237 237
q21 4031 3586 2458 2458
q22 1173 1067 1038 1038
Total cold run time: 107493 ms
Total hot run time: 34560 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5180 5143 5179 5143
q2 254 338 242 242
q3 2355 2935 2464 2464
q4 1432 1878 1446 1446
q5 4557 4535 4383 4383
q6 203 165 125 125
q7 2016 1930 1815 1815
q8 2608 2599 2537 2537
q9 7162 7249 6696 6696
q10 2886 3137 2717 2717
q11 563 505 479 479
q12 635 705 581 581
q13 3261 3670 3013 3013
q14 275 307 255 255
q15 525 482 479 479
q16 1007 1050 995 995
q17 1088 1469 1328 1328
q18 7367 7104 7120 7104
q19 751 757 814 757
q20 1923 2015 1784 1784
q21 4735 4483 4337 4337
q22 1065 1048 994 994
Total cold run time: 51848 ms
Total hot run time: 49674 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3634735907
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3500961727
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3496328317
<details>
<summary>TPC-DS: <b>Total hot run time: 189251 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e0a98933a05ff13d07b9e2c6d10eceec71935f34, data reload: false
query1 1050 411 413 411
query2 6581 1708 1719 1708
query3 6755 231 223 223
query4 26457 23726 23491 23491
query5 5768 640 463 463
query6 356 224 213 213
query7 4647 489 296 296
query8 301 247 243 243
query9 8704 2566 2573 2566
query10 535 338 289 289
query11 15719 15066 14838 14838
query12 182 116 110 110
query13 1677 546 425 425
query14 11426 9244 9270 9244
query15 203 195 172 172
query16 7646 645 536 536
query17 1600 760 653 653
query18 2606 442 334 334
query19 234 225 185 185
query20 137 129 133 129
query21 264 132 123 123
query22 4662 4552 4316 4316
query23 34402 33684 33833 33684
query24 8491 2506 2508 2506
query25 582 551 461 461
query26 1207 280 168 168
query27 2737 538 385 385
query28 4496 2235 2229 2229
query29 835 818 557 557
query30 314 226 199 199
query31 925 837 777 777
query32 85 77 72 72
query33 594 397 386 386
query34 839 884 564 564
query35 883 870 818 818
query36 1000 1066 947 947
query37 128 119 94 94
query38 3750 3629 3457 3457
query39 1473 1410 1407 1407
query40 217 128 123 123
query41 65 61 64 61
query42 123 115 118 115
query43 478 485 466 466
query44 1210 750 746 746
query45 190 179 178 178
query46 883 999 640 640
query47 1740 1757 1704 1704
query48 401 423 325 325
query49 749 509 429 429
query50 633 691 396 396
query51 3959 3894 3935 3894
query52 107 105 98 98
query53 246 273 200 200
query54 319 298 280 280
query55 88 97 89 89
query56 331 317 335 317
query57 1183 1161 1119 1119
query58 298 291 281 281
query59 2597 2650 2541 2541
query60 360 355 351 351
query61 191 187 188 187
query62 787 754 657 657
query63 228 197 194 194
query64 3881 1164 855 855
query65 4009 3956 3963 3956
query66 910 420 351 351
query67 15540 15284 14910 14910
query68 8634 925 580 580
query69 523 318 279 279
query70 1323 1242 1288 1242
query71 526 334 308 308
query72 6043 4956 4877 4877
query73 695 585 353 353
query74 8948 9143 8757 8757
query75 4248 3372 2821 2821
query76 3825 1145 728 728
query77 811 411 322 322
query78 9540 9717 8810 8810
query79 2376 856 607 607
query80 644 567 508 508
query81 495 258 233 233
query82 426 163 126 126
query83 301 262 249 249
query84 301 120 104 104
query85 869 468 433 433
query86 335 325 304 304
query87 3748 3729 3618 3618
query88 3394 2261 2237 2237
query89 402 322 301 301
query90 2052 229 226 226
query91 160 168 134 134
query92 83 67 67 67
query93 1559 971 643 643
query94 684 450 335 335
query95 383 325 317 317
query96 486 577 283 283
query97 2945 2962 2849 2849
query98 251 211 208 208
query99 1440 1383 1250 1250
Total cold run time: 280424 ms
Total hot run time: 189251 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3496359127
<details>
<summary>ClickBench: <b>Total hot run time: 27.7 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e0a98933a05ff13d07b9e2c6d10eceec71935f34, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.05 0.05
query3 0.25 0.08 0.08
query4 1.61 0.12 0.11
query5 0.28 0.26 0.25
query6 1.16 0.65 0.64
query7 0.03 0.02 0.02
query8 0.05 0.04 0.04
query9 0.60 0.53 0.51
query10 0.59 0.58 0.57
query11 0.17 0.11 0.11
query12 0.15 0.11 0.12
query13 0.61 0.60 0.60
query14 1.01 1.01 1.01
query15 0.85 0.83 0.84
query16 0.39 0.40 0.41
query17 0.99 1.03 1.03
query18 0.25 0.20 0.20
query19 1.91 1.87 1.80
query20 0.02 0.02 0.02
query21 15.43 0.18 0.13
query22 5.05 0.07 0.04
query23 15.66 0.27 0.10
query24 2.98 0.70 0.67
query25 0.07 0.07 0.06
query26 0.14 0.12 0.14
query27 0.06 0.05 0.05
query28 4.62 1.13 0.93
query29 12.60 4.00 3.26
query30 0.28 0.13 0.13
query31 2.82 0.59 0.39
query32 3.23 0.54 0.47
query33 3.10 3.01 3.04
query34 15.90 5.22 4.53
query35 4.60 4.57 4.53
query36 0.68 0.50 0.49
query37 0.09 0.06 0.06
query38 0.06 0.04 0.04
query39 0.04 0.03 0.03
query40 0.18 0.15 0.14
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 98.82 s
Total hot run time: 27.7 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3501079694
<details>
<summary>TPC-DS: <b>Total hot run time: 189104 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e0b271fff88a83c5575bbb0a5b9c4c50122e2ddc, data reload: false
query1 1325 403 397 397
query2 6649 1657 1646 1646
query3 6851 231 218 218
query4 25954 23403 23132 23132
query5 5028 654 469 469
query6 347 245 228 228
query7 4675 488 294 294
query8 308 265 257 257
query9 8746 2567 2647 2567
query10 519 353 303 303
query11 16534 16097 15721 15721
query12 195 123 128 123
query13 2055 571 470 470
query14 12922 9552 9429 9429
query15 241 192 175 175
query16 8693 687 567 567
query17 1622 753 640 640
query18 2096 422 325 325
query19 268 197 194 194
query20 132 126 126 126
query21 570 130 115 115
query22 4636 4836 4610 4610
query23 34587 33915 32980 32980
query24 8011 2371 2377 2371
query25 549 504 438 438
query26 1301 267 152 152
query27 2628 485 339 339
query28 4312 2177 2164 2164
query29 763 597 482 482
query30 323 222 195 195
query31 914 793 765 765
query32 73 67 66 66
query33 569 370 320 320
query34 776 841 509 509
query35 799 820 733 733
query36 943 982 900 900
query37 145 108 82 82
query38 3533 3513 3514 3513
query39 1483 1438 1415 1415
query40 219 126 118 118
query41 60 57 60 57
query42 118 108 106 106
query43 484 492 463 463
query44 1192 755 739 739
query45 185 178 170 170
query46 882 990 637 637
query47 1813 1814 1750 1750
query48 384 420 329 329
query49 781 516 432 432
query50 644 682 401 401
query51 3915 3876 3875 3875
query52 109 108 102 102
query53 233 273 199 199
query54 317 303 290 290
query55 90 84 82 82
query56 322 349 346 346
query57 1186 1207 1131 1131
query58 284 285 280 280
query59 2595 2710 2499 2499
query60 361 363 340 340
query61 193 185 183 183
query62 801 761 664 664
query63 226 194 194 194
query64 4555 1256 933 933
query65 4014 3948 3935 3935
query66 1110 434 328 328
query67 15598 15215 14854 14854
query68 8350 928 594 594
query69 473 318 283 283
query70 1332 1266 1231 1231
query71 491 332 310 310
query72 5839 5043 4800 4800
query73 532 564 357 357
query74 8819 8859 8897 8859
query75 3884 3325 2870 2870
query76 3264 1148 721 721
query77 820 398 309 309
query78 9523 9915 8884 8884
query79 2306 795 586 586
query80 632 542 490 490
query81 512 258 228 228
query82 433 158 124 124
query83 297 260 245 245
query84 296 121 90 90
query85 914 493 434 434
query86 334 323 289 289
query87 3718 3651 3633 3633
query88 3373 2258 2268 2258
query89 377 315 289 289
query90 2033 211 211 211
query91 166 163 134 134
query92 85 70 64 64
query93 1199 971 646 646
query94 702 427 328 328
query95 398 322 308 308
query96 484 583 291 291
query97 2939 2947 2850 2850
query98 244 215 207 207
query99 1436 1409 1314 1314
Total cold run time: 280951 ms
Total hot run time: 189104 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3496419470
# FE UT Coverage Report
Increment line coverage ` 28.57% (4/14)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_e0a98933a05ff13d07b9e2c6d10eceec71935f34/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_e0a98933a05ff13d07b9e2c6d10eceec71935f34/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3496935316
# FE Regression Coverage Report
Increment line coverage ` 85.71% (12/14)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_e0a98933a05ff13d07b9e2c6d10eceec71935f34_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_e0a98933a05ff13d07b9e2c6d10eceec71935f34_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3510784235
<details>
<summary>TPC-H: <b>Total hot run time: 34570 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0e86ad0c0e49865d18f26b176c15dc8197a754ad, data reload: false
------ Round 1 ----------------------------------
q1 17700 5259 5127 5127
q2 2024 341 212 212
q3 10237 1329 760 760
q4 10252 885 369 369
q5 8094 2482 2324 2324
q6 226 169 138 138
q7 959 776 638 638
q8 9350 1411 1084 1084
q9 7207 5209 5148 5148
q10 6929 2264 1823 1823
q11 511 331 313 313
q12 373 380 244 244
q13 17802 3692 3137 3137
q14 247 242 218 218
q15 571 513 515 513
q16 1048 1012 959 959
q17 595 895 377 377
q18 7532 7144 7038 7038
q19 1106 961 585 585
q20 359 351 224 224
q21 3941 3226 2357 2357
q22 1075 1036 982 982
Total cold run time: 108138 ms
Total hot run time: 34570 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5253 5179 5173 5173
q2 253 329 234 234
q3 2196 2732 2320 2320
q4 1396 1808 1373 1373
q5 4381 4619 4428 4428
q6 214 173 135 135
q7 2023 2055 1887 1887
q8 2738 2599 2570 2570
q9 7392 7372 7430 7372
q10 3154 3295 2866 2866
q11 610 678 557 557
q12 665 781 642 642
q13 3530 3973 3372 3372
q14 319 314 283 283
q15 557 537 524 524
q16 1097 1113 1054 1054
q17 1243 1547 1476 1476
q18 8173 7776 7765 7765
q19 824 904 1066 904
q20 1941 2089 1856 1856
q21 4803 4476 4467 4467
q22 1073 1055 993 993
Total cold run time: 53835 ms
Total hot run time: 52251 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3496044927
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3492039053
<details>
<summary>ClickBench: <b>Total hot run time: 27.62 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b9afd1a1acb18ac51a93c506c37d29531cc958dd, data reload: false
query1 0.05 0.05 0.06
query2 0.09 0.05 0.06
query3 0.26 0.08 0.08
query4 1.61 0.12 0.12
query5 0.26 0.26 0.26
query6 1.16 0.65 0.64
query7 0.03 0.03 0.03
query8 0.05 0.04 0.04
query9 0.59 0.54 0.53
query10 0.58 0.57 0.57
query11 0.16 0.11 0.11
query12 0.15 0.11 0.12
query13 0.61 0.60 0.61
query14 1.00 1.00 1.00
query15 0.85 0.84 0.85
query16 0.39 0.41 0.42
query17 1.02 1.02 1.03
query18 0.22 0.21 0.20
query19 1.91 1.80 1.84
query20 0.02 0.01 0.01
query21 15.44 0.17 0.13
query22 5.11 0.06 0.05
query23 15.67 0.26 0.10
query24 3.06 0.67 0.40
query25 0.08 0.07 0.05
query26 0.15 0.14 0.14
query27 0.06 0.06 0.06
query28 4.81 1.16 0.93
query29 12.57 3.85 3.30
query30 0.29 0.14 0.12
query31 2.84 0.59 0.38
query32 3.23 0.55 0.47
query33 3.17 3.08 3.06
query34 15.82 5.20 4.55
query35 4.56 4.64 4.56
query36 0.68 0.51 0.50
query37 0.11 0.06 0.06
query38 0.06 0.04 0.03
query39 0.04 0.03 0.03
query40 0.17 0.15 0.14
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.03 0.03
Total cold run time: 99.1 s
Total hot run time: 27.62 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3551860971
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3547479953
<details>
<summary>ClickBench: <b>Total hot run time: 27.78 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e4307566fbf75ee5bfe1cc7ab3aada29274347fe, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.05 0.05
query3 0.27 0.08 0.08
query4 1.61 0.12 0.11
query5 0.27 0.25 0.24
query6 1.16 0.66 0.63
query7 0.03 0.02 0.02
query8 0.06 0.04 0.04
query9 0.58 0.53 0.52
query10 0.59 0.56 0.57
query11 0.16 0.11 0.12
query12 0.15 0.12 0.12
query13 0.62 0.61 0.60
query14 1.01 1.01 0.99
query15 0.85 0.84 0.85
query16 0.39 0.40 0.40
query17 1.04 1.02 1.04
query18 0.22 0.20 0.20
query19 1.93 1.79 1.83
query20 0.02 0.02 0.01
query21 15.43 0.20 0.12
query22 4.96 0.06 0.05
query23 15.68 0.25 0.11
query24 2.48 0.90 0.83
query25 0.08 0.05 0.06
query26 0.15 0.13 0.12
query27 0.06 0.05 0.05
query28 3.94 1.20 0.95
query29 12.59 3.82 3.19
query30 0.28 0.14 0.12
query31 2.81 0.58 0.38
query32 3.23 0.54 0.48
query33 3.04 3.05 3.01
query34 15.83 5.15 4.55
query35 4.59 4.60 4.55
query36 0.66 0.50 0.49
query37 0.10 0.07 0.06
query38 0.06 0.04 0.04
query39 0.03 0.03 0.03
query40 0.17 0.14 0.13
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.04 0.03 0.03
Total cold run time: 97.45 s
Total hot run time: 27.78 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3552077705
<details>
<summary>ClickBench: <b>Total hot run time: 27.87 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 198e36a697434bf1a3c60c1bedb5a850160b0146, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.06 0.06
query3 0.26 0.09 0.08
query4 1.61 0.11 0.11
query5 0.26 0.25 0.26
query6 1.17 0.64 0.66
query7 0.03 0.02 0.02
query8 0.05 0.05 0.04
query9 0.57 0.53 0.52
query10 0.58 0.56 0.57
query11 0.16 0.11 0.10
query12 0.15 0.11 0.12
query13 0.63 0.60 0.60
query14 1.01 1.01 1.00
query15 0.85 0.82 0.82
query16 0.40 0.40 0.40
query17 1.01 0.98 1.02
query18 0.22 0.20 0.20
query19 1.86 1.76 1.82
query20 0.01 0.02 0.01
query21 15.47 0.21 0.14
query22 4.94 0.07 0.04
query23 15.69 0.26 0.09
query24 2.67 1.34 0.96
query25 0.07 0.06 0.06
query26 0.14 0.13 0.13
query27 0.06 0.06 0.06
query28 5.17 1.22 0.94
query29 12.62 3.82 3.17
query30 0.29 0.14 0.11
query31 2.82 0.56 0.40
query32 3.23 0.54 0.48
query33 3.07 3.11 3.01
query34 15.95 5.15 4.56
query35 4.59 4.58 4.55
query36 0.67 0.50 0.50
query37 0.10 0.07 0.07
query38 0.06 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.14 0.13
query41 0.09 0.03 0.03
query42 0.04 0.02 0.03
query43 0.05 0.04 0.04
Total cold run time: 98.98 s
Total hot run time: 27.87 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3547460816
<details>
<summary>TPC-DS: <b>Total hot run time: 187914 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e4307566fbf75ee5bfe1cc7ab3aada29274347fe, data reload: false
query1 1059 406 420 406
query2 6592 1613 1677 1613
query3 6759 230 222 222
query4 25901 23289 22524 22524
query5 4394 630 521 521
query6 357 246 232 232
query7 4653 496 312 312
query8 303 256 253 253
query9 8690 2923 2910 2910
query10 513 371 314 314
query11 16013 14960 14790 14790
query12 193 128 122 122
query13 1702 601 476 476
query14 11247 9238 9166 9166
query15 204 228 175 175
query16 7684 674 503 503
query17 1229 745 627 627
query18 2035 432 324 324
query19 216 199 177 177
query20 131 129 123 123
query21 222 131 114 114
query22 4072 4085 4002 4002
query23 33751 32817 32904 32817
query24 8199 2361 2365 2361
query25 594 526 468 468
query26 1245 272 166 166
query27 2751 501 364 364
query28 4406 2266 2232 2232
query29 824 625 495 495
query30 301 219 200 200
query31 907 800 716 716
query32 96 87 84 84
query33 578 397 349 349
query34 789 848 515 515
query35 807 883 771 771
query36 921 986 897 897
query37 136 122 98 98
query38 3490 3548 3486 3486
query39 1484 1414 1418 1414
query40 237 140 129 129
query41 69 60 60 60
query42 135 120 120 120
query43 456 519 459 459
query44 1254 797 811 797
query45 190 178 179 178
query46 876 990 648 648
query47 1747 1767 1702 1702
query48 400 439 326 326
query49 757 509 436 436
query50 639 678 400 400
query51 3937 3947 3819 3819
query52 120 114 105 105
query53 254 283 206 206
query54 334 327 307 307
query55 101 98 92 92
query56 342 356 357 356
query57 1184 1198 1152 1152
query58 303 292 288 288
query59 2568 2641 2552 2552
query60 367 371 360 360
query61 161 152 151 151
query62 791 706 657 657
query63 226 201 203 201
query64 4418 1159 885 885
query65 4003 3945 3947 3945
query66 1110 453 361 361
query67 14979 14811 14886 14811
query68 2675 960 672 672
query69 494 357 306 306
query70 1414 1250 1346 1250
query71 381 354 338 338
query72 6191 5178 5160 5160
query73 525 595 370 370
query74 8899 9072 9036 9036
query75 3225 3278 2765 2765
query76 2943 1115 721 721
query77 545 415 423 415
query78 9563 9736 8968 8968
query79 2561 843 612 612
query80 1755 598 535 535
query81 573 262 221 221
query82 402 158 133 133
query83 357 265 252 252
query84 266 109 98 98
query85 955 489 438 438
query86 473 296 312 296
query87 3741 3711 3626 3626
query88 2820 2258 2219 2219
query89 396 324 294 294
query90 1855 237 224 224
query91 163 168 137 137
query92 89 83 71 71
query93 1567 1023 680 680
query94 733 441 327 327
query95 424 345 341 341
query96 483 595 275 275
query97 2938 2960 2850 2850
query98 242 214 212 212
query99 1284 1375 1230 1230
Total cold run time: 268338 ms
Total hot run time: 187914 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3552527193
# FE Regression Coverage Report
Increment line coverage ` 88.75% (71/80)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_198e36a697434bf1a3c60c1bedb5a850160b0146_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_198e36a697434bf1a3c60c1bedb5a850160b0146_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3626415367
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3509218574
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3520517533
<details>
<summary>ClickBench: <b>Total hot run time: 27.57 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21519fdcaa30ab55a166f0421cff748c0ee19c89, data reload: false
query1 0.05 0.05 0.05
query2 0.09 0.05 0.05
query3 0.26 0.08 0.08
query4 1.60 0.11 0.11
query5 0.27 0.25 0.27
query6 1.18 0.65 0.64
query7 0.04 0.02 0.03
query8 0.06 0.04 0.05
query9 0.60 0.52 0.51
query10 0.58 0.57 0.56
query11 0.17 0.12 0.11
query12 0.15 0.12 0.12
query13 0.62 0.60 0.61
query14 0.99 1.02 1.01
query15 0.85 0.82 0.83
query16 0.38 0.38 0.39
query17 1.05 1.02 1.03
query18 0.22 0.19 0.20
query19 1.92 1.79 1.84
query20 0.02 0.01 0.02
query21 15.43 0.18 0.13
query22 5.05 0.07 0.05
query23 15.66 0.27 0.11
query24 2.73 0.57 1.26
query25 0.09 0.07 0.05
query26 0.13 0.13 0.13
query27 0.08 0.06 0.05
query28 5.08 1.15 0.93
query29 12.61 3.88 3.24
query30 0.28 0.16 0.11
query31 2.82 0.59 0.40
query32 3.24 0.55 0.48
query33 3.09 3.08 3.06
query34 15.80 5.17 4.51
query35 4.52 4.56 4.55
query36 0.71 0.50 0.49
query37 0.09 0.07 0.06
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.14 0.13
query41 0.09 0.04 0.03
query42 0.03 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 98.96 s
Total hot run time: 27.57 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3540759742
<details>
<summary>TPC-DS: <b>Total hot run time: 188484 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9e134f235d6ede1eb9c735abc53f133d2a127c23, data reload: false
query1 1049 403 394 394
query2 6550 1679 1727 1679
query3 6759 231 231 231
query4 25266 23672 23341 23341
query5 5163 661 543 543
query6 357 245 232 232
query7 4680 511 320 320
query8 319 291 278 278
query9 8714 2950 2915 2915
query10 559 355 303 303
query11 15736 15115 14787 14787
query12 196 131 133 131
query13 1698 572 468 468
query14 11879 8989 9022 8989
query15 248 181 170 170
query16 7729 678 478 478
query17 1599 774 606 606
query18 2035 410 342 342
query19 240 192 181 181
query20 131 122 125 122
query21 216 132 114 114
query22 4014 4122 3972 3972
query23 34077 32898 32912 32898
query24 7914 2336 2346 2336
query25 597 509 467 467
query26 1223 278 166 166
query27 2724 497 369 369
query28 4388 2279 2289 2279
query29 815 608 501 501
query30 320 221 194 194
query31 911 774 717 717
query32 92 82 81 81
query33 582 392 348 348
query34 795 847 521 521
query35 827 827 768 768
query36 946 1024 904 904
query37 134 120 102 102
query38 3525 3579 3470 3470
query39 1508 1413 1418 1413
query40 229 136 122 122
query41 66 60 63 60
query42 132 117 115 115
query43 474 476 459 459
query44 1260 801 787 787
query45 188 180 173 173
query46 887 1005 646 646
query47 1802 1830 1687 1687
query48 405 436 320 320
query49 750 498 412 412
query50 645 679 419 419
query51 3941 3971 3901 3901
query52 118 118 108 108
query53 243 268 205 205
query54 331 317 325 317
query55 97 93 92 92
query56 351 344 385 344
query57 1165 1192 1115 1115
query58 317 281 282 281
query59 2491 2699 2524 2524
query60 367 381 348 348
query61 160 157 151 151
query62 782 714 642 642
query63 234 194 203 194
query64 4539 1162 863 863
query65 4038 3912 3931 3912
query66 1117 437 347 347
query67 15327 15101 15129 15101
query68 4765 968 655 655
query69 505 349 302 302
query70 1378 1254 1255 1254
query71 452 349 343 343
query72 6069 5157 5219 5157
query73 649 565 370 370
query74 9177 8748 8676 8676
query75 3305 3256 2749 2749
query76 3309 1120 729 729
query77 586 404 350 350
query78 9516 9808 8856 8856
query79 1922 852 615 615
query80 1772 587 533 533
query81 548 259 227 227
query82 422 164 132 132
query83 367 261 251 251
query84 254 112 95 95
query85 916 502 452 452
query86 397 316 306 306
query87 3695 3746 3642 3642
query88 2899 2278 2277 2277
query89 379 324 295 295
query90 1711 235 238 235
query91 179 167 134 134
query92 82 72 73 72
query93 1198 1041 691 691
query94 725 462 342 342
query95 425 351 330 330
query96 480 604 280 280
query97 2919 2951 2853 2853
query98 241 216 222 216
query99 1313 1400 1290 1290
Total cold run time: 271526 ms
Total hot run time: 188484 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3626556306
<details>
<summary>TPC-H: <b>Total hot run time: 34121 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 86ffb4edfd6d27f6eeddc9669c152b446cbb8a48, data reload: false
------ Round 1 ----------------------------------
q1 17635 5010 4891 4891
q2 2027 310 203 203
q3 10261 1291 725 725
q4 10213 840 305 305
q5 7534 2437 2155 2155
q6 184 182 138 138
q7 1014 795 628 628
q8 9343 1402 1056 1056
q9 6965 5303 5310 5303
q10 6832 2181 1781 1781
q11 523 288 301 288
q12 339 370 221 221
q13 18176 3664 3040 3040
q14 246 247 226 226
q15 603 519 515 515
q16 902 854 822 822
q17 693 698 577 577
q18 7433 7029 6960 6960
q19 1145 954 603 603
q20 400 353 221 221
q21 3969 3277 2493 2493
q22 1055 1011 970 970
Total cold run time: 107492 ms
Total hot run time: 34121 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4964 4907 4907 4907
q2 325 414 308 308
q3 2131 2629 2291 2291
q4 1321 1768 1315 1315
q5 4211 4545 4796 4545
q6 237 183 132 132
q7 2056 1988 1763 1763
q8 2637 2540 2503 2503
q9 7459 7543 7480 7480
q10 3060 3323 2809 2809
q11 587 550 495 495
q12 727 742 787 742
q13 3726 3823 3339 3339
q14 299 313 270 270
q15 565 521 517 517
q16 883 954 897 897
q17 1168 1404 1415 1404
q18 7889 7697 7521 7521
q19 850 830 888 830
q20 2022 2031 1829 1829
q21 4609 4193 4140 4140
q22 1066 1021 998 998
Total cold run time: 52792 ms
Total hot run time: 51035 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3634933160
# FE UT Coverage Report
Increment line coverage ` 50.00% (10/20)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_571a11da70eec16f397b9d1429a7dc1380442d8d/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_571a11da70eec16f397b9d1429a7dc1380442d8d/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3626607700
<details>
<summary>TPC-DS: <b>Total hot run time: 179911 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 86ffb4edfd6d27f6eeddc9669c152b446cbb8a48, data reload: false
query5 4557 646 503 503
query6 348 233 218 218
query7 4675 499 278 278
query8 332 280 241 241
query9 8738 2635 2658 2635
query10 523 321 274 274
query11 15610 15140 14538 14538
query12 188 121 126 121
query13 1693 478 384 384
query14 6560 3305 3062 3062
query14_1 2943 2885 2920 2885
query15 219 200 182 182
query16 7656 473 490 473
query17 1252 738 613 613
query18 2048 432 340 340
query19 214 188 171 171
query20 131 131 134 131
query21 224 139 118 118
query22 3855 4052 4058 4052
query23 16511 16141 15895 15895
query23_1 16031 16085 16097 16085
query24 7270 1655 1199 1199
query24_1 1216 1194 1222 1194
query25 647 514 459 459
query26 1263 283 177 177
query27 2893 469 316 316
query28 4381 2177 2167 2167
query29 822 601 474 474
query30 315 245 219 219
query31 865 732 637 637
query32 83 73 70 70
query33 699 348 294 294
query34 861 970 547 547
query35 801 821 738 738
query36 897 914 843 843
query37 129 95 78 78
query38 3824 3859 3778 3778
query39 744 728 721 721
query39_1 700 727 708 708
query40 225 132 122 122
query41 68 61 61 61
query42 125 102 95 95
query43 437 440 400 400
query44 1320 752 752 752
query45 202 188 181 181
query46 911 964 620 620
query47 1701 1716 1666 1666
query48 400 317 235 235
query49 781 438 359 359
query50 684 307 233 233
query51 3890 3877 3845 3845
query52 122 99 90 90
query53 226 231 176 176
query54 319 258 238 238
query55 98 83 75 75
query56 375 292 295 292
query57 1205 1143 1087 1087
query58 298 264 257 257
query59 2353 2452 2245 2245
query60 357 332 307 307
query61 167 165 167 165
query62 781 695 628 628
query63 228 179 180 179
query64 4491 1206 889 889
query65 4039 3982 3918 3918
query66 1188 476 335 335
query67 15240 15100 14687 14687
query68 8269 933 668 668
query69 517 303 268 268
query70 1037 968 977 968
query71 447 286 273 273
query72 6002 5134 4977 4977
query73 702 557 302 302
query74 8774 8942 8558 8558
query75 3344 3034 2549 2549
query76 3495 1150 738 738
query77 759 404 311 311
query78 9515 9697 8868 8868
query79 1469 874 600 600
query80 672 566 462 462
query81 525 274 237 237
query82 226 136 104 104
query83 291 278 263 263
query84 269 122 96 96
query85 908 501 453 453
query86 378 299 274 274
query87 4061 4098 3878 3878
query88 3500 2225 2173 2173
query89 392 322 310 310
query90 2101 153 157 153
query91 175 163 148 148
query92 92 70 65 65
query93 1787 1056 698 698
query94 763 329 299 299
query95 565 338 379 338
query96 548 505 223 223
query97 2568 2646 2576 2576
query98 255 200 194 194
query99 1356 1324 1230 1230
Total cold run time: 270733 ms
Total hot run time: 179911 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3632332575
# FE Regression Coverage Report
Increment line coverage ` 88.89% (24/27)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_716b0253ceed36a650c57b2c1540b4b7acc340cc_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_716b0253ceed36a650c57b2c1540b4b7acc340cc_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3521477846
# FE Regression Coverage Report
Increment line coverage ` 67.92% (36/53)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_21519fdcaa30ab55a166f0421cff748c0ee19c89_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_21519fdcaa30ab55a166f0421cff748c0ee19c89_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #57741:
URL: https://github.com/apache/doris/pull/57741#discussion_r2522725317
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/MaterializedViewExprReplacer.java:
##########
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.exploration.mv;
+
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.nereids.trees.expressions.VirtualSlotReference;
+import org.apache.doris.nereids.trees.expressions.functions.scalar.GroupingScalarFunction;
+import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.algebra.Repeat;
+import org.apache.doris.nereids.util.ExpressionUtils;
+
+import java.util.ArrayList;
+import java.util.BitSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * Expression replacer which support to handle VirtualSlotReference, if replaceMap contained, just use it
+ */
+public class MaterializedViewExprReplacer extends DefaultExpressionRewriter<Void> {
+
+ private final Map<? extends Expression, ? extends Expression> replaceMap;
+ private final Plan queryTopPlan;
+ private final BitSet sourcePlanBitSet;
+ private boolean valid = true;
+
+ public MaterializedViewExprReplacer(
+ Map<? extends Expression, ? extends Expression> replaceMap,
+ Plan queryTopPlan,
+ BitSet sourcePlanBitSet) {
+ this.replaceMap = replaceMap;
+ this.queryTopPlan = queryTopPlan;
+ this.sourcePlanBitSet = sourcePlanBitSet;
+ }
+
+ public boolean isValid() {
+ return valid;
+ }
+
+ @Override
+ public Expression visit(Expression expr, Void context) {
+ if (!valid) {
+ return expr;
+ }
+ Expression replacedExpr = replaceMap.get(expr);
+ if (replacedExpr != null) {
+ return replacedExpr;
+ }
+ List<Expression> newChildren = new ArrayList<>();
+ boolean hasChanged = false;
+ for (Expression child : expr.children()) {
+ Expression newChild = child.accept(this, context);
+ if (!valid) {
+ return expr;
+ }
+ if (newChild != child) {
+ hasChanged = true;
+ }
+ newChildren.add(newChild);
+ }
+ return hasChanged ? expr.withChildren(newChildren) : expr;
+ }
+
+ @Override
+ public Expression visitSlot(Slot slot, Void context) {
+ if (!valid) {
+ return slot;
+ }
+ if (slot instanceof VirtualSlotReference) {
+ return handleVirtualSlot((VirtualSlotReference) slot, context);
+ }
Review Comment:
why not override visitVirtualReference
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewRule.java:
##########
@@ -672,7 +674,7 @@ protected List<Expression> rewriteExpression(List<? extends Expression> sourceEx
Expression dateTruncWithLiteral = ExpressionUtils.replace(
viewExprParamToDateTruncMap.get(queryShuttledExprParam), datetruncMap);
Expression foldedExpressionWithLiteral = FoldConstantRuleOnFE.evaluate(dateTruncWithLiteral,
- new ExpressionRewriteContext(cascadesContext));
+ new org.apache.doris.nereids.rules.expression.ExpressionRewriteContext(cascadesContext));
Review Comment:
why use full name here?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/MaterializedViewExprReplacer.java:
##########
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.exploration.mv;
+
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.nereids.trees.expressions.VirtualSlotReference;
+import org.apache.doris.nereids.trees.expressions.functions.scalar.GroupingScalarFunction;
+import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.algebra.Repeat;
+import org.apache.doris.nereids.util.ExpressionUtils;
+
+import java.util.ArrayList;
+import java.util.BitSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * Expression replacer which support to handle VirtualSlotReference, if replaceMap contained, just use it
+ */
+public class MaterializedViewExprReplacer extends DefaultExpressionRewriter<Void> {
+
+ private final Map<? extends Expression, ? extends Expression> replaceMap;
+ private final Plan queryTopPlan;
+ private final BitSet sourcePlanBitSet;
+ private boolean valid = true;
Review Comment:
what's the valid mean? add comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3527169645
# FE UT Coverage Report
Increment line coverage ` 60.38% (32/53)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_fc43503cecaca44a148c3ba5df04354a24b3625c/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_fc43503cecaca44a148c3ba5df04354a24b3625c/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3526996005
<details>
<summary>TPC-DS: <b>Total hot run time: 188220 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fc43503cecaca44a148c3ba5df04354a24b3625c, data reload: false
query1 1049 406 392 392
query2 6578 1757 1755 1755
query3 6762 234 227 227
query4 26351 23324 23446 23324
query5 4357 617 480 480
query6 339 233 222 222
query7 4646 490 303 303
query8 303 273 261 261
query9 8710 2621 2666 2621
query10 496 336 288 288
query11 15707 15046 15333 15046
query12 190 123 115 115
query13 1682 559 445 445
query14 10306 9284 9251 9251
query15 204 193 180 180
query16 7348 681 507 507
query17 1277 788 641 641
query18 1994 439 340 340
query19 230 239 190 190
query20 136 132 131 131
query21 225 135 119 119
query22 3878 4119 4074 4074
query23 34025 33129 33009 33009
query24 8513 2420 2419 2419
query25 648 551 481 481
query26 1254 279 162 162
query27 2742 493 357 357
query28 4377 2241 2228 2228
query29 873 653 514 514
query30 303 232 204 204
query31 911 793 711 711
query32 90 79 81 79
query33 624 386 357 357
query34 805 854 521 521
query35 834 853 767 767
query36 969 1046 912 912
query37 123 110 84 84
query38 3565 3548 3464 3464
query39 1470 1439 1394 1394
query40 225 131 127 127
query41 64 60 62 60
query42 137 113 116 113
query43 509 504 474 474
query44 1234 742 742 742
query45 191 179 174 174
query46 886 984 647 647
query47 1740 1781 1711 1711
query48 391 422 324 324
query49 793 525 422 422
query50 646 678 418 418
query51 3854 3900 3841 3841
query52 114 119 107 107
query53 247 273 200 200
query54 305 312 281 281
query55 85 85 88 85
query56 322 327 320 320
query57 1192 1189 1115 1115
query58 288 276 274 274
query59 2591 2779 2527 2527
query60 343 351 329 329
query61 165 162 177 162
query62 833 736 674 674
query63 232 190 198 190
query64 4494 1194 851 851
query65 4020 3945 3927 3927
query66 1199 438 349 349
query67 15253 15170 14884 14884
query68 8576 923 596 596
query69 492 324 283 283
query70 1357 1277 1298 1277
query71 496 338 319 319
query72 5892 4965 5038 4965
query73 683 585 354 354
query74 8867 9063 8702 8702
query75 4007 3311 2852 2852
query76 3810 1139 730 730
query77 800 409 316 316
query78 9448 9717 8780 8780
query79 2315 823 610 610
query80 627 569 497 497
query81 490 265 235 235
query82 439 164 133 133
query83 303 281 256 256
query84 300 116 93 93
query85 915 490 467 467
query86 335 301 289 289
query87 3716 3723 3622 3622
query88 3318 2270 2253 2253
query89 392 331 299 299
query90 1935 228 221 221
query91 172 171 145 145
query92 80 69 61 61
query93 1260 988 654 654
query94 718 448 339 339
query95 412 317 320 317
query96 493 566 284 284
query97 2930 2964 2867 2867
query98 249 216 231 216
query99 1433 1421 1285 1285
Total cold run time: 274507 ms
Total hot run time: 188220 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3540244367
<details>
<summary>TPC-DS: <b>Total hot run time: 189686 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ddbe14e2682ec11d7134670e9beb903ad87f30c5, data reload: false
query1 1035 412 395 395
query2 6590 1665 1658 1658
query3 6755 231 229 229
query4 26556 23629 23681 23629
query5 4972 655 553 553
query6 368 262 252 252
query7 4664 511 309 309
query8 318 273 270 270
query9 8709 2960 2943 2943
query10 549 363 321 321
query11 15856 15056 14909 14909
query12 189 129 123 123
query13 1695 584 472 472
query14 11320 9286 9249 9249
query15 215 190 178 178
query16 7708 645 491 491
query17 1181 771 619 619
query18 2037 421 332 332
query19 206 197 177 177
query20 139 129 124 124
query21 218 132 113 113
query22 4022 4021 3973 3973
query23 33949 33193 33156 33156
query24 8176 2404 2400 2400
query25 602 547 477 477
query26 1223 275 168 168
query27 2754 502 357 357
query28 4432 2265 2246 2246
query29 802 621 509 509
query30 312 231 199 199
query31 931 835 730 730
query32 90 83 83 83
query33 583 391 342 342
query34 789 858 540 540
query35 828 832 734 734
query36 958 983 904 904
query37 137 126 100 100
query38 3518 3519 3385 3385
query39 1466 1417 1429 1417
query40 230 143 128 128
query41 65 61 62 61
query42 138 120 118 118
query43 483 476 471 471
query44 1263 804 799 799
query45 193 191 173 173
query46 902 1003 660 660
query47 1769 1810 1716 1716
query48 406 430 337 337
query49 762 512 418 418
query50 657 698 419 419
query51 3867 3942 3870 3870
query52 117 119 109 109
query53 249 280 216 216
query54 344 319 305 305
query55 98 93 89 89
query56 362 353 345 345
query57 1198 1208 1132 1132
query58 305 289 297 289
query59 2537 2577 2474 2474
query60 363 362 358 358
query61 194 158 160 158
query62 806 719 668 668
query63 230 195 200 195
query64 4462 1155 865 865
query65 4058 3939 3926 3926
query66 1107 443 359 359
query67 15184 14961 14873 14873
query68 5020 975 649 649
query69 495 351 300 300
query70 1393 1247 1256 1247
query71 429 350 335 335
query72 5792 5236 5207 5207
query73 680 603 377 377
query74 8891 8949 8869 8869
query75 3297 3318 2773 2773
query76 3301 1172 776 776
query77 529 408 348 348
query78 9622 9844 8886 8886
query79 1565 868 629 629
query80 1764 703 554 554
query81 552 257 227 227
query82 421 165 138 138
query83 378 269 252 252
query84 258 120 103 103
query85 905 505 447 447
query86 384 311 304 304
query87 3704 3741 3595 3595
query88 2920 2298 2290 2290
query89 400 336 303 303
query90 1749 245 244 244
query91 174 190 138 138
query92 84 83 73 73
query93 1203 1064 691 691
query94 740 432 324 324
query95 428 351 347 347
query96 489 604 289 289
query97 2889 2959 2878 2878
query98 251 230 221 221
query99 1386 1396 1275 1275
Total cold run time: 271294 ms
Total hot run time: 189686 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3540629630
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3540320403
# FE UT Coverage Report
Increment line coverage ` 50.85% (30/59)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_ddbe14e2682ec11d7134670e9beb903ad87f30c5/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_ddbe14e2682ec11d7134670e9beb903ad87f30c5/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3509218627
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3511815714
# FE Regression Coverage Report
Increment line coverage ` 67.92% (36/53)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_0e86ad0c0e49865d18f26b176c15dc8197a754ad_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_0e86ad0c0e49865d18f26b176c15dc8197a754ad_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3500673935
<details>
<summary>ClickBench: <b>Total hot run time: 27.36 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6d68309d134a901eedd2859a0b5626918c8ad3e7, data reload: false
query1 0.06 0.05 0.06
query2 0.09 0.04 0.04
query3 0.25 0.08 0.08
query4 1.61 0.12 0.12
query5 0.27 0.26 0.25
query6 1.20 0.65 0.64
query7 0.03 0.02 0.03
query8 0.05 0.04 0.04
query9 0.59 0.51 0.52
query10 0.58 0.58 0.57
query11 0.17 0.12 0.11
query12 0.15 0.11 0.12
query13 0.61 0.60 0.60
query14 0.99 1.01 1.00
query15 0.84 0.84 0.84
query16 0.39 0.38 0.41
query17 1.03 1.01 1.02
query18 0.21 0.20 0.19
query19 1.87 1.77 1.77
query20 0.01 0.02 0.02
query21 15.44 0.19 0.14
query22 5.01 0.06 0.04
query23 15.69 0.26 0.10
query24 3.36 0.55 0.42
query25 0.08 0.06 0.06
query26 0.14 0.12 0.13
query27 0.07 0.06 0.05
query28 4.58 1.12 0.93
query29 12.55 3.91 3.22
query30 0.28 0.14 0.12
query31 2.82 0.61 0.38
query32 3.24 0.55 0.47
query33 3.03 2.98 3.10
query34 15.80 5.19 4.52
query35 4.57 4.60 4.60
query36 0.66 0.49 0.50
query37 0.09 0.07 0.07
query38 0.07 0.04 0.04
query39 0.04 0.03 0.02
query40 0.17 0.15 0.14
query41 0.09 0.04 0.04
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 98.86 s
Total hot run time: 27.36 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3501091932
<details>
<summary>ClickBench: <b>Total hot run time: 27.36 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e0b271fff88a83c5575bbb0a5b9c4c50122e2ddc, data reload: false
query1 0.05 0.05 0.05
query2 0.11 0.06 0.05
query3 0.27 0.08 0.08
query4 1.79 0.12 0.11
query5 0.28 0.25 0.26
query6 1.17 0.64 0.64
query7 0.03 0.03 0.02
query8 0.05 0.04 0.04
query9 0.69 0.52 0.52
query10 0.58 0.56 0.57
query11 0.18 0.12 0.12
query12 0.16 0.12 0.12
query13 0.62 0.61 0.59
query14 0.99 1.00 1.00
query15 0.86 0.82 0.82
query16 0.38 0.38 0.38
query17 1.05 1.05 1.01
query18 0.22 0.19 0.19
query19 2.02 1.73 1.84
query20 0.01 0.02 0.01
query21 15.44 0.18 0.14
query22 4.95 0.13 0.04
query23 15.61 0.25 0.10
query24 3.62 1.55 0.51
query25 0.09 0.07 0.07
query26 0.14 0.14 0.13
query27 0.06 0.06 0.05
query28 5.55 1.12 0.93
query29 12.67 3.87 3.23
query30 0.29 0.14 0.11
query31 2.82 0.57 0.38
query32 3.25 0.56 0.47
query33 2.95 3.04 3.02
query34 15.82 5.15 4.51
query35 4.58 4.53 4.53
query36 0.65 0.49 0.50
query37 0.16 0.07 0.07
query38 0.09 0.04 0.03
query39 0.05 0.03 0.03
query40 0.20 0.15 0.14
query41 0.11 0.03 0.03
query42 0.06 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 100.72 s
Total hot run time: 27.36 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on code in PR #57741:
URL: https://github.com/apache/doris/pull/57741#discussion_r2533271560
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewRule.java:
##########
@@ -672,7 +674,7 @@ protected List<Expression> rewriteExpression(List<? extends Expression> sourceEx
Expression dateTruncWithLiteral = ExpressionUtils.replace(
viewExprParamToDateTruncMap.get(queryShuttledExprParam), datetruncMap);
Expression foldedExpressionWithLiteral = FoldConstantRuleOnFE.evaluate(dateTruncWithLiteral,
- new ExpressionRewriteContext(cascadesContext));
+ new org.apache.doris.nereids.rules.expression.ExpressionRewriteContext(cascadesContext));
Review Comment:
have fixed, remove full name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3540214602
<details>
<summary>TPC-H: <b>Total hot run time: 34401 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ddbe14e2682ec11d7134670e9beb903ad87f30c5, data reload: false
------ Round 1 ----------------------------------
q1 17608 5216 5118 5118
q2 2017 345 207 207
q3 10236 1314 730 730
q4 10237 979 383 383
q5 7536 2443 2345 2345
q6 184 166 138 138
q7 921 776 627 627
q8 9360 1397 1147 1147
q9 7032 5073 5233 5073
q10 6838 2242 1816 1816
q11 482 309 298 298
q12 343 374 230 230
q13 17792 3673 3043 3043
q14 230 246 223 223
q15 570 504 498 498
q16 1015 1001 968 968
q17 590 884 369 369
q18 7542 7131 7165 7131
q19 1220 968 572 572
q20 361 336 230 230
q21 3841 2574 2284 2284
q22 1087 1055 971 971
Total cold run time: 107042 ms
Total hot run time: 34401 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5177 5128 5173 5128
q2 262 330 243 243
q3 2201 2722 2285 2285
q4 1381 1803 1337 1337
q5 4203 4471 4594 4471
q6 223 181 137 137
q7 2118 2012 1860 1860
q8 2671 2628 2557 2557
q9 7476 7399 7328 7328
q10 3138 3277 2826 2826
q11 573 528 529 528
q12 673 771 629 629
q13 3555 3955 3353 3353
q14 288 310 373 310
q15 545 520 513 513
q16 1053 1093 1045 1045
q17 1173 1549 1409 1409
q18 7830 7937 7568 7568
q19 807 832 983 832
q20 2053 2078 1936 1936
q21 5072 4453 4243 4243
q22 1115 1039 983 983
Total cold run time: 53587 ms
Total hot run time: 51521 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3541351136
# FE Regression Coverage Report
Increment line coverage ` 76.12% (51/67)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_9e134f235d6ede1eb9c735abc53f133d2a127c23_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_9e134f235d6ede1eb9c735abc53f133d2a127c23_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3558048338
# FE Regression Coverage Report
Increment line coverage ` 77.27% (85/110)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_caf904b1a88e12b624412fdcfce5e4e1adb6dcac_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_caf904b1a88e12b624412fdcfce5e4e1adb6dcac_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3627278397
# FE Regression Coverage Report
Increment line coverage ` 88.89% (24/27)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_86ffb4edfd6d27f6eeddc9669c152b446cbb8a48_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_86ffb4edfd6d27f6eeddc9669c152b446cbb8a48_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3524937334
<details>
<summary>TPC-H: <b>Total hot run time: 34343 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ec2c64e6574924d17a2eb36be02c00560da7e6b4, data reload: false
------ Round 1 ----------------------------------
q1 17611 5196 5062 5062
q2 2033 315 210 210
q3 10230 1306 718 718
q4 10240 999 381 381
q5 7560 2391 2394 2391
q6 185 188 140 140
q7 917 779 632 632
q8 9354 1369 1093 1093
q9 6959 5178 5154 5154
q10 6822 2241 1804 1804
q11 507 313 284 284
q12 345 364 222 222
q13 17781 3680 3062 3062
q14 229 230 217 217
q15 585 546 501 501
q16 1031 1007 946 946
q17 590 870 368 368
q18 7531 7136 7041 7041
q19 1234 968 572 572
q20 358 339 233 233
q21 3797 3145 2313 2313
q22 1055 1036 999 999
Total cold run time: 106954 ms
Total hot run time: 34343 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5158 5144 5116 5116
q2 250 320 232 232
q3 2215 2669 2315 2315
q4 1384 1778 1317 1317
q5 4197 4511 4635 4511
q6 262 171 130 130
q7 2088 2008 1861 1861
q8 2634 2605 2567 2567
q9 7495 7373 7534 7373
q10 3035 3236 2887 2887
q11 607 527 515 515
q12 734 794 643 643
q13 3471 3962 3342 3342
q14 308 323 273 273
q15 553 506 536 506
q16 1060 1145 1068 1068
q17 1162 1570 1394 1394
q18 8000 7664 7670 7664
q19 807 794 940 794
q20 2030 2047 1900 1900
q21 5126 4522 4353 4353
q22 1094 1052 1008 1008
Total cold run time: 53670 ms
Total hot run time: 51769 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3526928496
<details>
<summary>TPC-H: <b>Total hot run time: 35070 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fc43503cecaca44a148c3ba5df04354a24b3625c, data reload: false
------ Round 1 ----------------------------------
q1 17618 5145 5029 5029
q2 2013 320 221 221
q3 10228 1285 734 734
q4 10240 958 380 380
q5 7501 2403 2344 2344
q6 186 173 141 141
q7 915 778 647 647
q8 9370 1310 1108 1108
q9 6959 5200 5188 5188
q10 6836 2244 1823 1823
q11 492 304 287 287
q12 339 369 239 239
q13 17771 3659 3031 3031
q14 239 251 220 220
q15 576 520 496 496
q16 1029 997 943 943
q17 583 867 369 369
q18 7469 7606 8024 7606
q19 1111 974 574 574
q20 396 354 229 229
q21 4406 3368 2422 2422
q22 1147 1141 1039 1039
Total cold run time: 107424 ms
Total hot run time: 35070 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5329 5321 5389 5321
q2 245 332 234 234
q3 2345 2902 2448 2448
q4 1554 1967 1451 1451
q5 4546 4560 4422 4422
q6 208 169 125 125
q7 2063 2055 1799 1799
q8 2660 2679 2503 2503
q9 7349 7371 7324 7324
q10 3029 3218 2821 2821
q11 581 525 494 494
q12 654 721 583 583
q13 3273 3657 3001 3001
q14 266 285 265 265
q15 526 490 480 480
q16 1005 1039 992 992
q17 1107 1479 1294 1294
q18 7293 7092 7079 7079
q19 767 801 807 801
q20 1902 1966 1788 1788
q21 4795 4313 4354 4313
q22 1072 1046 1008 1008
Total cold run time: 52569 ms
Total hot run time: 50546 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3631447832
# FE UT Coverage Report
Increment line coverage ` 59.26% (16/27)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_716b0253ceed36a650c57b2c1540b4b7acc340cc/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_716b0253ceed36a650c57b2c1540b4b7acc340cc/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3510343834
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3527553400
# FE Regression Coverage Report
Increment line coverage ` 67.92% (36/53)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_fc43503cecaca44a148c3ba5df04354a24b3625c_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_fc43503cecaca44a148c3ba5df04354a24b3625c_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3500664702
<details>
<summary>TPC-DS: <b>Total hot run time: 189266 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6d68309d134a901eedd2859a0b5626918c8ad3e7, data reload: false
query1 1016 403 397 397
query2 6587 1681 1715 1681
query3 6749 231 217 217
query4 26335 23447 23463 23447
query5 5226 631 465 465
query6 342 236 217 217
query7 4645 491 293 293
query8 303 280 251 251
query9 8743 2584 2566 2566
query10 540 362 290 290
query11 15985 15128 14834 14834
query12 190 118 114 114
query13 1689 571 440 440
query14 11872 9047 9270 9047
query15 199 187 182 182
query16 7675 686 538 538
query17 1618 799 630 630
query18 2050 487 378 378
query19 228 237 200 200
query20 139 132 145 132
query21 234 157 122 122
query22 4721 4815 4609 4609
query23 34912 33648 34039 33648
query24 8507 2482 2464 2464
query25 593 543 504 504
query26 1263 288 159 159
query27 2836 533 370 370
query28 4346 2220 2189 2189
query29 838 628 507 507
query30 307 236 207 207
query31 966 860 755 755
query32 81 83 68 68
query33 594 401 341 341
query34 794 879 532 532
query35 824 844 751 751
query36 1001 1028 974 974
query37 121 110 88 88
query38 3652 3709 3654 3654
query39 1538 1428 1403 1403
query40 216 128 118 118
query41 59 57 57 57
query42 128 113 110 110
query43 489 489 474 474
query44 1214 743 736 736
query45 178 175 192 175
query46 872 981 633 633
query47 1768 1797 1757 1757
query48 383 419 312 312
query49 771 505 420 420
query50 651 679 402 402
query51 4136 4006 3882 3882
query52 108 105 101 101
query53 250 279 186 186
query54 306 278 268 268
query55 84 83 84 83
query56 319 310 289 289
query57 1165 1204 1129 1129
query58 276 267 263 263
query59 2567 2752 2489 2489
query60 327 331 344 331
query61 158 156 155 155
query62 763 722 678 678
query63 236 193 193 193
query64 4460 1130 831 831
query65 4038 3918 3935 3918
query66 1052 420 331 331
query67 15442 15334 14873 14873
query68 7197 880 598 598
query69 484 311 284 284
query70 1362 1288 1253 1253
query71 470 356 297 297
query72 6143 4998 5034 4998
query73 553 620 360 360
query74 9049 9074 8878 8878
query75 3958 3315 2798 2798
query76 3301 1139 728 728
query77 791 390 305 305
query78 9487 9583 8914 8914
query79 2184 820 585 585
query80 620 571 490 490
query81 500 254 226 226
query82 471 160 132 132
query83 257 259 250 250
query84 259 116 90 90
query85 897 485 432 432
query86 376 301 274 274
query87 3707 3645 3631 3631
query88 4088 2266 2257 2257
query89 372 330 294 294
query90 1961 216 227 216
query91 166 174 138 138
query92 81 62 63 62
query93 1871 957 639 639
query94 701 441 334 334
query95 393 318 311 311
query96 480 592 280 280
query97 2897 2969 2842 2842
query98 232 208 205 205
query99 1625 1394 1307 1307
Total cold run time: 279608 ms
Total hot run time: 189266 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3540256142
<details>
<summary>ClickBench: <b>Total hot run time: 27.5 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ddbe14e2682ec11d7134670e9beb903ad87f30c5, data reload: false
query1 0.05 0.05 0.05
query2 0.10 0.06 0.05
query3 0.26 0.09 0.08
query4 1.60 0.12 0.11
query5 0.27 0.25 0.26
query6 1.16 0.65 0.65
query7 0.04 0.03 0.03
query8 0.05 0.04 0.04
query9 0.58 0.52 0.52
query10 0.58 0.57 0.57
query11 0.16 0.11 0.12
query12 0.15 0.13 0.12
query13 0.64 0.61 0.60
query14 1.02 1.00 1.00
query15 0.86 0.83 0.83
query16 0.38 0.38 0.39
query17 1.00 1.02 1.01
query18 0.22 0.21 0.20
query19 1.92 1.80 1.85
query20 0.02 0.02 0.01
query21 15.44 0.20 0.12
query22 4.87 0.08 0.04
query23 15.67 0.26 0.10
query24 2.89 0.50 0.76
query25 0.07 0.07 0.07
query26 0.15 0.13 0.13
query27 0.06 0.06 0.06
query28 4.82 1.18 0.95
query29 12.65 3.85 3.21
query30 0.28 0.13 0.14
query31 2.82 0.57 0.38
query32 3.23 0.56 0.46
query33 3.11 3.01 3.04
query34 15.78 5.16 4.58
query35 4.55 4.51 4.57
query36 0.67 0.49 0.49
query37 0.10 0.06 0.07
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.15 0.13
query41 0.09 0.03 0.03
query42 0.04 0.04 0.03
query43 0.05 0.04 0.03
Total cold run time: 98.68 s
Total hot run time: 27.5 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 merged PR #57741:
URL: https://github.com/apache/doris/pull/57741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3632813326
# FE Regression Coverage Report
Increment line coverage ` 88.89% (24/27)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_716b0253ceed36a650c57b2c1540b4b7acc340cc_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_716b0253ceed36a650c57b2c1540b4b7acc340cc_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3634856667
<details>
<summary>ClickBench: <b>Total hot run time: 27.68 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 571a11da70eec16f397b9d1429a7dc1380442d8d, data reload: false
query1 0.06 0.05 0.04
query2 0.16 0.05 0.05
query3 0.27 0.09 0.08
query4 1.62 0.11 0.10
query5 0.27 0.26 0.26
query6 1.19 0.64 0.64
query7 0.03 0.03 0.03
query8 0.06 0.04 0.04
query9 0.58 0.50 0.49
query10 0.56 0.55 0.56
query11 0.19 0.10 0.10
query12 0.14 0.12 0.12
query13 0.63 0.61 0.60
query14 1.00 0.98 0.98
query15 0.81 0.80 0.80
query16 0.42 0.40 0.41
query17 1.06 1.08 1.05
query18 0.24 0.22 0.22
query19 1.95 1.78 1.77
query20 0.02 0.02 0.01
query21 15.50 0.30 0.14
query22 4.73 0.05 0.05
query23 16.10 0.27 0.10
query24 2.09 0.78 0.52
query25 0.08 0.07 0.07
query26 0.15 0.14 0.13
query27 0.08 0.05 0.06
query28 5.37 1.22 1.04
query29 12.64 4.01 3.26
query30 0.28 0.14 0.11
query31 2.82 0.62 0.39
query32 3.24 0.57 0.45
query33 3.02 3.12 3.09
query34 16.76 5.16 4.53
query35 4.48 4.57 4.58
query36 0.66 0.50 0.50
query37 0.13 0.07 0.06
query38 0.08 0.04 0.04
query39 0.06 0.03 0.04
query40 0.17 0.14 0.13
query41 0.15 0.03 0.03
query42 0.06 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 99.95 s
Total hot run time: 27.68 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3635173283
# FE Regression Coverage Report
Increment line coverage ` 85.00% (17/20)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_571a11da70eec16f397b9d1429a7dc1380442d8d_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_571a11da70eec16f397b9d1429a7dc1380442d8d_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3635285860
# FE Regression Coverage Report
Increment line coverage ` 85.00% (17/20)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_571a11da70eec16f397b9d1429a7dc1380442d8d_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_571a11da70eec16f397b9d1429a7dc1380442d8d_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3556926491
# FE UT Coverage Report
Increment line coverage ` 67.27% (74/110)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_caf904b1a88e12b624412fdcfce5e4e1adb6dcac/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_caf904b1a88e12b624412fdcfce5e4e1adb6dcac/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3636562033
# FE Regression Coverage Report
Increment line coverage ` 85.00% (17/20)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_571a11da70eec16f397b9d1429a7dc1380442d8d_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_571a11da70eec16f397b9d1429a7dc1380442d8d_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3496129552
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3500580070
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3500945874
# FE Regression Coverage Report
Increment line coverage ` 67.31% (35/52)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_6d68309d134a901eedd2859a0b5626918c8ad3e7_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_6d68309d134a901eedd2859a0b5626918c8ad3e7_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3526817054
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3527024022
<details>
<summary>ClickBench: <b>Total hot run time: 27.46 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fc43503cecaca44a148c3ba5df04354a24b3625c, data reload: false
query1 0.05 0.04 0.04
query2 0.09 0.05 0.06
query3 0.26 0.08 0.08
query4 1.61 0.11 0.11
query5 0.26 0.25 0.26
query6 1.18 0.64 0.64
query7 0.03 0.02 0.02
query8 0.06 0.04 0.04
query9 0.59 0.53 0.53
query10 0.58 0.57 0.58
query11 0.16 0.11 0.11
query12 0.15 0.11 0.12
query13 0.63 0.60 0.61
query14 1.00 1.01 1.01
query15 0.86 0.84 0.84
query16 0.43 0.39 0.40
query17 1.02 1.03 1.03
query18 0.21 0.20 0.20
query19 1.89 1.82 1.79
query20 0.01 0.02 0.01
query21 15.45 0.19 0.13
query22 5.05 0.07 0.04
query23 15.69 0.26 0.10
query24 2.48 0.61 0.42
query25 0.08 0.05 0.07
query26 0.13 0.14 0.14
query27 0.07 0.06 0.05
query28 4.96 1.15 0.93
query29 12.58 3.84 3.18
query30 0.28 0.14 0.11
query31 2.81 0.61 0.38
query32 3.24 0.56 0.47
query33 3.01 3.02 3.03
query34 15.89 5.14 4.54
query35 4.53 4.64 4.66
query36 0.67 0.50 0.48
query37 0.10 0.06 0.07
query38 0.06 0.05 0.04
query39 0.04 0.03 0.03
query40 0.17 0.15 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.05 0.03 0.03
Total cold run time: 98.54 s
Total hot run time: 27.46 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3520463306
<details>
<summary>TPC-H: <b>Total hot run time: 34120 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21519fdcaa30ab55a166f0421cff748c0ee19c89, data reload: false
------ Round 1 ----------------------------------
q1 17596 5186 5062 5062
q2 2002 334 206 206
q3 10275 1276 686 686
q4 10264 913 393 393
q5 7535 2383 2327 2327
q6 180 172 139 139
q7 902 762 612 612
q8 9342 1265 1231 1231
q9 6908 5124 5166 5124
q10 6842 2231 1830 1830
q11 487 307 300 300
q12 384 361 231 231
q13 17849 3696 3025 3025
q14 227 236 218 218
q15 597 514 504 504
q16 975 988 931 931
q17 579 868 364 364
q18 7339 7188 6935 6935
q19 1481 930 544 544
q20 351 354 235 235
q21 3618 2536 2262 2262
q22 1059 1029 961 961
Total cold run time: 106792 ms
Total hot run time: 34120 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5221 5116 5085 5085
q2 246 325 232 232
q3 2155 2660 2238 2238
q4 1357 1774 1315 1315
q5 4196 4272 4559 4272
q6 224 177 132 132
q7 1952 2045 1933 1933
q8 2724 2602 2897 2602
q9 7461 7418 7282 7282
q10 3084 3243 2900 2900
q11 590 538 525 525
q12 682 795 652 652
q13 3566 3918 3391 3391
q14 290 310 294 294
q15 528 500 507 500
q16 1071 1099 1077 1077
q17 1176 1627 1368 1368
q18 8142 7678 7308 7308
q19 770 783 849 783
q20 1877 1923 1804 1804
q21 4740 4403 4326 4326
q22 1081 1031 984 984
Total cold run time: 53133 ms
Total hot run time: 51003 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3540713627
<details>
<summary>TPC-H: <b>Total hot run time: 34110 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9e134f235d6ede1eb9c735abc53f133d2a127c23, data reload: false
------ Round 1 ----------------------------------
q1 17620 5247 4995 4995
q2 2023 311 209 209
q3 10259 1278 699 699
q4 10227 880 364 364
q5 7505 2367 2324 2324
q6 183 169 138 138
q7 925 762 612 612
q8 9328 1396 1074 1074
q9 6878 5083 5111 5083
q10 6796 2219 1806 1806
q11 469 296 276 276
q12 335 368 237 237
q13 17817 3612 3039 3039
q14 223 230 213 213
q15 557 501 500 500
q16 1026 996 942 942
q17 580 864 355 355
q18 7332 7203 7197 7197
q19 1090 947 540 540
q20 359 338 223 223
q21 3749 2506 2297 2297
q22 1081 1019 987 987
Total cold run time: 106362 ms
Total hot run time: 34110 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5082 5068 5055 5055
q2 248 320 223 223
q3 2160 2682 2285 2285
q4 1352 1753 1302 1302
q5 4169 4219 4655 4219
q6 225 180 132 132
q7 2051 1930 1853 1853
q8 2589 2482 2591 2482
q9 7361 7403 7260 7260
q10 3028 3234 3055 3055
q11 600 525 495 495
q12 687 789 617 617
q13 3449 3961 3300 3300
q14 290 289 283 283
q15 544 497 493 493
q16 1068 1090 1030 1030
q17 1156 1550 1376 1376
q18 7958 7636 7538 7538
q19 768 836 891 836
q20 2016 2099 1889 1889
q21 4908 4670 4495 4495
q22 1072 1015 1001 1001
Total cold run time: 52781 ms
Total hot run time: 51219 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3524981306
<details>
<summary>TPC-DS: <b>Total hot run time: 187862 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ec2c64e6574924d17a2eb36be02c00560da7e6b4, data reload: false
query1 1019 403 388 388
query2 6558 1707 1744 1707
query3 6763 232 227 227
query4 26188 23491 23003 23003
query5 4387 632 481 481
query6 377 245 233 233
query7 4653 517 296 296
query8 294 255 247 247
query9 8704 2608 2606 2606
query10 492 336 302 302
query11 15237 15080 14854 14854
query12 183 125 112 112
query13 1677 552 429 429
query14 10373 9287 9220 9220
query15 198 188 169 169
query16 7477 671 527 527
query17 1255 785 642 642
query18 2022 426 323 323
query19 217 212 183 183
query20 135 130 128 128
query21 221 135 115 115
query22 3900 4106 3913 3913
query23 34152 33067 33148 33067
query24 8497 2469 2443 2443
query25 642 541 488 488
query26 1251 282 170 170
query27 2782 517 366 366
query28 4443 2284 2256 2256
query29 843 655 525 525
query30 308 231 201 201
query31 903 839 742 742
query32 88 86 78 78
query33 616 402 354 354
query34 826 870 553 553
query35 837 869 744 744
query36 984 999 928 928
query37 133 116 95 95
query38 3550 3505 3430 3430
query39 1491 1419 1436 1419
query40 230 133 128 128
query41 68 70 66 66
query42 136 113 114 113
query43 496 500 481 481
query44 1245 756 757 756
query45 203 183 173 173
query46 917 1000 644 644
query47 1844 1810 1730 1730
query48 397 431 331 331
query49 809 528 438 438
query50 686 681 412 412
query51 3934 3998 3823 3823
query52 120 114 103 103
query53 240 267 205 205
query54 304 285 272 272
query55 86 91 85 85
query56 329 309 310 309
query57 1189 1216 1110 1110
query58 284 279 270 270
query59 2567 2641 2534 2534
query60 365 360 332 332
query61 163 158 152 152
query62 791 813 688 688
query63 237 193 204 193
query64 4493 1154 870 870
query65 4025 3935 3965 3935
query66 1157 443 352 352
query67 15488 15203 14879 14879
query68 8426 945 597 597
query69 483 325 282 282
query70 1337 1321 1305 1305
query71 492 342 318 318
query72 5833 4954 4901 4901
query73 691 558 353 353
query74 9125 9025 8986 8986
query75 3967 3266 2769 2769
query76 3764 1152 724 724
query77 833 401 312 312
query78 9592 9714 8802 8802
query79 2159 836 596 596
query80 657 570 500 500
query81 512 259 232 232
query82 445 154 136 136
query83 282 260 257 257
query84 272 111 94 94
query85 913 485 439 439
query86 386 284 292 284
query87 3700 3672 3652 3652
query88 3469 2275 2264 2264
query89 383 334 295 295
query90 1843 219 221 219
query91 170 165 137 137
query92 77 70 61 61
query93 1664 992 650 650
query94 718 401 341 341
query95 397 307 302 302
query96 488 575 290 290
query97 2949 2955 2867 2867
query98 230 218 212 212
query99 1460 1395 1337 1337
Total cold run time: 275196 ms
Total hot run time: 187862 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3515928011
# FE Regression Coverage Report
Increment line coverage ` 67.92% (36/53)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_0e86ad0c0e49865d18f26b176c15dc8197a754ad_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_0e86ad0c0e49865d18f26b176c15dc8197a754ad_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3634843670
<details>
<summary>TPC-DS: <b>Total hot run time: 182857 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 571a11da70eec16f397b9d1429a7dc1380442d8d, data reload: false
query5 6101 655 473 473
query6 329 239 224 224
query7 4229 483 285 285
query8 311 256 244 244
query9 8758 2628 2629 2628
query10 532 401 329 329
query11 15599 15097 14587 14587
query12 195 116 119 116
query13 1299 529 404 404
query14 6695 3309 3014 3014
query14_1 2951 2982 2947 2947
query15 212 196 188 188
query16 1055 469 462 462
query17 1257 726 616 616
query18 2716 450 358 358
query19 235 236 209 209
query20 129 116 115 115
query21 561 143 119 119
query22 4602 4659 4505 4505
query23 16982 16532 16236 16236
query23_1 16648 16606 16307 16307
query24 8358 1767 1252 1252
query24_1 1345 1318 1253 1253
query25 539 473 417 417
query26 1638 271 154 154
query27 2852 491 325 325
query28 5758 2204 2208 2204
query29 853 583 508 508
query30 354 267 233 233
query31 1446 788 649 649
query32 71 69 63 63
query33 513 342 301 301
query34 928 962 549 549
query35 840 844 761 761
query36 920 964 859 859
query37 171 88 80 80
query38 3924 3847 3894 3847
query39 754 740 718 718
query39_1 706 699 700 699
query40 265 132 116 116
query41 66 61 59 59
query42 101 97 98 97
query43 425 429 398 398
query44 1303 752 754 752
query45 197 188 189 188
query46 866 979 613 613
query47 1622 1674 1670 1670
query48 316 332 245 245
query49 765 428 355 355
query50 647 285 217 217
query51 3837 3893 3828 3828
query52 109 107 98 98
query53 322 352 298 298
query54 294 271 249 249
query55 79 72 70 70
query56 305 299 285 285
query57 1157 1140 1075 1075
query58 266 258 237 237
query59 2318 2414 2326 2326
query60 313 311 293 293
query61 161 173 163 163
query62 699 668 662 662
query63 323 289 290 289
query64 4882 1319 1002 1002
query65 4067 3940 3955 3940
query66 1350 436 309 309
query67 15072 14879 14873 14873
query68 8617 1032 743 743
query69 562 348 317 317
query70 1077 1055 993 993
query71 414 315 291 291
query72 5813 4889 4952 4889
query73 658 548 312 312
query74 8806 8993 8655 8655
query75 3865 3515 3165 3165
query76 4222 1162 753 753
query77 834 402 288 288
query78 9418 9778 8838 8838
query79 1724 850 622 622
query80 732 646 565 565
query81 520 263 246 246
query82 197 140 108 108
query83 256 301 244 244
query84 272 125 107 107
query85 904 503 453 453
query86 340 294 298 294
query87 4048 4182 3937 3937
query88 3209 2317 2297 2297
query89 465 414 384 384
query90 2255 155 150 150
query91 170 167 142 142
query92 89 69 60 60
query93 2048 908 557 557
query94 460 304 274 274
query95 547 375 308 308
query96 584 458 210 210
query97 2623 2698 2552 2552
query98 232 191 191 191
query99 1293 1289 1215 1215
Total cold run time: 273290 ms
Total hot run time: 182857 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3632513321
# FE Regression Coverage Report
Increment line coverage ` 88.89% (24/27)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_716b0253ceed36a650c57b2c1540b4b7acc340cc_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_716b0253ceed36a650c57b2c1540b4b7acc340cc_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv) Fix query rewrite by mv fail when both use cte and group sets [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57741:
URL: https://github.com/apache/doris/pull/57741#issuecomment-3515887110
# FE Regression Coverage Report
Increment line coverage ` 67.92% (36/53)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57741_0e86ad0c0e49865d18f26b176c15dc8197a754ad_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57741_0e86ad0c0e49865d18f26b176c15dc8197a754ad_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org