You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/29 13:15:18 UTC
[jira] [Commented] (CB-10727) Dialogs plugin has warnings on iOS
[ https://issues.apache.org/jira/browse/CB-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171805#comment-15171805 ]
ASF GitHub Bot commented on CB-10727:
-------------------------------------
GitHub user EddyVerbruggen opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66
CB-10727 Dialogs plugin has warnings on iOS
Should fix https://issues.apache.org/jira/browse/CB-10727
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/EddyVerbruggen/cordova-plugin-dialogs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit f9252d63430dc6c18b6421d45139d672124c21bf
Author: EddyVerbruggen <ed...@gmail.com>
Date: 2016-02-29T12:14:19Z
CB-10727 Dialogs plugin has warnings on iOS
----
> Dialogs plugin has warnings on iOS
> ----------------------------------
>
> Key: CB-10727
> URL: https://issues.apache.org/jira/browse/CB-10727
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Dialogs
> Affects Versions: 4.0.0
> Reporter: Eddy Verbruggen
> Priority: Trivial
>
> When opening CDVNotification.m in Xcode a few warnings are shown in the showDialogWithMessage method:
> NSUIInteger to int conversion for the 'count' variable.
> 'action' is shadowing an already declared variable.
> I'll fix those with a PR.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org