[kyuubi] branch master updated: [KYUUBI #4471] Prompted command for docs generation should skip Java tests

[ch...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 3595d5f65 [KYUUBI #4471] Prompted command for docs generation should skip Java tests
3595d5f65 is described below

commit 3595d5f65e9c85e5388620683d59876b89d1aa6b
Author: zwangsheng <22...@qq.com>
AuthorDate: Thu Mar 9 00:28:49 2023 +0800

    [KYUUBI #4471] Prompted command for docs generation should skip Java tests
    
    ### _Why are the changes needed?_
    
    Notify user fix setting.md with mvn opt ~`-DskipTests`~  `-Dtest=none` to skip unrelated java test.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #4471 from zwangsheng/unit/skip_when_modify_setting.
    
    Closes #4471
    
    f0d7993f5 [zwangsheng] Put -Dtest=none befor
    58bd24571 [zwangsheng] Skip Java Test Case with Recommand -Dtest=none
    3f2ace38d [zwangsheng] Notifiy user fix setting md with skip unit test mvn opts
    
    Authored-by: zwangsheng <22...@qq.com>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 kyuubi-common/src/test/scala/org/apache/kyuubi/MarkdownUtils.scala    | 2 +-
 .../test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kyuubi-common/src/test/scala/org/apache/kyuubi/MarkdownUtils.scala b/kyuubi-common/src/test/scala/org/apache/kyuubi/MarkdownUtils.scala
index 45568df25..25a768b75 100644
--- a/kyuubi-common/src/test/scala/org/apache/kyuubi/MarkdownUtils.scala
+++ b/kyuubi-common/src/test/scala/org/apache/kyuubi/MarkdownUtils.scala
@@ -50,7 +50,7 @@ object MarkdownUtils {
         withClue(s"$markdown out of date, as line ${index + 1} is not expected." +
           " Please update doc with KYUUBI_UPDATE=1 build/mvn clean test" +
           s" -pl $module -am -Pflink-provided,spark-provided,hive-provided" +
-          s" -DwildcardSuites=$agent") {
+          s" -Dtest=none -DwildcardSuites=$agent ") {
           assertResult(str2)(str1)
         }
       }
diff --git a/kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala b/kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
index bb183c00c..9fff482d4 100644
--- a/kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
+++ b/kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
@@ -35,12 +35,12 @@ import org.apache.kyuubi.zookeeper.ZookeeperConf
  *
  * To run the entire test suite:
  * {{{
- *   build/mvn clean test -pl kyuubi-server -am -Pflink-provided,spark-provided,hive-provided -DwildcardSuites=org.apache.kyuubi.config.AllKyuubiConfiguration
+ *   build/mvn clean test -pl kyuubi-server -am -Pflink-provided,spark-provided,hive-provided -Dtest=none -DwildcardSuites=org.apache.kyuubi.config.AllKyuubiConfiguration
  * }}}
  *
  * To re-generate golden files for entire suite, run:
  * {{{
- *   KYUUBI_UPDATE=1 build/mvn clean test -pl kyuubi-server -am -Pflink-provided,spark-provided,hive-provided -DwildcardSuites=org.apache.kyuubi.config.AllKyuubiConfiguration
+ *   KYUUBI_UPDATE=1 build/mvn clean test -pl kyuubi-server -am -Pflink-provided,spark-provided,hive-provided -Dtest=none -DwildcardSuites=org.apache.kyuubi.config.AllKyuubiConfiguration
  * }}}
  */
 // scalastyle:on line.size.limit