[GitHub] [beam] prodriguezdefino commented on a diff in pull request #24274: Support Avro GenericRecord as a valid format for StorageWrite API on BigQueryIO

["prodriguezdefino (via GitHub)" <gi...@apache.org>]

prodriguezdefino commented on code in PR #24274:
URL: https://github.com/apache/beam/pull/24274#discussion_r1092439573


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -3165,6 +3156,26 @@ private <DestinationT> WriteResult continueExpandTyped(
           storageApiDynamicDestinations =
               new StorageApiDynamicDestinationsBeamRow<>(
                   dynamicDestinations, elementSchema, elementToRowFunction);
+        } else if (getAvroRowWriterFactory() != null) {

Review Comment:
   Also and JIC, besides the added unit test, checked this PR's code with a simple [DynamicDestination definition](https://github.com/prodriguezdefino/apache-beam-streaming-tests/blob/map-support-bq-storagewrites/canonical-streaming-pipelines/src/main/java/com/google/cloud/pso/beam/pipelines/transforms/WriteFormatToBigQuery.java#L70) and seems to work fine for job id: `2023-01-31_12_10_08-12389116961981372457`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org