You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Dzeri96 (via GitHub)" <gi...@apache.org> on 2026/02/16 15:02:54 UTC
[PR] [SPARK-55496][K8S] Support re-use of scaled PVCs [spark]
Dzeri96 opened a new pull request, #54336:
URL: https://github.com/apache/spark/pull/54336
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
When attempting to re-use existing persistent volume claims, the method `replacePVCsIfNeeded` in `ExecutorPodsAllocator` now considers PVCs with a higher capacity than what was originally required.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
As explained by the [JIRA ticket](https://issues.apache.org/jira/browse/SPARK-55496), this covers the use case where a volume auto-scaler expands the volumes used by Spark. Without this change, those volumes are ignored, even though they very likely contain valuable shuffle data. In fact, the reason why the previous worker had crashed could very well be because the disk got full before being expanded.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
The default behavior in all versions of Spark so far was to ignore larger disks even if they are owned by the Spark driver. I do not believe my change can break anything, as I can't think of a scenario where somebody was relying on this behavior.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
A new unit test was added.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
**Note**: I ran scalafmt and it tried to re-format almost every line of the files I was working on. Maybe somebody updated the formatting settings and forgot to apply them on old code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55496][K8S] Support re-use of scaled PVCs [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54336:
URL: https://github.com/apache/spark/pull/54336#issuecomment-3909612954
For the following question, the Apache Spark community decided to apply `scalafmt` only for newly added code, @Dzeri96 . I removed your question from the PR description.
> Note: I ran scalafmt and it tried to re-format almost every line of the files I was working on. Maybe somebody updated the formatting settings and forgot to apply them on old code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55496][K8S] Support re-use of scaled PVCs [spark]
Posted by "Dzeri96 (via GitHub)" <gi...@apache.org>.
Dzeri96 commented on PR #54336:
URL: https://github.com/apache/spark/pull/54336#issuecomment-3910192334
Thanks for the warm welcome! I'm working on two more patches in the same area which a are a bit more involved. I'll definitely need your input on these soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55496][K8S] Support re-use of scaled PVCs [spark]
Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli commented on code in PR #54336:
URL: https://github.com/apache/spark/pull/54336#discussion_r2813088995
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala:
##########
@@ -1021,6 +1021,31 @@ class ExecutorPodsAllocatorSuite extends SparkFunSuite with BeforeAndAfter {
assert(podsAllocatorUnderTest.invokePrivate(numOutstandingPods).get() == 0)
}
+ test("SPARK-55496: replacePVCsIfNeeded should re-use disks with larger storage") {
Review Comment:
what about adding a test case on the negative case ? there is a disk but it is smaller than expected
the other test case I would add is about having more than one PVC
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala:
##########
@@ -499,8 +499,8 @@ class ExecutorPodsAllocator(
// Find one with the same storage class and size.
val index = reusablePVCs.indexWhere { p =>
p.getSpec.getStorageClassName == pvc.getSpec.getStorageClassName &&
- p.getSpec.getResources.getRequests.get("storage") ==
- pvc.getSpec.getResources.getRequests.get("storage")
+ p.getSpec.getResources.getRequests.get("storage")
Review Comment:
what about adding a comment here ?
To explain that it is allowed to see a disk that is larger because the autoscaler may have increased the size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55496][K8S] Support re-use of scaled PVCs [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #54336: [SPARK-55496][K8S] Support re-use of scaled PVCs
URL: https://github.com/apache/spark/pull/54336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55496][K8S] Support re-use of scaled PVCs [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54336:
URL: https://github.com/apache/spark/pull/54336#issuecomment-3909868279
I added you (ASF JIRA ID: dzeri96) to the Apache Spark contributor group and assigned SPARK-55496 to you.
Congratulations for your first commit. Welcome to the Apache Spark community!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55496][K8S] Support re-use of scaled PVCs [spark]
Posted by "Dzeri96 (via GitHub)" <gi...@apache.org>.
Dzeri96 commented on code in PR #54336:
URL: https://github.com/apache/spark/pull/54336#discussion_r2813198946
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala:
##########
@@ -499,8 +499,8 @@ class ExecutorPodsAllocator(
// Find one with the same storage class and size.
val index = reusablePVCs.indexWhere { p =>
p.getSpec.getStorageClassName == pvc.getSpec.getStorageClassName &&
- p.getSpec.getResources.getRequests.get("storage") ==
- pvc.getSpec.getResources.getRequests.get("storage")
+ p.getSpec.getResources.getRequests.get("storage")
Review Comment:
Good idea. I changed the old comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org