You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by "Philip Zampino (Jira)" <ji...@apache.org> on 2021/08/26 15:09:00 UTC

[jira] [Commented] (KNOX-2643) TopologyService should validate descriptor and provider config file paths

    [ https://issues.apache.org/jira/browse/KNOX-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405288#comment-17405288 ] 

Philip Zampino commented on KNOX-2643:
--------------------------------------

This is a low-priority issue because TopologiesResource does perform such validation, and it is the only entry point to the affected DefaultTopologyService methods.

> TopologyService should validate descriptor and provider config file paths
> -------------------------------------------------------------------------
>
>                 Key: KNOX-2643
>                 URL: https://issues.apache.org/jira/browse/KNOX-2643
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 1.5.0
>            Reporter: Philip Zampino
>            Priority: Major
>             Fix For: 1.6.0
>
>
> DefaultTopologyService#deployProviderConfiguration and DefaultTopologyService#deployDescriptor blindly trust the file name without validating that the location will be bound to the expected resource directory (e.g., sharedProvidersDirectory, descriptorsDirectory).
> Names that would place the file outside the expected location or intent (e.g., ../gateway-site.xml) should be rejected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)